diff mbox series

[oe,meta-oe] meta-multimedia: fixup LAYERDEPENDS

Message ID 20180924201705.30209-1-nicolas.dechesne@linaro.org
State Superseded
Headers show
Series [oe,meta-oe] meta-multimedia: fixup LAYERDEPENDS | expand

Commit Message

Nicolas Dechesne Sept. 24, 2018, 8:17 p.m. UTC
libebml depends on dos2unix classe since 26dafa0f3542 (libebml: inherit
dos2unix), so LAYERDEPENDS needs to be updated accordingly, otherwise we are
getting a ParseError:

ERROR: ParseError at
/srv/work/oe/meta-openembedded/meta-multimedia/recipes-mkv/libebml/libebml_1.3.0.bb:13:
Could not inherit file classes/dos2unix.bbclass

It was initially found with yocto-check-layer script.

Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>

---
 meta-multimedia/conf/layer.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.18.0

-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Comments

Khem Raj Sept. 24, 2018, 8:26 p.m. UTC | #1
Dos2unix is in oe-core now please try with master

On Mon, Sep 24, 2018 at 1:19 PM Nicolas Dechesne <
nicolas.dechesne@linaro.org> wrote:

> libebml depends on dos2unix classe since 26dafa0f3542 (libebml: inherit

> dos2unix), so LAYERDEPENDS needs to be updated accordingly, otherwise we

> are

> getting a ParseError:

>

> ERROR: ParseError at

> /srv/work/oe/meta-openembedded/meta-multimedia/recipes-mkv/libebml/

> libebml_1.3.0.bb:13:

> Could not inherit file classes/dos2unix.bbclass

>

> It was initially found with yocto-check-layer script.

>

> Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>

> ---

>  meta-multimedia/conf/layer.conf | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

>

> diff --git a/meta-multimedia/conf/layer.conf

> b/meta-multimedia/conf/layer.conf

> index cfedf2f6b..a1dfed4e9 100644

> --- a/meta-multimedia/conf/layer.conf

> +++ b/meta-multimedia/conf/layer.conf

> @@ -27,6 +27,6 @@ BBFILE_PRIORITY_multimedia-layer = "6"

>  # cause compatibility issues with other layers

>  LAYERVERSION_multimedia-layer = "1"

>

> -LAYERDEPENDS_multimedia-layer = "core"

> +LAYERDEPENDS_multimedia-layer = "core openembedded-layer"

>

>  LAYERSERIES_COMPAT_multimedia-layer = "sumo"

> --

> 2.18.0

>

> --

> _______________________________________________

> Openembedded-devel mailing list

> Openembedded-devel@lists.openembedded.org

> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

>

-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Nicolas Dechesne Sept. 24, 2018, 8:45 p.m. UTC | #2
On Mon, Sep 24, 2018 at 10:27 PM Khem Raj <raj.khem@gmail.com> wrote:
>

> Dos2unix is in oe-core now please try with master


ouch. sorry, i missed that. I noticed the issue while running the YP
2.0 compliance script against sumo branch... how do we get that fixed
in sumo then? can we apply something like the below patch on sumo
directly?

>

> On Mon, Sep 24, 2018 at 1:19 PM Nicolas Dechesne <nicolas.dechesne@linaro.org> wrote:

>>

>> libebml depends on dos2unix classe since 26dafa0f3542 (libebml: inherit

>> dos2unix), so LAYERDEPENDS needs to be updated accordingly, otherwise we are

>> getting a ParseError:

>>

>> ERROR: ParseError at

>> /srv/work/oe/meta-openembedded/meta-multimedia/recipes-mkv/libebml/libebml_1.3.0.bb:13:

>> Could not inherit file classes/dos2unix.bbclass

>>

>> It was initially found with yocto-check-layer script.

>>

>> Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>

>> ---

>>  meta-multimedia/conf/layer.conf | 2 +-

>>  1 file changed, 1 insertion(+), 1 deletion(-)

>>

>> diff --git a/meta-multimedia/conf/layer.conf b/meta-multimedia/conf/layer.conf

>> index cfedf2f6b..a1dfed4e9 100644

>> --- a/meta-multimedia/conf/layer.conf

>> +++ b/meta-multimedia/conf/layer.conf

>> @@ -27,6 +27,6 @@ BBFILE_PRIORITY_multimedia-layer = "6"

>>  # cause compatibility issues with other layers

>>  LAYERVERSION_multimedia-layer = "1"

>>

>> -LAYERDEPENDS_multimedia-layer = "core"

>> +LAYERDEPENDS_multimedia-layer = "core openembedded-layer"

>>

>>  LAYERSERIES_COMPAT_multimedia-layer = "sumo"

>> --

>> 2.18.0

>>

>> --

>> _______________________________________________

>> Openembedded-devel mailing list

>> Openembedded-devel@lists.openembedded.org

>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Khem Raj Sept. 24, 2018, 8:53 p.m. UTC | #3
On Mon, Sep 24, 2018 at 1:45 PM Nicolas Dechesne
<nicolas.dechesne@linaro.org> wrote:
>

> On Mon, Sep 24, 2018 at 10:27 PM Khem Raj <raj.khem@gmail.com> wrote:

> >

> > Dos2unix is in oe-core now please try with master

>

> ouch. sorry, i missed that. I noticed the issue while running the YP

> 2.0 compliance script against sumo branch... how do we get that fixed

> in sumo then? can we apply something like the below patch on sumo

> directly?

>


I think that will be fine as long as Armin is fine
with it. Please retag the subject appropriately and resend.

> >

> > On Mon, Sep 24, 2018 at 1:19 PM Nicolas Dechesne <nicolas.dechesne@linaro.org> wrote:

> >>

> >> libebml depends on dos2unix classe since 26dafa0f3542 (libebml: inherit

> >> dos2unix), so LAYERDEPENDS needs to be updated accordingly, otherwise we are

> >> getting a ParseError:

> >>

> >> ERROR: ParseError at

> >> /srv/work/oe/meta-openembedded/meta-multimedia/recipes-mkv/libebml/libebml_1.3.0.bb:13:

> >> Could not inherit file classes/dos2unix.bbclass

> >>

> >> It was initially found with yocto-check-layer script.

> >>

> >> Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>

> >> ---

> >>  meta-multimedia/conf/layer.conf | 2 +-

> >>  1 file changed, 1 insertion(+), 1 deletion(-)

> >>

> >> diff --git a/meta-multimedia/conf/layer.conf b/meta-multimedia/conf/layer.conf

> >> index cfedf2f6b..a1dfed4e9 100644

> >> --- a/meta-multimedia/conf/layer.conf

> >> +++ b/meta-multimedia/conf/layer.conf

> >> @@ -27,6 +27,6 @@ BBFILE_PRIORITY_multimedia-layer = "6"

> >>  # cause compatibility issues with other layers

> >>  LAYERVERSION_multimedia-layer = "1"

> >>

> >> -LAYERDEPENDS_multimedia-layer = "core"

> >> +LAYERDEPENDS_multimedia-layer = "core openembedded-layer"

> >>

> >>  LAYERSERIES_COMPAT_multimedia-layer = "sumo"

> >> --

> >> 2.18.0

> >>

> >> --

> >> _______________________________________________

> >> Openembedded-devel mailing list

> >> Openembedded-devel@lists.openembedded.org

> >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Armin Kuster Sept. 24, 2018, 9:56 p.m. UTC | #4
On 09/24/2018 01:53 PM, Khem Raj wrote:
> On Mon, Sep 24, 2018 at 1:45 PM Nicolas Dechesne

> <nicolas.dechesne@linaro.org> wrote:

>> On Mon, Sep 24, 2018 at 10:27 PM Khem Raj <raj.khem@gmail.com> wrote:

>>> Dos2unix is in oe-core now please try with master

>> ouch. sorry, i missed that. I noticed the issue while running the YP

>> 2.0 compliance script against sumo branch... how do we get that fixed

>> in sumo then? can we apply something like the below patch on sumo

>> directly?

>>

> I think that will be fine as long as Armin is fine

> with it. Please retag the subject appropriately and resend.

At the tone, please leave a message beep....


>

>>> On Mon, Sep 24, 2018 at 1:19 PM Nicolas Dechesne <nicolas.dechesne@linaro.org> wrote:

>>>> libebml depends on dos2unix classe since 26dafa0f3542 (libebml: inherit

>>>> dos2unix), so LAYERDEPENDS needs to be updated accordingly, otherwise we are

>>>> getting a ParseError:

>>>>

>>>> ERROR: ParseError at

>>>> /srv/work/oe/meta-openembedded/meta-multimedia/recipes-mkv/libebml/libebml_1.3.0.bb:13:

>>>> Could not inherit file classes/dos2unix.bbclass

>>>>

>>>> It was initially found with yocto-check-layer script.

>>>>

>>>> Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>

>>>> ---

>>>>  meta-multimedia/conf/layer.conf | 2 +-

>>>>  1 file changed, 1 insertion(+), 1 deletion(-)

>>>>

>>>> diff --git a/meta-multimedia/conf/layer.conf b/meta-multimedia/conf/layer.conf

>>>> index cfedf2f6b..a1dfed4e9 100644

>>>> --- a/meta-multimedia/conf/layer.conf

>>>> +++ b/meta-multimedia/conf/layer.conf

>>>> @@ -27,6 +27,6 @@ BBFILE_PRIORITY_multimedia-layer = "6"

>>>>  # cause compatibility issues with other layers

>>>>  LAYERVERSION_multimedia-layer = "1"

>>>>

>>>> -LAYERDEPENDS_multimedia-layer = "core"

>>>> +LAYERDEPENDS_multimedia-layer = "core openembedded-layer"

>>>>

>>>>  LAYERSERIES_COMPAT_multimedia-layer = "sumo"

>>>> --

>>>> 2.18.0

>>>>

>>>> --

>>>> _______________________________________________

>>>> Openembedded-devel mailing list

>>>> Openembedded-devel@lists.openembedded.org

>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
diff mbox series

Patch

diff --git a/meta-multimedia/conf/layer.conf b/meta-multimedia/conf/layer.conf
index cfedf2f6b..a1dfed4e9 100644
--- a/meta-multimedia/conf/layer.conf
+++ b/meta-multimedia/conf/layer.conf
@@ -27,6 +27,6 @@  BBFILE_PRIORITY_multimedia-layer = "6"
 # cause compatibility issues with other layers
 LAYERVERSION_multimedia-layer = "1"
 
-LAYERDEPENDS_multimedia-layer = "core"
+LAYERDEPENDS_multimedia-layer = "core openembedded-layer"
 
 LAYERSERIES_COMPAT_multimedia-layer = "sumo"