[v4,02/19] cmd: avb read_rb: print rb_idx in hexadecimal

Message ID 20180925144023.24555-3-jens.wiklander@linaro.org
State Accepted
Commit ab2d738239b0eb009a5cab792275b4c36504f595
Headers show
Series
  • AVB using OP-TEE
Related show

Commit Message

Jens Wiklander Sept. 25, 2018, 2:40 p.m.
Prior to this patch was do_avb_write_rb() reading supplied rb_idx as a
hexadecimal number while do_avb_read_rb() printed the read out rb_idx as
decimal number. For consistency change do_avb_read_rb() to print rb_idx
as a hexadecimal number too.

Reviewed-by: Simon Glass <sjg@chromium.org>

Reviewed-by: Igor Opaniuk <igor.opaniuk@linaro.org>

Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

---
 cmd/avb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.17.1

Comments

Tom Rini Oct. 8, 2018, 1:40 a.m. | #1
On Tue, Sep 25, 2018 at 04:40:06PM +0200, Jens Wiklander wrote:

> Prior to this patch was do_avb_write_rb() reading supplied rb_idx as a

> hexadecimal number while do_avb_read_rb() printed the read out rb_idx as

> decimal number. For consistency change do_avb_read_rb() to print rb_idx

> as a hexadecimal number too.

> 

> Reviewed-by: Simon Glass <sjg@chromium.org>

> Reviewed-by: Igor Opaniuk <igor.opaniuk@linaro.org>

> Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>


Applied to u-boot/master, thanks!

-- 
Tom

Patch

diff --git a/cmd/avb.c b/cmd/avb.c
index f045a0c64c4a..ca4b26d5d7b3 100644
--- a/cmd/avb.c
+++ b/cmd/avb.c
@@ -158,7 +158,7 @@  int do_avb_read_rb(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 
 	if (avb_ops->read_rollback_index(avb_ops, index, &rb_idx) ==
 	    AVB_IO_RESULT_OK) {
-		printf("Rollback index: %llu\n", rb_idx);
+		printf("Rollback index: %llx\n", rb_idx);
 		return CMD_RET_SUCCESS;
 	}
 	return CMD_RET_FAILURE;