[v3,1/4] arm: dts: rockchip: add some common pin-settings to rk3399

Message ID 20180927190301.9642-2-manivannan.sadhasivam@linaro.org
State New
Headers show
Series
  • Add Rock960 and Ficus 96Board support
Related show

Commit Message

Manivannan Sadhasivam Sept. 27, 2018, 7:02 p.m.
From: Randy Li <ayaka@soulik.info>

Those pins would be used by many boards.

Commit grabbed from Linux:

commit b41023282d07b61a53e2c9b9508912b1e7ce7b4f
Author: Randy Li <ayaka@soulik.info>
Date:   Thu Jun 21 21:32:10 2018 +0800

    arm64: dts: rockchip: add some common pin-settings to rk3399

    Those pins would be used by many boards.

    Signed-off-by: Randy Li <ayaka@soulik.info>
    Signed-off-by: Heiko Stuebner <heiko@sntech.de>

Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Signed-off-by: Randy Li <ayaka@soulik.info>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
---

Changes in v3: None

Changes in v2: None

 arch/arm/dts/rk3399.dtsi | 55 +++++++++++++++++++++++++++++++++++-----
 1 file changed, 49 insertions(+), 6 deletions(-)

Comments

Peter Robinson Oct. 3, 2018, 7:05 p.m. | #1
On Thu, Sep 27, 2018 at 8:03 PM Manivannan Sadhasivam
<manivannan.sadhasivam@linaro.org> wrote:
>
> From: Randy Li <ayaka@soulik.info>
>
> Those pins would be used by many boards.
>
> Commit grabbed from Linux:
>
> commit b41023282d07b61a53e2c9b9508912b1e7ce7b4f
> Author: Randy Li <ayaka@soulik.info>
> Date:   Thu Jun 21 21:32:10 2018 +0800
>
>     arm64: dts: rockchip: add some common pin-settings to rk3399
>
>     Those pins would be used by many boards.
>
>     Signed-off-by: Randy Li <ayaka@soulik.info>
>     Signed-off-by: Heiko Stuebner <heiko@sntech.de>
>
> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Signed-off-by: Randy Li <ayaka@soulik.info>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
Tested-by: Peter Robinson <pbrobinson@gmail.com>

Tested on both a Rock960 and a Firefly3399

> ---
>
> Changes in v3: None
>
> Changes in v2: None
>
>  arch/arm/dts/rk3399.dtsi | 55 +++++++++++++++++++++++++++++++++++-----
>  1 file changed, 49 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/dts/rk3399.dtsi b/arch/arm/dts/rk3399.dtsi
> index 83c257b1228..8349451b03d 100644
> --- a/arch/arm/dts/rk3399.dtsi
> +++ b/arch/arm/dts/rk3399.dtsi
> @@ -1602,19 +1602,49 @@
>                         drive-strength = <12>;
>                 };
>
> +               pcfg_pull_none_13ma: pcfg-pull-none-13ma {
> +                       bias-disable;
> +                       drive-strength = <13>;
> +               };
> +
> +               pcfg_pull_none_18ma: pcfg-pull-none-18ma {
> +                       bias-disable;
> +                       drive-strength = <18>;
> +               };
> +
> +               pcfg_pull_none_20ma: pcfg-pull-none-20ma {
> +                       bias-disable;
> +                       drive-strength = <20>;
> +               };
> +
> +               pcfg_pull_up_2ma: pcfg-pull-up-2ma {
> +                       bias-pull-up;
> +                       drive-strength = <2>;
> +               };
> +
>                 pcfg_pull_up_8ma: pcfg-pull-up-8ma {
>                         bias-pull-up;
>                         drive-strength = <8>;
>                 };
>
> +               pcfg_pull_up_18ma: pcfg-pull-up-18ma {
> +                       bias-pull-up;
> +                       drive-strength = <18>;
> +               };
> +
> +               pcfg_pull_up_20ma: pcfg-pull-up-20ma {
> +                       bias-pull-up;
> +                       drive-strength = <20>;
> +               };
> +
>                 pcfg_pull_down_4ma: pcfg-pull-down-4ma {
>                         bias-pull-down;
>                         drive-strength = <4>;
>                 };
>
> -               pcfg_pull_up_2ma: pcfg-pull-up-2ma {
> -                       bias-pull-up;
> -                       drive-strength = <2>;
> +               pcfg_pull_down_8ma: pcfg-pull-down-8ma {
> +                       bias-pull-down;
> +                       drive-strength = <8>;
>                 };
>
>                 pcfg_pull_down_12ma: pcfg-pull-down-12ma {
> @@ -1622,9 +1652,22 @@
>                         drive-strength = <12>;
>                 };
>
> -               pcfg_pull_none_13ma: pcfg-pull-none-13ma {
> -                       bias-disable;
> -                       drive-strength = <13>;
> +               pcfg_pull_down_18ma: pcfg-pull-down-18ma {
> +                       bias-pull-down;
> +                       drive-strength = <18>;
> +               };
> +
> +               pcfg_pull_down_20ma: pcfg-pull-down-20ma {
> +                       bias-pull-down;
> +                       drive-strength = <20>;
> +               };
> +
> +               pcfg_output_high: pcfg-output-high {
> +                       output-high;
> +               };
> +
> +               pcfg_output_low: pcfg-output-low {
> +                       output-low;
>                 };
>
>                 clock {
> --
> 2.17.1
>
Philipp Tomsich Oct. 3, 2018, 7:35 p.m. | #2
> From: Randy Li <ayaka@soulik.info>
> 
> Those pins would be used by many boards.
> 
> Commit grabbed from Linux:
> 
> commit b41023282d07b61a53e2c9b9508912b1e7ce7b4f
> Author: Randy Li <ayaka@soulik.info>
> Date:   Thu Jun 21 21:32:10 2018 +0800
> 
>     arm64: dts: rockchip: add some common pin-settings to rk3399
> 
>     Those pins would be used by many boards.
> 
>     Signed-off-by: Randy Li <ayaka@soulik.info>
>     Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> 
> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Signed-off-by: Randy Li <ayaka@soulik.info>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> Tested-by: Peter Robinson <pbrobinson@gmail.com>
> ---
> 
> Changes in v3: None
> 
> Changes in v2: None
> 
>  arch/arm/dts/rk3399.dtsi | 55 +++++++++++++++++++++++++++++++++++-----
>  1 file changed, 49 insertions(+), 6 deletions(-)
> 

Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Philipp Tomsich Dec. 6, 2018, 3:02 p.m. | #3
> From: Randy Li <ayaka@soulik.info>
> 
> Those pins would be used by many boards.
> 
> Commit grabbed from Linux:
> 
> commit b41023282d07b61a53e2c9b9508912b1e7ce7b4f
> Author: Randy Li <ayaka@soulik.info>
> Date:   Thu Jun 21 21:32:10 2018 +0800
> 
>     arm64: dts: rockchip: add some common pin-settings to rk3399
> 
>     Those pins would be used by many boards.
> 
>     Signed-off-by: Randy Li <ayaka@soulik.info>
>     Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> 
> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Signed-off-by: Randy Li <ayaka@soulik.info>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> Tested-by: Peter Robinson <pbrobinson@gmail.com>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
> 
> Changes in v3: None
> 
> Changes in v2: None
> 
>  arch/arm/dts/rk3399.dtsi | 55 +++++++++++++++++++++++++++++++++++-----
>  1 file changed, 49 insertions(+), 6 deletions(-)
> 

Applied to u-boot-rockchip, thanks!

Patch

diff --git a/arch/arm/dts/rk3399.dtsi b/arch/arm/dts/rk3399.dtsi
index 83c257b1228..8349451b03d 100644
--- a/arch/arm/dts/rk3399.dtsi
+++ b/arch/arm/dts/rk3399.dtsi
@@ -1602,19 +1602,49 @@ 
 			drive-strength = <12>;
 		};
 
+		pcfg_pull_none_13ma: pcfg-pull-none-13ma {
+			bias-disable;
+			drive-strength = <13>;
+		};
+
+		pcfg_pull_none_18ma: pcfg-pull-none-18ma {
+			bias-disable;
+			drive-strength = <18>;
+		};
+
+		pcfg_pull_none_20ma: pcfg-pull-none-20ma {
+			bias-disable;
+			drive-strength = <20>;
+		};
+
+		pcfg_pull_up_2ma: pcfg-pull-up-2ma {
+			bias-pull-up;
+			drive-strength = <2>;
+		};
+
 		pcfg_pull_up_8ma: pcfg-pull-up-8ma {
 			bias-pull-up;
 			drive-strength = <8>;
 		};
 
+		pcfg_pull_up_18ma: pcfg-pull-up-18ma {
+			bias-pull-up;
+			drive-strength = <18>;
+		};
+
+		pcfg_pull_up_20ma: pcfg-pull-up-20ma {
+			bias-pull-up;
+			drive-strength = <20>;
+		};
+
 		pcfg_pull_down_4ma: pcfg-pull-down-4ma {
 			bias-pull-down;
 			drive-strength = <4>;
 		};
 
-		pcfg_pull_up_2ma: pcfg-pull-up-2ma {
-			bias-pull-up;
-			drive-strength = <2>;
+		pcfg_pull_down_8ma: pcfg-pull-down-8ma {
+			bias-pull-down;
+			drive-strength = <8>;
 		};
 
 		pcfg_pull_down_12ma: pcfg-pull-down-12ma {
@@ -1622,9 +1652,22 @@ 
 			drive-strength = <12>;
 		};
 
-		pcfg_pull_none_13ma: pcfg-pull-none-13ma {
-			bias-disable;
-			drive-strength = <13>;
+		pcfg_pull_down_18ma: pcfg-pull-down-18ma {
+			bias-pull-down;
+			drive-strength = <18>;
+		};
+
+		pcfg_pull_down_20ma: pcfg-pull-down-20ma {
+			bias-pull-down;
+			drive-strength = <20>;
+		};
+
+		pcfg_output_high: pcfg-output-high {
+			output-high;
+		};
+
+		pcfg_output_low: pcfg-output-low {
+			output-low;
 		};
 
 		clock {