| Message ID | 1538387078-21892-1-git-send-email-yamada.masahiro@socionext.com |
|---|---|
| State | Accepted |
| Commit | fb073a4b473e5b854312dc819c66ded9d103e824 |
| Headers | show |
| Series | [1/3] kbuild: add -Wno-pointer-sign flag unconditionally | expand |
On Mon, Oct 1, 2018 at 2:45 AM Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > > We have raised the compiler requirement from time to time. > With commit cafa0010cd51 ("Raise the minimum required gcc version > to 4.6"), the minimum for GCC is 4.6 now. > > The -Wno-pointer-sign has been here since the pre-git era. It is > documented in the GCC 4.6 manual, and it is recognized by Clang > and ICC as well. > > Let's rip off the cc-disable-warning switch, and see if somebody > complains about it. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index c6d1f2f..505a324 100644 > --- a/Makefile > +++ b/Makefile > @@ -800,7 +800,7 @@ NOSTDINC_FLAGS += -nostdinc -isystem $(shell $(CC) -print-file-name=include) > KBUILD_CFLAGS += $(call cc-option,-Wdeclaration-after-statement,) > > # disable pointer signed / unsigned warnings in gcc 4.0 > -KBUILD_CFLAGS += $(call cc-disable-warning, pointer-sign) > +KBUILD_CFLAGS += -Wno-pointer-sign Tested-by: Nick Desaulniers <ndesaulniers@google.com> https://godbolt.org/z/7vpHIf > > # disable stringop warnings in gcc 8+ > KBUILD_CFLAGS += $(call cc-disable-warning, stringop-truncation) > -- > 2.7.4 > -- Thanks, ~Nick Desaulniers
On Mon, Oct 1, 2018 at 6:45 PM Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > > We have raised the compiler requirement from time to time. > With commit cafa0010cd51 ("Raise the minimum required gcc version > to 4.6"), the minimum for GCC is 4.6 now. > > The -Wno-pointer-sign has been here since the pre-git era. It is > documented in the GCC 4.6 manual, and it is recognized by Clang > and ICC as well. > > Let's rip off the cc-disable-warning switch, and see if somebody > complains about it. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- Applied to linux-kbuild. > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index c6d1f2f..505a324 100644 > --- a/Makefile > +++ b/Makefile > @@ -800,7 +800,7 @@ NOSTDINC_FLAGS += -nostdinc -isystem $(shell $(CC) -print-file-name=include) > KBUILD_CFLAGS += $(call cc-option,-Wdeclaration-after-statement,) > > # disable pointer signed / unsigned warnings in gcc 4.0 > -KBUILD_CFLAGS += $(call cc-disable-warning, pointer-sign) > +KBUILD_CFLAGS += -Wno-pointer-sign > > # disable stringop warnings in gcc 8+ > KBUILD_CFLAGS += $(call cc-disable-warning, stringop-truncation) > -- > 2.7.4 > -- Best Regards Masahiro Yamada
diff --git a/Makefile b/Makefile index c6d1f2f..505a324 100644 --- a/Makefile +++ b/Makefile @@ -800,7 +800,7 @@ NOSTDINC_FLAGS += -nostdinc -isystem $(shell $(CC) -print-file-name=include) KBUILD_CFLAGS += $(call cc-option,-Wdeclaration-after-statement,) # disable pointer signed / unsigned warnings in gcc 4.0 -KBUILD_CFLAGS += $(call cc-disable-warning, pointer-sign) +KBUILD_CFLAGS += -Wno-pointer-sign # disable stringop warnings in gcc 8+ KBUILD_CFLAGS += $(call cc-disable-warning, stringop-truncation)
We have raised the compiler requirement from time to time. With commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6"), the minimum for GCC is 4.6 now. The -Wno-pointer-sign has been here since the pre-git era. It is documented in the GCC 4.6 manual, and it is recognized by Clang and ICC as well. Let's rip off the cc-disable-warning switch, and see if somebody complains about it. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4