| Message ID | 20181001132036.7919-1-peter.maydell@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | tests: Disable test-bdrv-drain and test-replication | expand |
On 10/01/2018 09:20 AM, Peter Maydell wrote: > The test-bdrv-drain and test-replication tests have > intermittent errors which make my build testing process > fail way too often. Disable them both for the moment. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > I'm having trouble making forward progress with applying > merges because of these flaky tests :-( > > tests/Makefile.include | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/Makefile.include b/tests/Makefile.include > index d0c0a92e67d..1cb1e1a1da7 100644 > --- a/tests/Makefile.include > +++ b/tests/Makefile.include > @@ -91,7 +91,7 @@ gcov-files-test-thread-pool-y = thread-pool.c > gcov-files-test-hbitmap-y = util/hbitmap.c > check-unit-y += tests/test-hbitmap$(EXESUF) > gcov-files-test-hbitmap-y = blockjob.c > -check-unit-y += tests/test-bdrv-drain$(EXESUF) > +#check-unit-y += tests/test-bdrv-drain$(EXESUF) > check-unit-y += tests/test-blockjob$(EXESUF) > check-unit-y += tests/test-blockjob-txn$(EXESUF) > check-unit-y += tests/test-block-backend$(EXESUF) > @@ -167,7 +167,7 @@ check-unit-y += tests/test-crypto-xts$(EXESUF) > check-unit-y += tests/test-crypto-block$(EXESUF) > check-unit-y += tests/test-logging$(EXESUF) > gcov-files-test-logging-y = util/log.c > -check-unit-$(CONFIG_REPLICATION) += tests/test-replication$(EXESUF) > +#check-unit-$(CONFIG_REPLICATION) += tests/test-replication$(EXESUF) > check-unit-y += tests/test-bufferiszero$(EXESUF) > gcov-files-check-bufferiszero-y = util/bufferiszero.c > check-unit-y += tests/test-uuid$(EXESUF) > Should we leave some kind of breadcrumb to remind ourselves to fix or re-enable these for the 3.1 RC window? --js
On 2 October 2018 at 21:11, John Snow <jsnow@redhat.com> wrote: > > > On 10/01/2018 09:20 AM, Peter Maydell wrote: >> The test-bdrv-drain and test-replication tests have >> intermittent errors which make my build testing process >> fail way too often. Disable them both for the moment. >> >> Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > Should we leave some kind of breadcrumb to remind ourselves to fix or > re-enable these for the 3.1 RC window? Some fixes attempting to fix the tests have gone in instead of this patch. There does still seem to be a problem with test-bdrv-drain on OSX though. thanks -- PMM
diff --git a/tests/Makefile.include b/tests/Makefile.include index d0c0a92e67d..1cb1e1a1da7 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -91,7 +91,7 @@ gcov-files-test-thread-pool-y = thread-pool.c gcov-files-test-hbitmap-y = util/hbitmap.c check-unit-y += tests/test-hbitmap$(EXESUF) gcov-files-test-hbitmap-y = blockjob.c -check-unit-y += tests/test-bdrv-drain$(EXESUF) +#check-unit-y += tests/test-bdrv-drain$(EXESUF) check-unit-y += tests/test-blockjob$(EXESUF) check-unit-y += tests/test-blockjob-txn$(EXESUF) check-unit-y += tests/test-block-backend$(EXESUF) @@ -167,7 +167,7 @@ check-unit-y += tests/test-crypto-xts$(EXESUF) check-unit-y += tests/test-crypto-block$(EXESUF) check-unit-y += tests/test-logging$(EXESUF) gcov-files-test-logging-y = util/log.c -check-unit-$(CONFIG_REPLICATION) += tests/test-replication$(EXESUF) +#check-unit-$(CONFIG_REPLICATION) += tests/test-replication$(EXESUF) check-unit-y += tests/test-bufferiszero$(EXESUF) gcov-files-check-bufferiszero-y = util/bufferiszero.c check-unit-y += tests/test-uuid$(EXESUF)
The test-bdrv-drain and test-replication tests have intermittent errors which make my build testing process fail way too often. Disable them both for the moment. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- I'm having trouble making forward progress with applying merges because of these flaky tests :-( tests/Makefile.include | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.19.0