| Message ID | 1538443943-29805-1-git-send-email-yamada.masahiro@socionext.com |
|---|---|
| State | Accepted |
| Commit | 9df3e7a7d7d6d92df7c58fb17f900fdc2d8b5031 |
| Headers | show |
| Series | [v2] kbuild: add -Wno-unused-but-set-variable flag unconditionally | expand |
On Mon, Oct 1, 2018 at 6:33 PM Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > > We have raised the compiler requirement from time to time. > With commit cafa0010cd51 ("Raise the minimum required gcc version > to 4.6"), the minimum for GCC is 4.6 now. > > This flag was added by GCC 4.6, and it is recognized by ICC as well. > > It is true that Clang does not support this flag but this commit is > just touching the else part of the "ifeq ($(cc-name),clang)" check. > Hence, Clang build is not affected. > > Let's rip off the cc-disable-warning switch, and see if somebody > complains about it. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > Changes in v2: > - Fix commit log Mashiro, thank you for this fix. Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> > > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index 8a23fee..2627266 100644 > --- a/Makefile > +++ b/Makefile > @@ -716,7 +716,7 @@ else > > # These warnings generated too much noise in a regular build. > # Use make W=1 to enable them (see scripts/Makefile.extrawarn) > -KBUILD_CFLAGS += $(call cc-disable-warning, unused-but-set-variable) > +KBUILD_CFLAGS += -Wno-unused-but-set-variable > endif > > KBUILD_CFLAGS += $(call cc-disable-warning, unused-const-variable) > -- > 2.7.4 > -- Thanks, ~Nick Desaulniers
On Tue, Oct 2, 2018 at 10:33 AM Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > > We have raised the compiler requirement from time to time. > With commit cafa0010cd51 ("Raise the minimum required gcc version > to 4.6"), the minimum for GCC is 4.6 now. > > This flag was added by GCC 4.6, and it is recognized by ICC as well. > > It is true that Clang does not support this flag but this commit is > just touching the else part of the "ifeq ($(cc-name),clang)" check. > Hence, Clang build is not affected. > > Let's rip off the cc-disable-warning switch, and see if somebody > complains about it. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- Applied to linux-kbuild. > > Changes in v2: > - Fix commit log > > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index 8a23fee..2627266 100644 > --- a/Makefile > +++ b/Makefile > @@ -716,7 +716,7 @@ else > > # These warnings generated too much noise in a regular build. > # Use make W=1 to enable them (see scripts/Makefile.extrawarn) > -KBUILD_CFLAGS += $(call cc-disable-warning, unused-but-set-variable) > +KBUILD_CFLAGS += -Wno-unused-but-set-variable > endif > > KBUILD_CFLAGS += $(call cc-disable-warning, unused-const-variable) > -- > 2.7.4 > -- Best Regards Masahiro Yamada
diff --git a/Makefile b/Makefile index 8a23fee..2627266 100644 --- a/Makefile +++ b/Makefile @@ -716,7 +716,7 @@ else # These warnings generated too much noise in a regular build. # Use make W=1 to enable them (see scripts/Makefile.extrawarn) -KBUILD_CFLAGS += $(call cc-disable-warning, unused-but-set-variable) +KBUILD_CFLAGS += -Wno-unused-but-set-variable endif KBUILD_CFLAGS += $(call cc-disable-warning, unused-const-variable)
We have raised the compiler requirement from time to time. With commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6"), the minimum for GCC is 4.6 now. This flag was added by GCC 4.6, and it is recognized by ICC as well. It is true that Clang does not support this flag but this commit is just touching the else part of the "ifeq ($(cc-name),clang)" check. Hence, Clang build is not affected. Let's rip off the cc-disable-warning switch, and see if somebody complains about it. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- Changes in v2: - Fix commit log Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4