nvmem: lpc18xx_eeprom: remove an unused variable

Message ID 20181002211016.2638186-1-arnd@arndb.de
State New
Headers show
Series
  • nvmem: lpc18xx_eeprom: remove an unused variable
Related show

Commit Message

Arnd Bergmann Oct. 2, 2018, 9:10 p.m.
drivers/nvmem/lpc18xx_eeprom.c: In function 'lpc18xx_eeprom_remove':
drivers/nvmem/lpc18xx_eeprom.c:258:6: error: unused variable 'ret' [-Werror=unused-variable]

Fixes: 226014d13fa5 ("nvmem: lpc18xx_eeprom: use devm_nvmem_register()")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 drivers/nvmem/lpc18xx_eeprom.c | 1 -
 1 file changed, 1 deletion(-)

-- 
2.18.0

Comments

Bartosz Golaszewski Oct. 2, 2018, 9:22 p.m. | #1
wt., 2 paź 2018 o 23:10 Arnd Bergmann <arnd@arndb.de> napisał(a):
>

> drivers/nvmem/lpc18xx_eeprom.c: In function 'lpc18xx_eeprom_remove':

> drivers/nvmem/lpc18xx_eeprom.c:258:6: error: unused variable 'ret' [-Werror=unused-variable]

>

> Fixes: 226014d13fa5 ("nvmem: lpc18xx_eeprom: use devm_nvmem_register()")

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

> ---

>  drivers/nvmem/lpc18xx_eeprom.c | 1 -

>  1 file changed, 1 deletion(-)

>

> diff --git a/drivers/nvmem/lpc18xx_eeprom.c b/drivers/nvmem/lpc18xx_eeprom.c

> index b42dbaddb419..66cff1e2147a 100644

> --- a/drivers/nvmem/lpc18xx_eeprom.c

> +++ b/drivers/nvmem/lpc18xx_eeprom.c

> @@ -255,7 +255,6 @@ static int lpc18xx_eeprom_probe(struct platform_device *pdev)

>  static int lpc18xx_eeprom_remove(struct platform_device *pdev)

>  {

>         struct lpc18xx_eeprom_dev *eeprom = platform_get_drvdata(pdev);

> -       int ret;

>

>         clk_disable_unprepare(eeprom->clk);

>

> --

> 2.18.0

>


Hi Arnd,

I had already sent a fix for that with you in Cc:
https://lkml.org/lkml/2018/10/2/439

Best regards,
Bartosz
Arnd Bergmann Oct. 2, 2018, 9:26 p.m. | #2
On Tue, Oct 2, 2018 at 11:22 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>

> wt., 2 paź 2018 o 23:10 Arnd Bergmann <arnd@arndb.de> napisał(a):


> Hi Arnd,

>

> I had already sent a fix for that with you in Cc:

> https://lkml.org/lkml/2018/10/2/439


Ah, good. I had some vague memory of that, but couldn't find it in
my mailbox when I sent out the other fixes for today's
linux-next build regressions, so I included this as well.

Please ignore my patch.

      Arnd

Patch

diff --git a/drivers/nvmem/lpc18xx_eeprom.c b/drivers/nvmem/lpc18xx_eeprom.c
index b42dbaddb419..66cff1e2147a 100644
--- a/drivers/nvmem/lpc18xx_eeprom.c
+++ b/drivers/nvmem/lpc18xx_eeprom.c
@@ -255,7 +255,6 @@  static int lpc18xx_eeprom_probe(struct platform_device *pdev)
 static int lpc18xx_eeprom_remove(struct platform_device *pdev)
 {
 	struct lpc18xx_eeprom_dev *eeprom = platform_get_drvdata(pdev);
-	int ret;
 
 	clk_disable_unprepare(eeprom->clk);