glib-2.0: add missing locale dependencies to PN-ptest

Message ID 20181009110019.16171-1-ross.burton@intel.com
State New
Headers show
Series
  • glib-2.0: add missing locale dependencies to PN-ptest
Related show

Commit Message

Ross Burton Oct. 9, 2018, 11 a.m.
The test suite skips several tests if the required locales are not found, so add
them as dependencies of glib-2.0-ptest.

Signed-off-by: Ross Burton <ross.burton@intel.com>

---
 meta/recipes-core/glib-2.0/glib.inc | 13 +++++++++++++
 1 file changed, 13 insertions(+)

-- 
2.11.0

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Comments

Mauno Niko Nov. 7, 2018, 12:40 p.m. | #1
On 10/09/2018 02:00 PM, Ross Burton wrote:
> The test suite skips several tests if the required locales are not found, so add

> them as dependencies of glib-2.0-ptest.

> 

> Signed-off-by: Ross Burton <ross.burton@intel.com>

> ---

>   meta/recipes-core/glib-2.0/glib.inc | 13 +++++++++++++

>   1 file changed, 13 insertions(+)

> 

> diff --git a/meta/recipes-core/glib-2.0/glib.inc b/meta/recipes-core/glib-2.0/glib.inc

> index ad4f2aebd71..f78aa9bfe6d 100644

> --- a/meta/recipes-core/glib-2.0/glib.inc

> +++ b/meta/recipes-core/glib-2.0/glib.inc

> @@ -152,6 +152,19 @@ RDEPENDS_${PN}-ptest_append_libc-glibc = "\

>               glibc-gconv-iso8859-15 \

>               glibc-charmap-invariant \

>               glibc-localedata-translit-cjk-variants \

> +            locale-base-tr-tr \

> +            locale-base-lt-lt \

> +            locale-base-ja-jp.euc-jp \

> +            locale-base-fa-ir \

> +            locale-base-ru-ru \

> +            locale-base-de-de \

> +            locale-base-pl-pl \

> +            locale-base-hr-hr \

> +            locale-base-el-gr \

> +            locale-base-fr-fr \

> +            locale-base-fr-fr \

> +            locale-base-es-es \

> +            locale-base-en-gb \

>              "

>   

>   INSANE_SKIP_${PN}-ptest += "libdir"

> 


Having GLIBC_GENERATE_LOCALES = "en_US.UTF-8" and 'ptest' in DISTRO_FEATURES, it would seem after this commit I'm seeing following warnings during bitbake:

  WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-de-de, but it isn't a build dependency? [build-deps]
  WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-el-gr, but it isn't a build dependency? [build-deps]
  WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-en-gb, but it isn't a build dependency? [build-deps]
  WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-es-es, but it isn't a build dependency? [build-deps]
  WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-fa-ir, but it isn't a build dependency? [build-deps]
  WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-fr-fr, but it isn't a build dependency? [build-deps]
  WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-hr-hr, but it isn't a build dependency? [build-deps]
  WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-ja-jp.euc-jp, but it isn't a build dependency? [build-deps]
  WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-lt-lt, but it isn't a build dependency? [build-deps]
  WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-ru-ru, but it isn't a build dependency? [build-deps]
  WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-tr-tr, but it isn't a build dependency? [build-deps]

If I switch GLIBC_GENERATE_LOCALES to 'all' these warnings no longer appear.

-Niko
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Ross Burton Nov. 7, 2018, 1:55 p.m. | #2
Sounds about right.  Not sure what would count as a solution here?

Ross
On Wed, 7 Nov 2018 at 12:40, Mauno Niko <niko.mauno@vaisala.com> wrote:
>

> On 10/09/2018 02:00 PM, Ross Burton wrote:

> > The test suite skips several tests if the required locales are not found, so add

> > them as dependencies of glib-2.0-ptest.

> >

> > Signed-off-by: Ross Burton <ross.burton@intel.com>

> > ---

> >   meta/recipes-core/glib-2.0/glib.inc | 13 +++++++++++++

> >   1 file changed, 13 insertions(+)

> >

> > diff --git a/meta/recipes-core/glib-2.0/glib.inc b/meta/recipes-core/glib-2.0/glib.inc

> > index ad4f2aebd71..f78aa9bfe6d 100644

> > --- a/meta/recipes-core/glib-2.0/glib.inc

> > +++ b/meta/recipes-core/glib-2.0/glib.inc

> > @@ -152,6 +152,19 @@ RDEPENDS_${PN}-ptest_append_libc-glibc = "\

> >               glibc-gconv-iso8859-15 \

> >               glibc-charmap-invariant \

> >               glibc-localedata-translit-cjk-variants \

> > +            locale-base-tr-tr \

> > +            locale-base-lt-lt \

> > +            locale-base-ja-jp.euc-jp \

> > +            locale-base-fa-ir \

> > +            locale-base-ru-ru \

> > +            locale-base-de-de \

> > +            locale-base-pl-pl \

> > +            locale-base-hr-hr \

> > +            locale-base-el-gr \

> > +            locale-base-fr-fr \

> > +            locale-base-fr-fr \

> > +            locale-base-es-es \

> > +            locale-base-en-gb \

> >              "

> >

> >   INSANE_SKIP_${PN}-ptest += "libdir"

> >

>

> Having GLIBC_GENERATE_LOCALES = "en_US.UTF-8" and 'ptest' in DISTRO_FEATURES, it would seem after this commit I'm seeing following warnings during bitbake:

>

>   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-de-de, but it isn't a build dependency? [build-deps]

>   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-el-gr, but it isn't a build dependency? [build-deps]

>   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-en-gb, but it isn't a build dependency? [build-deps]

>   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-es-es, but it isn't a build dependency? [build-deps]

>   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-fa-ir, but it isn't a build dependency? [build-deps]

>   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-fr-fr, but it isn't a build dependency? [build-deps]

>   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-hr-hr, but it isn't a build dependency? [build-deps]

>   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-ja-jp.euc-jp, but it isn't a build dependency? [build-deps]

>   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-lt-lt, but it isn't a build dependency? [build-deps]

>   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-ru-ru, but it isn't a build dependency? [build-deps]

>   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-tr-tr, but it isn't a build dependency? [build-deps]

>

> If I switch GLIBC_GENERATE_LOCALES to 'all' these warnings no longer appear.

>

> -Niko

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Martin Jansa Nov. 7, 2018, 2:28 p.m. | #3
It was also discussed here:
http://lists.openembedded.org/pipermail/openembedded-core/2018-October/156591.html

and resulted in few fixes for _remove operator and:
http://lists.openembedded.org/pipermail/openembedded-core/2018-October/156695.html
http://lists.openembedded.org/pipermail/openembedded-core/2018-October/156696.html

On Wed, Nov 7, 2018 at 2:55 PM Burton, Ross <ross.burton@intel.com> wrote:

> Sounds about right.  Not sure what would count as a solution here?

>

> Ross

> On Wed, 7 Nov 2018 at 12:40, Mauno Niko <niko.mauno@vaisala.com> wrote:

> >

> > On 10/09/2018 02:00 PM, Ross Burton wrote:

> > > The test suite skips several tests if the required locales are not

> found, so add

> > > them as dependencies of glib-2.0-ptest.

> > >

> > > Signed-off-by: Ross Burton <ross.burton@intel.com>

> > > ---

> > >   meta/recipes-core/glib-2.0/glib.inc | 13 +++++++++++++

> > >   1 file changed, 13 insertions(+)

> > >

> > > diff --git a/meta/recipes-core/glib-2.0/glib.inc

> b/meta/recipes-core/glib-2.0/glib.inc

> > > index ad4f2aebd71..f78aa9bfe6d 100644

> > > --- a/meta/recipes-core/glib-2.0/glib.inc

> > > +++ b/meta/recipes-core/glib-2.0/glib.inc

> > > @@ -152,6 +152,19 @@ RDEPENDS_${PN}-ptest_append_libc-glibc = "\

> > >               glibc-gconv-iso8859-15 \

> > >               glibc-charmap-invariant \

> > >               glibc-localedata-translit-cjk-variants \

> > > +            locale-base-tr-tr \

> > > +            locale-base-lt-lt \

> > > +            locale-base-ja-jp.euc-jp \

> > > +            locale-base-fa-ir \

> > > +            locale-base-ru-ru \

> > > +            locale-base-de-de \

> > > +            locale-base-pl-pl \

> > > +            locale-base-hr-hr \

> > > +            locale-base-el-gr \

> > > +            locale-base-fr-fr \

> > > +            locale-base-fr-fr \

> > > +            locale-base-es-es \

> > > +            locale-base-en-gb \

> > >              "

> > >

> > >   INSANE_SKIP_${PN}-ptest += "libdir"

> > >

> >

> > Having GLIBC_GENERATE_LOCALES = "en_US.UTF-8" and 'ptest' in

> DISTRO_FEATURES, it would seem after this commit I'm seeing following

> warnings during bitbake:

> >

> >   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest

> rdepends on locale-base-de-de, but it isn't a build dependency? [build-deps]

> >   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest

> rdepends on locale-base-el-gr, but it isn't a build dependency? [build-deps]

> >   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest

> rdepends on locale-base-en-gb, but it isn't a build dependency? [build-deps]

> >   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest

> rdepends on locale-base-es-es, but it isn't a build dependency? [build-deps]

> >   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest

> rdepends on locale-base-fa-ir, but it isn't a build dependency? [build-deps]

> >   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest

> rdepends on locale-base-fr-fr, but it isn't a build dependency? [build-deps]

> >   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest

> rdepends on locale-base-hr-hr, but it isn't a build dependency? [build-deps]

> >   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest

> rdepends on locale-base-ja-jp.euc-jp, but it isn't a build dependency?

> [build-deps]

> >   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest

> rdepends on locale-base-lt-lt, but it isn't a build dependency? [build-deps]

> >   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest

> rdepends on locale-base-ru-ru, but it isn't a build dependency? [build-deps]

> >   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest

> rdepends on locale-base-tr-tr, but it isn't a build dependency? [build-deps]

> >

> > If I switch GLIBC_GENERATE_LOCALES to 'all' these warnings no longer

> appear.

> >

> > -Niko

> --

> _______________________________________________

> Openembedded-core mailing list

> Openembedded-core@lists.openembedded.org

> http://lists.openembedded.org/mailman/listinfo/openembedded-core

>
<div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr">It was also discussed here:<div><a href="http://lists.openembedded.org/pipermail/openembedded-core/2018-October/156591.html">http://lists.openembedded.org/pipermail/openembedded-core/2018-October/156591.html</a><br></div><div><br></div><div>and resulted in few fixes for _remove operator and:</div><div><a href="http://lists.openembedded.org/pipermail/openembedded-core/2018-October/156695.html">http://lists.openembedded.org/pipermail/openembedded-core/2018-October/156695.html</a><br></div><div><a href="http://lists.openembedded.org/pipermail/openembedded-core/2018-October/156696.html">http://lists.openembedded.org/pipermail/openembedded-core/2018-October/156696.html</a><br></div></div></div></div></div><br><div class="gmail_quote"><div dir="ltr">On Wed, Nov 7, 2018 at 2:55 PM Burton, Ross &lt;<a href="mailto:ross.burton@intel.com">ross.burton@intel.com</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Sounds about right.  Not sure what would count as a solution here?<br>
<br>
Ross<br>
On Wed, 7 Nov 2018 at 12:40, Mauno Niko &lt;<a href="mailto:niko.mauno@vaisala.com" target="_blank">niko.mauno@vaisala.com</a>&gt; wrote:<br>
&gt;<br>
&gt; On 10/09/2018 02:00 PM, Ross Burton wrote:<br>
&gt; &gt; The test suite skips several tests if the required locales are not found, so add<br>
&gt; &gt; them as dependencies of glib-2.0-ptest.<br>
&gt; &gt;<br>
&gt; &gt; Signed-off-by: Ross Burton &lt;<a href="mailto:ross.burton@intel.com" target="_blank">ross.burton@intel.com</a>&gt;<br>
&gt; &gt; ---<br>
&gt; &gt;   meta/recipes-core/glib-2.0/glib.inc | 13 +++++++++++++<br>
&gt; &gt;   1 file changed, 13 insertions(+)<br>
&gt; &gt;<br>
&gt; &gt; diff --git a/meta/recipes-core/glib-2.0/glib.inc b/meta/recipes-core/glib-2.0/glib.inc<br>
&gt; &gt; index ad4f2aebd71..f78aa9bfe6d 100644<br>
&gt; &gt; --- a/meta/recipes-core/glib-2.0/glib.inc<br>
&gt; &gt; +++ b/meta/recipes-core/glib-2.0/glib.inc<br>
&gt; &gt; @@ -152,6 +152,19 @@ RDEPENDS_${PN}-ptest_append_libc-glibc = &quot;\<br>
&gt; &gt;               glibc-gconv-iso8859-15 \<br>
&gt; &gt;               glibc-charmap-invariant \<br>
&gt; &gt;               glibc-localedata-translit-cjk-variants \<br>
&gt; &gt; +            locale-base-tr-tr \<br>
&gt; &gt; +            locale-base-lt-lt \<br>
&gt; &gt; +            locale-base-ja-jp.euc-jp \<br>
&gt; &gt; +            locale-base-fa-ir \<br>
&gt; &gt; +            locale-base-ru-ru \<br>
&gt; &gt; +            locale-base-de-de \<br>
&gt; &gt; +            locale-base-pl-pl \<br>
&gt; &gt; +            locale-base-hr-hr \<br>
&gt; &gt; +            locale-base-el-gr \<br>
&gt; &gt; +            locale-base-fr-fr \<br>
&gt; &gt; +            locale-base-fr-fr \<br>
&gt; &gt; +            locale-base-es-es \<br>
&gt; &gt; +            locale-base-en-gb \<br>
&gt; &gt;              &quot;<br>
&gt; &gt;<br>
&gt; &gt;   INSANE_SKIP_${PN}-ptest += &quot;libdir&quot;<br>
&gt; &gt;<br>
&gt;<br>
&gt; Having GLIBC_GENERATE_LOCALES = &quot;en_US.UTF-8&quot; and &#39;ptest&#39; in DISTRO_FEATURES, it would seem after this commit I&#39;m seeing following warnings during bitbake:<br>
&gt;<br>
&gt;   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-de-de, but it isn&#39;t a build dependency? [build-deps]<br>
&gt;   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-el-gr, but it isn&#39;t a build dependency? [build-deps]<br>
&gt;   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-en-gb, but it isn&#39;t a build dependency? [build-deps]<br>
&gt;   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-es-es, but it isn&#39;t a build dependency? [build-deps]<br>
&gt;   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-fa-ir, but it isn&#39;t a build dependency? [build-deps]<br>
&gt;   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-fr-fr, but it isn&#39;t a build dependency? [build-deps]<br>
&gt;   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-hr-hr, but it isn&#39;t a build dependency? [build-deps]<br>
&gt;   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-ja-jp.euc-jp, but it isn&#39;t a build dependency? [build-deps]<br>
&gt;   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-lt-lt, but it isn&#39;t a build dependency? [build-deps]<br>
&gt;   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-ru-ru, but it isn&#39;t a build dependency? [build-deps]<br>
&gt;   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-tr-tr, but it isn&#39;t a build dependency? [build-deps]<br>
&gt;<br>
&gt; If I switch GLIBC_GENERATE_LOCALES to &#39;all&#39; these warnings no longer appear.<br>
&gt;<br>
&gt; -Niko<br>
-- <br>
_______________________________________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
</blockquote></div>
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-core/glib-2.0/glib.inc b/meta/recipes-core/glib-2.0/glib.inc
index ad4f2aebd71..f78aa9bfe6d 100644
--- a/meta/recipes-core/glib-2.0/glib.inc
+++ b/meta/recipes-core/glib-2.0/glib.inc
@@ -152,6 +152,19 @@  RDEPENDS_${PN}-ptest_append_libc-glibc = "\
             glibc-gconv-iso8859-15 \
             glibc-charmap-invariant \
             glibc-localedata-translit-cjk-variants \
+            locale-base-tr-tr \
+            locale-base-lt-lt \
+            locale-base-ja-jp.euc-jp \
+            locale-base-fa-ir \
+            locale-base-ru-ru \
+            locale-base-de-de \
+            locale-base-pl-pl \
+            locale-base-hr-hr \
+            locale-base-el-gr \
+            locale-base-fr-fr \
+            locale-base-fr-fr \
+            locale-base-es-es \
+            locale-base-en-gb \
            "
 
 INSANE_SKIP_${PN}-ptest += "libdir"