[2/3] ARM: qemu-arm: enable usb mass storage in default configuration

Message ID 20181012050909.7009-3-takahiro.akashi@linaro.org
State New
Headers show
Series
  • uefi: support USB boot in distro boot
Related show

Commit Message

AKASHI Takahiro Oct. 12, 2018, 5:09 a.m.
This is a preparatory patch so that USB boot will be supported
in distro boot script by default.

Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
---
 configs/qemu_arm64_defconfig | 1 +
 configs/qemu_arm_defconfig   | 1 +
 2 files changed, 2 insertions(+)

Comments

Alexander Graf Oct. 16, 2018, 1:21 p.m. | #1
On 12.10.18 07:09, AKASHI Takahiro wrote:
> This is a preparatory patch so that USB boot will be supported
> in distro boot script by default.
> 
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>

How about something like this instead?

Alex


diff --git a/Kconfig b/Kconfig
index 1aadf5dd2d..8d515fe18c 100644
--- a/Kconfig
+++ b/Kconfig
@@ -86,6 +86,7 @@ config DISTRO_DEFAULTS
 	select SUPPORT_RAW_INITRD
 	select SYS_LONGHELP
 	imply CMD_MII if NET
+	imply USB_STORAGE if USB
 	imply USE_BOOTCOMMAND
 	help
 	  Select this to enable various options and commands which are suitable
AKASHI Takahiro Oct. 18, 2018, 2:44 a.m. | #2
On Tue, Oct 16, 2018 at 03:21:10PM +0200, Alexander Graf wrote:
> 
> 
> On 12.10.18 07:09, AKASHI Takahiro wrote:
> > This is a preparatory patch so that USB boot will be supported
> > in distro boot script by default.
> > 
> > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> 
> How about something like this instead?

Looks smart.

Thanks,
-Takahiro Akashi

> Alex
> 
> 
> diff --git a/Kconfig b/Kconfig
> index 1aadf5dd2d..8d515fe18c 100644
> --- a/Kconfig
> +++ b/Kconfig
> @@ -86,6 +86,7 @@ config DISTRO_DEFAULTS
>  	select SUPPORT_RAW_INITRD
>  	select SYS_LONGHELP
>  	imply CMD_MII if NET
> +	imply USB_STORAGE if USB
>  	imply USE_BOOTCOMMAND
>  	help
>  	  Select this to enable various options and commands which are suitable

Patch

diff --git a/configs/qemu_arm64_defconfig b/configs/qemu_arm64_defconfig
index 7fd726fdda35..91c97181ab9f 100644
--- a/configs/qemu_arm64_defconfig
+++ b/configs/qemu_arm64_defconfig
@@ -32,3 +32,4 @@  CONFIG_USB=y
 CONFIG_DM_USB=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_EHCI_PCI=y
+CONFIG_USB_STORAGE=y
diff --git a/configs/qemu_arm_defconfig b/configs/qemu_arm_defconfig
index fbceaf3c52f3..4f4f9b791415 100644
--- a/configs/qemu_arm_defconfig
+++ b/configs/qemu_arm_defconfig
@@ -32,3 +32,4 @@  CONFIG_USB=y
 CONFIG_DM_USB=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_EHCI_PCI=y
+CONFIG_USB_STORAGE=y