From patchwork Fri Oct 12 14:57:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 148784 Delivered-To: patch@linaro.org Received: by 2002:a2e:8595:0:0:0:0:0 with SMTP id b21-v6csp834469lji; Fri, 12 Oct 2018 07:58:46 -0700 (PDT) X-Google-Smtp-Source: ACcGV62Bd3xaCUpnCV1Nr1xJVOznepuWQ1FNNU6SHjrbi51UKFAzu2S/RaLN2Lczxtxtz8DJUzXa X-Received: by 2002:a17:902:7613:: with SMTP id k19-v6mr6233858pll.98.1539356326852; Fri, 12 Oct 2018 07:58:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539356326; cv=none; d=google.com; s=arc-20160816; b=V9mbJZe8Ba7oNkK/hjafjBEgsfDEP2cJK0h2Z+z3RQsZogDabBkttKAwiKCN2zLcWX Ya60DFDr0APePEnjmM6fHOWg2VJE9M7PYHkzjoeVgIWkvMRghZJKfQ8M9VzTAfOoI9yX VBMqWg3efuXFhgHDFI0iepw/rasV6yV1Q70hHszkUjF8UiZpibAln4+heX5PAASTOXGg Zja3jafS8yfqFCyUB3pVgbxXo5QXdxNeWBRwdtLyxKYCoyHmTJ2ck7IC9elg3AKwgK0u AsEscBp1vg6zphL6ox0hHbLtUIP8j53yZFp9Q0bUnGnaxFaZUIpt4w3hp6l+tE3vIgsF /NVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter; bh=gNE/DT+c7dmomudF11g+hbkGUuoIwZPmrwl+ytK2nn8=; b=jwSShm8Tov3ByzgHIvA0hBlM2HpGI+A+NhxM1W4Bq6JmBaRIgPUjckGstvxrrArGtb xmmw1jz5FnxrZM7lj/G8L2VG8Z/MlN4szhObIDBkem+SI/S8t5/kitwdgrTXKeK2pHpa z+TfbNb4HhmVDEY/hYanBzjdUXR0bMZkVN4fSgKBj1fSB+iFsUpCCf1PO4o7uoear0lA 5/LO83j8bYSepJFPaCTma4lfVvTBkE6hjoTi0wdxhhQM7x878LUnmL/jkxLOS68DzcMh IGyW1w6BGLZWCqRSFrdR+TqddMQfFE39R2xXbNIlKkgs8w9SpOgcxnzWG82qYxhGdTXB daBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=19e1xXVy; spf=pass (google.com: best guess record for domain of linux-mmc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-mmc-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r21-v6si1465008pgo.506.2018.10.12.07.58.46; Fri, 12 Oct 2018 07:58:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-mmc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=19e1xXVy; spf=pass (google.com: best guess record for domain of linux-mmc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-mmc-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728786AbeJLWbg (ORCPT + 5 others); Fri, 12 Oct 2018 18:31:36 -0400 Received: from conuserg-07.nifty.com ([210.131.2.74]:52675 "EHLO conuserg-07.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728720AbeJLWbg (ORCPT ); Fri, 12 Oct 2018 18:31:36 -0400 Received: from grover.tkatk1.zaq.ne.jp (zaqdadce369.zaq.ne.jp [218.220.227.105]) (authenticated) by conuserg-07.nifty.com with ESMTP id w9CEvjPA016823; Fri, 12 Oct 2018 23:57:46 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-07.nifty.com w9CEvjPA016823 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1539356267; bh=gNE/DT+c7dmomudF11g+hbkGUuoIwZPmrwl+ytK2nn8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=19e1xXVy8/mZhAhIGINGf7jhjKSgnirV57Kay2CQIN49iN8xYxj7b6KqdeBnQMizR I9MudRozbmuTMUz5RaXQ9oibBq4OChrxPvaVTQdeJKCFOk9P4ylR8HpqJDtr9ypF9w HvErPicdOkz1r010+6Tx8wNU2mVxTy5FSMppPthJndBHfRJZYFa5/p0ik1boGHjwMl rQmCMSUt+effQEsU9+m31dXRzdTfx2CWmNsw4+VXbGKy7+eFigyey56JkJD2BmjoxE K5dCmVdtThyIMALPOu0Av9Xhgq8ArejxfkrDts29j3Xpy3n6Z4kznGCWapuAfUYvyp hxkaNBtWIiZjQ== X-Nifty-SrcIP: [218.220.227.105] From: Masahiro Yamada To: linux-mmc@vger.kernel.org, Ulf Hansson Cc: Wolfram Sang , Masahiro Yamada , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] mmc: uniphier-sd: fix DMA disabling Date: Fri, 12 Oct 2018 23:57:37 +0900 Message-Id: <1539356258-12374-2-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1539356258-12374-1-git-send-email-yamada.masahiro@socionext.com> References: <1539356258-12374-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org Once DMA is enabled, it is not possible to disable it because uniphier_sd_dma_endisable() always sets the DMA_ENABLE_DMASDRW bit regardless of the argument 'enable'. It should disable DMA when 'enable' is false. Signed-off-by: Masahiro Yamada --- drivers/mmc/host/uniphier-sd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4 Acked-by: Wolfram Sang diff --git a/drivers/mmc/host/uniphier-sd.c b/drivers/mmc/host/uniphier-sd.c index 10e7b30..10d49aa 100644 --- a/drivers/mmc/host/uniphier-sd.c +++ b/drivers/mmc/host/uniphier-sd.c @@ -78,7 +78,7 @@ static void *uniphier_sd_priv(struct tmio_mmc_host *host) static void uniphier_sd_dma_endisable(struct tmio_mmc_host *host, int enable) { - sd_ctrl_write16(host, CTL_DMA_ENABLE, DMA_ENABLE_DMASDRW); + sd_ctrl_write16(host, CTL_DMA_ENABLE, enable ? DMA_ENABLE_DMASDRW : 0); } /* external DMA engine */