| Message ID | 1539673418-7279-2-git-send-email-firoz.khan@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | parisc: system call table generation support | expand |
On 16.10.2018 09:03, Firoz Khan wrote: > All the __IGNORE* entries are resides in the uapi header > file move to non uapi header asm/unistd.h as it is not > used by any user space applications. > > It is correct to keep __IGNORE* entry in non uapi header > asm/unistd.h while uapi/asm/unistd.h must hold information > only useful for user space applications. > > One of the patch in this patch series will generate uapi > header file. The information which directly used by the > user space application must be present in uapi file. > > Signed-off-by: Firoz Khan <firoz.khan@linaro.org> You may add an Acked-by: Helge Deller <deller@gmx.de> I've tested it by sucessfully booting a 32bit kernel. Thanks! Helge > --- > arch/parisc/include/asm/unistd.h | 6 ++++++ > arch/parisc/include/uapi/asm/unistd.h | 7 ------- > 2 files changed, 6 insertions(+), 7 deletions(-) > > diff --git a/arch/parisc/include/asm/unistd.h b/arch/parisc/include/asm/unistd.h > index 3d507d0..93fd9f6 100644 > --- a/arch/parisc/include/asm/unistd.h > +++ b/arch/parisc/include/asm/unistd.h > @@ -8,6 +8,12 @@ > > #define SYS_ify(syscall_name) __NR_##syscall_name > > +#define __IGNORE_select /* newselect */ > +#define __IGNORE_fadvise64 /* fadvise64_64 */ > +#define __IGNORE_pkey_mprotect > +#define __IGNORE_pkey_alloc > +#define __IGNORE_pkey_free > + > #ifndef ASM_LINE_SEP > # define ASM_LINE_SEP ; > #endif > diff --git a/arch/parisc/include/uapi/asm/unistd.h b/arch/parisc/include/uapi/asm/unistd.h > index dc77c5a..bb52e12 100644 > --- a/arch/parisc/include/uapi/asm/unistd.h > +++ b/arch/parisc/include/uapi/asm/unistd.h > @@ -368,13 +368,6 @@ > > #define __NR_Linux_syscalls (__NR_io_pgetevents + 1) > > - > -#define __IGNORE_select /* newselect */ > -#define __IGNORE_fadvise64 /* fadvise64_64 */ > -#define __IGNORE_pkey_mprotect > -#define __IGNORE_pkey_alloc > -#define __IGNORE_pkey_free > - > #define LINUX_GATEWAY_ADDR 0x100 > > #endif /* _UAPI_ASM_PARISC_UNISTD_H_ */ >
diff --git a/arch/parisc/include/asm/unistd.h b/arch/parisc/include/asm/unistd.h index 3d507d0..93fd9f6 100644 --- a/arch/parisc/include/asm/unistd.h +++ b/arch/parisc/include/asm/unistd.h @@ -8,6 +8,12 @@ #define SYS_ify(syscall_name) __NR_##syscall_name +#define __IGNORE_select /* newselect */ +#define __IGNORE_fadvise64 /* fadvise64_64 */ +#define __IGNORE_pkey_mprotect +#define __IGNORE_pkey_alloc +#define __IGNORE_pkey_free + #ifndef ASM_LINE_SEP # define ASM_LINE_SEP ; #endif diff --git a/arch/parisc/include/uapi/asm/unistd.h b/arch/parisc/include/uapi/asm/unistd.h index dc77c5a..bb52e12 100644 --- a/arch/parisc/include/uapi/asm/unistd.h +++ b/arch/parisc/include/uapi/asm/unistd.h @@ -368,13 +368,6 @@ #define __NR_Linux_syscalls (__NR_io_pgetevents + 1) - -#define __IGNORE_select /* newselect */ -#define __IGNORE_fadvise64 /* fadvise64_64 */ -#define __IGNORE_pkey_mprotect -#define __IGNORE_pkey_alloc -#define __IGNORE_pkey_free - #define LINUX_GATEWAY_ADDR 0x100 #endif /* _UAPI_ASM_PARISC_UNISTD_H_ */
All the __IGNORE* entries are resides in the uapi header file move to non uapi header asm/unistd.h as it is not used by any user space applications. It is correct to keep __IGNORE* entry in non uapi header asm/unistd.h while uapi/asm/unistd.h must hold information only useful for user space applications. One of the patch in this patch series will generate uapi header file. The information which directly used by the user space application must be present in uapi file. Signed-off-by: Firoz Khan <firoz.khan@linaro.org> --- arch/parisc/include/asm/unistd.h | 6 ++++++ arch/parisc/include/uapi/asm/unistd.h | 7 ------- 2 files changed, 6 insertions(+), 7 deletions(-) -- 1.9.1