| Message ID | 20181018132109.31192-9-julien.grall@arm.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | xen/arm: Bunch of clean-ups | expand |
Hello Julien, In case you are ordering those includes in the alphabetical order, shouldn't be `asm/...` includes placed above `xen/...`? -- *Andrii Anisov*
On 10/23/18 1:52 PM, Andrii Anisov wrote: > Hello Julien, Hi, > > In case you are ordering those includes in the alphabetical order, > shouldn't be `asm/...` includes placed above `xen/...`? The common headers (e.g xen/) should be placed before architecture specific (asm/). They should then be ordered alphabetically among themselves. Cheers,
Hello Julien, On 23.10.18 16:26, Julien Grall wrote: > The common headers (e.g xen/) should be placed before architecture > specific (asm/). They should then be ordered alphabetically among > themselves. Yep, I see the point. -- *Andrii Anisov*
On 18.10.18 16:20, Julien Grall wrote: > Signed-off-by: Julien Grall <julien.grall@arm.com> > --- Reviewed-by: Andrii Anisov<andrii_anisov@epam.com>
On 18.10.18 16:20, Julien Grall wrote: > Signed-off-by: Julien Grall <julien.grall@arm.com> > --- Reviewed-by: Andrii Anisov<andrii_anisov@epam.com> -- *Andrii Anisov* <html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr"> <font size="2"><span style="font-size:11pt"> <div class="PlainText"><br> On 18.10.18 16:20, Julien Grall wrote:<br> > Signed-off-by: Julien Grall <julien.grall@arm.com><br> > ---<br> <br> Reviewed-by: Andrii Anisov<andrii_anisov@epam.com><br> <br> -- <br> <br> *Andrii Anisov*<br> <br> <br> </div> </span></font></div> </body> </html>
diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c index 8ff4e0f08e..a7ce94789c 100644 --- a/xen/arch/arm/gic-v3.c +++ b/xen/arch/arm/gic-v3.c @@ -21,25 +21,27 @@ * GNU General Public License for more details. */ -#include <xen/lib.h> +#include <xen/acpi.h> +#include <xen/delay.h> +#include <xen/device_tree.h> +#include <xen/errno.h> #include <xen/init.h> -#include <xen/mm.h> -#include <xen/irq.h> #include <xen/iocap.h> +#include <xen/irq.h> +#include <xen/lib.h> +#include <xen/libfdt/libfdt.h> +#include <xen/mm.h> #include <xen/sched.h> -#include <xen/errno.h> -#include <xen/delay.h> -#include <xen/device_tree.h> #include <xen/sizes.h> -#include <xen/libfdt/libfdt.h> -#include <xen/acpi.h> + #include <acpi/actables.h> -#include <asm/io.h> + +#include <asm/cpufeature.h> #include <asm/device.h> #include <asm/gic.h> #include <asm/gic_v3_defs.h> #include <asm/gic_v3_its.h> -#include <asm/cpufeature.h> +#include <asm/io.h> /* Global state */ static struct {
Signed-off-by: Julien Grall <julien.grall@arm.com> --- xen/arch/arm/gic-v3.c | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-)