| Message ID | 20181019104326.28052-1-alex.bennee@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | configure: set cross_cc_FOO from cc, not host_cc | expand |
On 2018-10-19 12:43, Alex Bennée wrote: > The purpose of the code is to use the designated compiler for building > the targets test cases. This is not actually host_cc which will still > be cc even when we are cross compiling. As the tests for $cpu all use > $cc we should do the same. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > Reported-by: Richard Henderson <richard.henderson@linaro.org> > --- > configure | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/configure b/configure > index 9138af37f8..d6605bd633 100755 > --- a/configure > +++ b/configure > @@ -717,37 +717,37 @@ case "$cpu" in > ppc|ppc64|s390|s390x|sparc64|x32) > cpu="$cpu" > supported_cpu="yes" > - eval "cross_cc_${cpu}=\$host_cc" > + eval "cross_cc_${cpu}=\$cc" > ;; > i386|i486|i586|i686|i86pc|BePC) > cpu="i386" > supported_cpu="yes" > - cross_cc_i386=$host_cc > + cross_cc_i386=$cc > ;; > x86_64|amd64) > cpu="x86_64" > supported_cpu="yes" > - cross_cc_x86_64=$host_cc > + cross_cc_x86_64=$cc > ;; > armv*b|armv*l|arm) > cpu="arm" > supported_cpu="yes" > - cross_cc_arm=$host_cc > + cross_cc_arm=$cc > ;; > aarch64) > cpu="aarch64" > supported_cpu="yes" > - cross_cc_aarch64=$host_cc > + cross_cc_aarch64=$cc > ;; > mips*) > cpu="mips" > supported_cpu="yes" > - cross_cc_mips=$host_cc > + cross_cc_mips=$cc > ;; > sparc|sun4[cdmuv]) > cpu="sparc" > supported_cpu="yes" > - cross_cc_sparc=$host_cc > + cross_cc_sparc=$cc > ;; > *) > # This will result in either an error or falling back to TCI later > Sounds like the right thing to do. Reviewed-by: Thomas Huth <thuth@redhat.com>
On 19/10/2018 12:43, Alex Bennée wrote: > The purpose of the code is to use the designated compiler for building > the targets test cases. This is not actually host_cc which will still > be cc even when we are cross compiling. As the tests for $cpu all use > $cc we should do the same. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > Reported-by: Richard Henderson <richard.henderson@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > configure | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/configure b/configure > index 9138af37f8..d6605bd633 100755 > --- a/configure > +++ b/configure > @@ -717,37 +717,37 @@ case "$cpu" in > ppc|ppc64|s390|s390x|sparc64|x32) > cpu="$cpu" > supported_cpu="yes" > - eval "cross_cc_${cpu}=\$host_cc" > + eval "cross_cc_${cpu}=\$cc" > ;; > i386|i486|i586|i686|i86pc|BePC) > cpu="i386" > supported_cpu="yes" > - cross_cc_i386=$host_cc > + cross_cc_i386=$cc > ;; > x86_64|amd64) > cpu="x86_64" > supported_cpu="yes" > - cross_cc_x86_64=$host_cc > + cross_cc_x86_64=$cc > ;; > armv*b|armv*l|arm) > cpu="arm" > supported_cpu="yes" > - cross_cc_arm=$host_cc > + cross_cc_arm=$cc > ;; > aarch64) > cpu="aarch64" > supported_cpu="yes" > - cross_cc_aarch64=$host_cc > + cross_cc_aarch64=$cc > ;; > mips*) > cpu="mips" > supported_cpu="yes" > - cross_cc_mips=$host_cc > + cross_cc_mips=$cc > ;; > sparc|sun4[cdmuv]) > cpu="sparc" > supported_cpu="yes" > - cross_cc_sparc=$host_cc > + cross_cc_sparc=$cc > ;; > *) > # This will result in either an error or falling back to TCI later >
On 10/19/18 3:43 AM, Alex Bennée wrote: > The purpose of the code is to use the designated compiler for building > the targets test cases. This is not actually host_cc which will still > be cc even when we are cross compiling. As the tests for $cpu all use > $cc we should do the same. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > Reported-by: Richard Henderson <richard.henderson@linaro.org> > --- > configure | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) Tested-by: Richard Henderson <richard.henderson@linaro.org> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
diff --git a/configure b/configure index 9138af37f8..d6605bd633 100755 --- a/configure +++ b/configure @@ -717,37 +717,37 @@ case "$cpu" in ppc|ppc64|s390|s390x|sparc64|x32) cpu="$cpu" supported_cpu="yes" - eval "cross_cc_${cpu}=\$host_cc" + eval "cross_cc_${cpu}=\$cc" ;; i386|i486|i586|i686|i86pc|BePC) cpu="i386" supported_cpu="yes" - cross_cc_i386=$host_cc + cross_cc_i386=$cc ;; x86_64|amd64) cpu="x86_64" supported_cpu="yes" - cross_cc_x86_64=$host_cc + cross_cc_x86_64=$cc ;; armv*b|armv*l|arm) cpu="arm" supported_cpu="yes" - cross_cc_arm=$host_cc + cross_cc_arm=$cc ;; aarch64) cpu="aarch64" supported_cpu="yes" - cross_cc_aarch64=$host_cc + cross_cc_aarch64=$cc ;; mips*) cpu="mips" supported_cpu="yes" - cross_cc_mips=$host_cc + cross_cc_mips=$cc ;; sparc|sun4[cdmuv]) cpu="sparc" supported_cpu="yes" - cross_cc_sparc=$host_cc + cross_cc_sparc=$cc ;; *) # This will result in either an error or falling back to TCI later
The purpose of the code is to use the designated compiler for building the targets test cases. This is not actually host_cc which will still be cc even when we are cross compiling. As the tests for $cpu all use $cc we should do the same. Signed-off-by: Alex Bennée <alex.bennee@linaro.org> Reported-by: Richard Henderson <richard.henderson@linaro.org> --- configure | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) -- 2.17.1