Message ID | 20181019165735.22511-46-peter.maydell@linaro.org |
---|---|
State | Not Applicable |
Headers | show
Delivered-To: patch@linaro.org Received: by 2002:a2e:8595:0:0:0:0:0 with SMTP id b21-v6csp3564633lji; Fri, 19 Oct 2018 10:15:01 -0700 (PDT) X-Google-Smtp-Source: ACcGV60hIarFIgAcbKxJIdHr+C/Tjh8j6cihZZtRlkvX4bhK8y/mbroRF6QF5WvXxdPn9abA2T2j X-Received: by 2002:a0c:aecb:: with SMTP id n11mr23362022qvd.151.1539969300972; Fri, 19 Oct 2018 10:15:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539969300; cv=none; d=google.com; s=arc-20160816; b=B2YcG7+024afzAtD70ahMJiQQ9tDKBIgizJZ8i/9yqRPj05nY1BaJZ/PBSJjeMj1qI njFHy6LueVNkfg70baieBCPH4HLLWBtSMgpPTqBAVjF7pNr4CCpa+Dt+QgY1ZwQllao0 LRVzwD7BpclVbEYomHjV2Ol6NafPVsMGsS8OjD4tkVSCJlky1uBl9BdiYkns51X9UKo/ 5fN7F7ftP1JCdf7UD9zVsNMDiAOQVPYOXGYEkD3HIv9/N68MOB7KqnbS12blCqn1zw4T eVznyzYJw2el5ZEWM0V5FuJtjcKLREoB+8mjWHeQnLJK3BPY/8XwPuClkZJSKwtd1aKZ KvRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from; bh=vACUbywby2x84BdZHdl+mOlPpGJHVjfZzYNtet7NiiU=; b=cqDEXqBfh/UKTXwawiEmdTQbFmPxI65lQHKoi0XeJpxnrEqsHds8tms4Gru2JvbIBK 97wTI3fMe/4o01nUpSO1Czv9mbsbgiooYPCGjj4rEuAOpqE825OX4c21C7T1PDin51iE OZ/4ItvL4EZxDZa68mCCH+dYvemoTLWyRZqfZtreEu47nglszagO4nPUh1hpu2xqICJH n7i6LB7TKqbuLdA0htT4TuWuN7UWVO/7MOHSZa5ihi0SzH+gnzhYRiaXDwOH0J62SJ/C rhwaldkBWCe/ZDxyCinNgCRrDvFU3sYx046hj3P3VakKhKi5jIn/QjYICAGdbTP5mAFZ S0NA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: <qemu-devel-bounces+patch=linaro.org@nongnu.org> Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id j14-v6si1289836qtn.320.2018.10.19.10.15.00 for <patch@linaro.org> (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 19 Oct 2018 10:15:00 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:51783 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <qemu-devel-bounces+patch=linaro.org@nongnu.org>) id 1gDYMW-0002he-CQ for patch@linaro.org; Fri, 19 Oct 2018 13:15:00 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47779) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <pm215@archaic.org.uk>) id 1gDY6d-000265-FF for qemu-devel@nongnu.org; Fri, 19 Oct 2018 12:58:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <pm215@archaic.org.uk>) id 1gDY6c-0002w0-KO for qemu-devel@nongnu.org; Fri, 19 Oct 2018 12:58:35 -0400 Received: from orth.archaic.org.uk ([2001:8b0:1d0::2]:51980) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from <pm215@archaic.org.uk>) id 1gDY6c-00020Y-9m for qemu-devel@nongnu.org; Fri, 19 Oct 2018 12:58:34 -0400 Received: from pm215 by orth.archaic.org.uk with local (Exim 4.89) (envelope-from <pm215@archaic.org.uk>) id 1gDY6Q-0006pt-ON for qemu-devel@nongnu.org; Fri, 19 Oct 2018 17:58:22 +0100 From: Peter Maydell <peter.maydell@linaro.org> To: qemu-devel@nongnu.org Date: Fri, 19 Oct 2018 17:57:35 +0100 Message-Id: <20181019165735.22511-46-peter.maydell@linaro.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181019165735.22511-1-peter.maydell@linaro.org> References: <20181019165735.22511-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:8b0:1d0::2 Subject: [Qemu-devel] [PULL 45/45] target/arm: Only flush tlb if ASID changes X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: <qemu-devel.nongnu.org> List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe> List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/> List-Post: <mailto:qemu-devel@nongnu.org> List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help> List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=subscribe> Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+patch=linaro.org@nongnu.org> |
Series |
target-arm queue
|
expand
|
diff --git a/target/arm/helper.c b/target/arm/helper.c index 20114bf574d..bea4d5350d1 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -2758,12 +2758,10 @@ static void vmsa_tcr_el1_write(CPUARMState *env, const ARMCPRegInfo *ri, static void vmsa_ttbr_write(CPUARMState *env, const ARMCPRegInfo *ri, uint64_t value) { - /* 64 bit accesses to the TTBRs can change the ASID and so we - * must flush the TLB. - */ - if (cpreg_field_is_64bit(ri)) { + /* If the ASID changes (with a 64-bit write), we must flush the TLB. */ + if (cpreg_field_is_64bit(ri) && + extract64(raw_read(env, ri) ^ value, 48, 16) != 0) { ARMCPU *cpu = arm_env_get_cpu(env); - tlb_flush(CPU(cpu)); } raw_write(env, ri, value);