[Xen-devel,3/4] xen/arm: gic: Remove duplicated comment in do_sgi

Message ID 20181023181709.11883-4-julien.grall@arm.com
State Accepted
Commit 6d8ffac1f7a782dc2c7f8df3871a294729ae36bd
Headers show
Series
  • xen/arm: GIC fixes and improvement
Related show

Commit Message

Julien Grall Oct. 23, 2018, 6:17 p.m.
Signed-off-by: Julien Grall <julien.grall@arm.com>
---
 xen/arch/arm/gic.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Andrii Anisov Oct. 24, 2018, 10:26 a.m. | #1
I would say the comment was odd, not duplicated, at the place it is removed.

Reviewed-by: Andrii Anisov <andrii_anisov@epam.com>



-- 

*Andrii Anisov*
Stefano Stabellini Nov. 9, 2018, 11:03 p.m. | #2
On Tue, 23 Oct 2018, Julien Grall wrote:
> Signed-off-by: Julien Grall <julien.grall@arm.com>

Acked-by: Stefano Stabellini <sstabellini@kernel.org>

> ---
>  xen/arch/arm/gic.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c
> index 30c0fba0d7..0108e9603c 100644
> --- a/xen/arch/arm/gic.c
> +++ b/xen/arch/arm/gic.c
> @@ -363,7 +363,6 @@ void gic_disable_cpu(void)
>  
>  static void do_sgi(struct cpu_user_regs *regs, enum gic_sgi sgi)
>  {
> -    /* Lower the priority */
>      struct irq_desc *desc = irq_to_desc(sgi);
>  
>      perfc_incr(ipis);

Patch

diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c
index 30c0fba0d7..0108e9603c 100644
--- a/xen/arch/arm/gic.c
+++ b/xen/arch/arm/gic.c
@@ -363,7 +363,6 @@  void gic_disable_cpu(void)
 
 static void do_sgi(struct cpu_user_regs *regs, enum gic_sgi sgi)
 {
-    /* Lower the priority */
     struct irq_desc *desc = irq_to_desc(sgi);
 
     perfc_incr(ipis);