[edk2,edk2-platforms,v1,03/12] Silicon/Hisilicon/D06: Fix fwts issue in Dbg2

Message ID 20181029033249.45363-4-ming.huang@linaro.org
State Superseded
Headers show
Series
  • [edk2,edk2-platforms,v1,01/12] Silicon/Hisilicon/D06: Add watchdog to GTDT
Related show

Commit Message

Ming Huang Oct. 29, 2018, 3:32 a.m.
Modify name COM1 as the name COM1 is not a integrated name.

The fwts issue:
dbg2: DBG2 Device 'COM1' not found in ACPI object name space.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang <ming.huang@linaro.org>

---
 Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Hi1620Dbg2.aslc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.18.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Leif Lindholm Nov. 14, 2018, 12:50 a.m. | #1
On Mon, Oct 29, 2018 at 11:32:40AM +0800, Ming Huang wrote:
> Modify name COM1 as the name COM1 is not a integrated name.

> 

> The fwts issue:

> dbg2: DBG2 Device 'COM1' not found in ACPI object name space.

> 

> Contributed-under: TianoCore Contribution Agreement 1.1

> Signed-off-by: Ming Huang <ming.huang@linaro.org>


Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>


> ---

>  Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Hi1620Dbg2.aslc | 4 ++--

>  1 file changed, 2 insertions(+), 2 deletions(-)

> 

> diff --git a/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Hi1620Dbg2.aslc b/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Hi1620Dbg2.aslc

> index 342ec33629..05c284186b 100644

> --- a/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Hi1620Dbg2.aslc

> +++ b/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Hi1620Dbg2.aslc

> @@ -17,7 +17,7 @@

>  

>  #define NUMBER_DEBUG_DEVICE_INFO    1

>  #define NUMBER_OF_GENERIC_ADDRESS   1

> -#define NAMESPACE_STRING_SIZE       8

> +#define NAMESPACE_STRING_SIZE       12

>  #define UART_LENGTH                 0x1000

>  

>  #pragma pack(1)

> @@ -74,7 +74,7 @@ EFI_ACPI_DEBUG_PORT_2_TABLE Dbg2 = {

>        {

>          UART_LENGTH

>        },

> -      "COM1"

> +      "\\_SB.COM0"

>      }

>    }

>  };

> -- 

> 2.18.0

> 

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patch

diff --git a/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Hi1620Dbg2.aslc b/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Hi1620Dbg2.aslc
index 342ec33629..05c284186b 100644
--- a/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Hi1620Dbg2.aslc
+++ b/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Hi1620Dbg2.aslc
@@ -17,7 +17,7 @@ 
 
 #define NUMBER_DEBUG_DEVICE_INFO    1
 #define NUMBER_OF_GENERIC_ADDRESS   1
-#define NAMESPACE_STRING_SIZE       8
+#define NAMESPACE_STRING_SIZE       12
 #define UART_LENGTH                 0x1000
 
 #pragma pack(1)
@@ -74,7 +74,7 @@  EFI_ACPI_DEBUG_PORT_2_TABLE Dbg2 = {
       {
         UART_LENGTH
       },
-      "COM1"
+      "\\_SB.COM0"
     }
   }
 };