[edk2,edk2-platforms,v1,09/12] Silicon/Hisilicon/D06: Reserve ECAM resource in DSDT

Message ID 20181029033249.45363-10-ming.huang@linaro.org
State Superseded
Headers show
Series
  • [edk2,edk2-platforms,v1,01/12] Silicon/Hisilicon/D06: Add watchdog to GTDT
Related show

Commit Message

Ming Huang Oct. 29, 2018, 3:32 a.m.
Reserve ECAM resource in DSDT for clearing off bug output in
kernel dmesg:
acpi PNP0A08:00: [Firmware Bug]: ECAM area [mem
0xd0000000-0xd3ffffff] not reserved in ACPI namespace.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang <ming.huang@linaro.org>

---
 Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Dsdt/Hi1620Pci.asl | 8 ++++++++
 1 file changed, 8 insertions(+)

-- 
2.18.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Leif Lindholm Nov. 14, 2018, 12:23 a.m. | #1
On Mon, Oct 29, 2018 at 11:32:46AM +0800, Ming Huang wrote:
> Reserve ECAM resource in DSDT for clearing off bug output in

> kernel dmesg:

> acpi PNP0A08:00: [Firmware Bug]: ECAM area [mem

> 0xd0000000-0xd3ffffff] not reserved in ACPI namespace.

> 

> Contributed-under: TianoCore Contribution Agreement 1.1

> Signed-off-by: Ming Huang <ming.huang@linaro.org>


After Ard pointed me to linux/Documentation/PCI/acpi-info.txt:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>


> ---

>  Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Dsdt/Hi1620Pci.asl | 8 ++++++++

>  1 file changed, 8 insertions(+)

> 

> diff --git a/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Dsdt/Hi1620Pci.asl b/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Dsdt/Hi1620Pci.asl

> index 8e3547926a..87a2da8843 100644

> --- a/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Dsdt/Hi1620Pci.asl

> +++ b/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Dsdt/Hi1620Pci.asl

> @@ -1213,4 +1213,12 @@ Device (PCIB)

>      Return(0x03)

>    }

>  }

> +

> +Device (RESP)  //reserve for ecam resource

> +  {

> +    Name (_HID, "PNP0C02")

> +    Name (_CRS, ResourceTemplate (){

> +      Memory32Fixed (ReadWrite, 0xd0000000, 0x10000000)

> +    })

> +  }

>  }

> -- 

> 2.18.0

> 

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patch

diff --git a/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Dsdt/Hi1620Pci.asl b/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Dsdt/Hi1620Pci.asl
index 8e3547926a..87a2da8843 100644
--- a/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Dsdt/Hi1620Pci.asl
+++ b/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Dsdt/Hi1620Pci.asl
@@ -1213,4 +1213,12 @@  Device (PCIB)
     Return(0x03)
   }
 }
+
+Device (RESP)  //reserve for ecam resource
+  {
+    Name (_HID, "PNP0C02")
+    Name (_CRS, ResourceTemplate (){
+      Memory32Fixed (ReadWrite, 0xd0000000, 0x10000000)
+    })
+  }
 }