[v3,6/7] arm64: dts: xilinx: ultra96: Standardize LED labels and triggers

Message ID 20181029094245.7886-7-manivannan.sadhasivam@linaro.org
State New
Headers show
Series
  • [v3,1/7] arm64: dts: rockchip: ficus: Add on-board LED support
Related show

Commit Message

Manivannan Sadhasivam Oct. 29, 2018, 9:42 a.m.
For all 96Boards, the following standard is used for onboard LEDs.

green:user1  default-trigger: heartbeat
green:user2  default-trigger: mmc0/disk-activity(onboard-storage)
green:user3  default-trigger: mmc1 (SD-card)
green:user4  default-trigger: none, panic-indicator
yellow:wlan  default-trigger: phy0tx
blue:bt      default-trigger: hci0-power

So lets adopt the same for Ultra96, which is one of the 96Boards
CE and AI platform. Since the WLAN and BT LEDs are hardwired onboard,
consolidate only User LEDs.

Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

---
 arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

-- 
2.17.1

Comments

Manivannan Sadhasivam Dec. 21, 2018, 2:37 a.m. | #1
On Mon, Oct 29, 2018 at 03:12:44PM +0530, Manivannan Sadhasivam wrote:
> For all 96Boards, the following standard is used for onboard LEDs.

> 

> green:user1  default-trigger: heartbeat

> green:user2  default-trigger: mmc0/disk-activity(onboard-storage)

> green:user3  default-trigger: mmc1 (SD-card)

> green:user4  default-trigger: none, panic-indicator

> yellow:wlan  default-trigger: phy0tx

> blue:bt      default-trigger: hci0-power

> 

> So lets adopt the same for Ultra96, which is one of the 96Boards

> CE and AI platform. Since the WLAN and BT LEDs are hardwired onboard,

> consolidate only User LEDs.

> 


Hello,

Any update on this patch?

Regards,
Mani

> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

> ---

>  arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts | 15 ++++++++-------

>  1 file changed, 8 insertions(+), 7 deletions(-)

> 

> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts

> index eb5e8bddb610..c08a8753215b 100644

> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts

> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts

> @@ -57,29 +57,30 @@

>  	leds {

>  		compatible = "gpio-leds";

>  		ds2 {

> -			label = "ds2";

> +			label = "green:user1";

>  			gpios = <&gpio 20 GPIO_ACTIVE_HIGH>;

>  			linux,default-trigger = "heartbeat";

>  		};

>  

>  		ds3 {

> -			label = "ds3";

> +			label = "green:user2";

>  			gpios = <&gpio 19 GPIO_ACTIVE_HIGH>;

> -			linux,default-trigger = "phy0tx"; /* WLAN tx */

> +			linux,default-trigger = "mmc0";

>  			default-state = "off";

>  		};

>  

>  		ds4 {

> -			label = "ds4";

> +			label = "green:user3";

>  			gpios = <&gpio 18 GPIO_ACTIVE_HIGH>;

> -			linux,default-trigger = "phy0rx"; /* WLAN rx */

> +			linux,default-trigger = "mmc1";

>  			default-state = "off";

>  		};

>  

>  		ds5 {

> -			label = "ds5";

> +			label = "green:user4";

>  			gpios = <&gpio 17 GPIO_ACTIVE_HIGH>;

> -			linux,default-trigger = "bluetooth-power";

> +			linux,default-trigger = "none";

> +			panic-indicator;

>  		};

>  

>  		vbus_det { /* U5 USB5744 VBUS detection via MIO25 */

> -- 

> 2.17.1

>
Michal Simek Dec. 21, 2018, 6:50 a.m. | #2
On 21. 12. 18 3:37, Manivannan Sadhasivam wrote:
> On Mon, Oct 29, 2018 at 03:12:44PM +0530, Manivannan Sadhasivam wrote:

>> For all 96Boards, the following standard is used for onboard LEDs.

>>

>> green:user1  default-trigger: heartbeat

>> green:user2  default-trigger: mmc0/disk-activity(onboard-storage)

>> green:user3  default-trigger: mmc1 (SD-card)

>> green:user4  default-trigger: none, panic-indicator

>> yellow:wlan  default-trigger: phy0tx

>> blue:bt      default-trigger: hci0-power

>>

>> So lets adopt the same for Ultra96, which is one of the 96Boards

>> CE and AI platform. Since the WLAN and BT LEDs are hardwired onboard,

>> consolidate only User LEDs.

>>

> 

> Hello,

> 

> Any update on this patch?


I am still waiting for reaction from Rob.
We are keep trying to keep backward compatibility and this patch is
breaking it that's why I want to know DT guys reaction on this change.

Thanks,
Michal
Michal Simek Jan. 29, 2019, 1:17 p.m. | #3
On 24. 01. 19 17:49, Rob Herring wrote:
> On Fri, Dec 21, 2018 at 12:51 AM Michal Simek <michal.simek@xilinx.com> wrote:

>>

>> On 21. 12. 18 3:37, Manivannan Sadhasivam wrote:

>>> On Mon, Oct 29, 2018 at 03:12:44PM +0530, Manivannan Sadhasivam wrote:

>>>> For all 96Boards, the following standard is used for onboard LEDs.

>>>>

>>>> green:user1  default-trigger: heartbeat

>>>> green:user2  default-trigger: mmc0/disk-activity(onboard-storage)

>>>> green:user3  default-trigger: mmc1 (SD-card)

>>>> green:user4  default-trigger: none, panic-indicator

>>>> yellow:wlan  default-trigger: phy0tx

>>>> blue:bt      default-trigger: hci0-power

>>>>

>>>> So lets adopt the same for Ultra96, which is one of the 96Boards

>>>> CE and AI platform. Since the WLAN and BT LEDs are hardwired onboard,

>>>> consolidate only User LEDs.

>>>>

>>>

>>> Hello,

>>>

>>> Any update on this patch?

>>

>> I am still waiting for reaction from Rob.

>> We are keep trying to keep backward compatibility and this patch is

>> breaking it that's why I want to know DT guys reaction on this change.

> 

> dts changes and backwards compatibility are ultimately up to the

> platform maintainers. Your users can yell at you if they care. I only

> ask that changes that break compatibility are documented as doing so.

> 

> Personally, I'm in favor of this change. I'd rather seem uniformity

> across boards and this is just a dev board and LED functions won't

> affect booting.


Ok.

Then please fix the patch and do it in a way

label = "green:user1"; /* ds2 */

ds2 reflects name on schematics.

in ds4 case default trigger is changes to mmc1. It suggests sd/emmc but
on ultra96 it is sd slot and wifi on second slot.

ds5 - linux,default-trigger = "none"; looks weird. None trigger should
be simply ensured by removing that line.

Thanks,
Michal

Patch

diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
index eb5e8bddb610..c08a8753215b 100644
--- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
+++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
@@ -57,29 +57,30 @@ 
 	leds {
 		compatible = "gpio-leds";
 		ds2 {
-			label = "ds2";
+			label = "green:user1";
 			gpios = <&gpio 20 GPIO_ACTIVE_HIGH>;
 			linux,default-trigger = "heartbeat";
 		};
 
 		ds3 {
-			label = "ds3";
+			label = "green:user2";
 			gpios = <&gpio 19 GPIO_ACTIVE_HIGH>;
-			linux,default-trigger = "phy0tx"; /* WLAN tx */
+			linux,default-trigger = "mmc0";
 			default-state = "off";
 		};
 
 		ds4 {
-			label = "ds4";
+			label = "green:user3";
 			gpios = <&gpio 18 GPIO_ACTIVE_HIGH>;
-			linux,default-trigger = "phy0rx"; /* WLAN rx */
+			linux,default-trigger = "mmc1";
 			default-state = "off";
 		};
 
 		ds5 {
-			label = "ds5";
+			label = "green:user4";
 			gpios = <&gpio 17 GPIO_ACTIVE_HIGH>;
-			linux,default-trigger = "bluetooth-power";
+			linux,default-trigger = "none";
+			panic-indicator;
 		};
 
 		vbus_det { /* U5 USB5744 VBUS detection via MIO25 */