| Message ID | 20181029200920.28901-1-semen.protsenko@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2] kernel/SRCU: Fix ctags | expand |
Hi Greg, On Mon, Oct 29, 2018 at 10:09 PM, Sam Protsenko <semen.protsenko@linaro.org> wrote: > ctags indexing ("make tags" command) throws this warning: > > ctags: Warning: include/linux/notifier.h:125: > null expansion of name pattern "\1" > > This is the result of DEFINE_PER_CPU() macro exapansion. Fix that by > getting rid of line break. > > Similar fix was already done in commit 25528213fe9f ("tags: Fix > DEFINE_PER_CPU expansions"), but this one probably wasn't noticed. > > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> > --- This one was sent some time ago, but there wasn't any response. Can you please review it and merge if applicable? Thanks! > include/linux/notifier.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/include/linux/notifier.h b/include/linux/notifier.h > index f35c7bf76143..0096a05395e3 100644 > --- a/include/linux/notifier.h > +++ b/include/linux/notifier.h > @@ -122,8 +122,7 @@ extern void srcu_init_notifier_head(struct srcu_notifier_head *nh); > > #ifdef CONFIG_TREE_SRCU > #define _SRCU_NOTIFIER_HEAD(name, mod) \ > - static DEFINE_PER_CPU(struct srcu_data, \ > - name##_head_srcu_data); \ > + static DEFINE_PER_CPU(struct srcu_data, name##_head_srcu_data); \ > mod struct srcu_notifier_head name = \ > SRCU_NOTIFIER_INIT(name, name##_head_srcu_data) > > -- > 2.19.1 >
On Mon, Oct 29, 2018 at 10:09 PM Sam Protsenko <semen.protsenko@linaro.org> wrote: > > ctags indexing ("make tags" command) throws this warning: > > ctags: Warning: include/linux/notifier.h:125: > null expansion of name pattern "\1" > > This is the result of DEFINE_PER_CPU() macro exapansion. Fix that by > getting rid of line break. > > Similar fix was already done in commit 25528213fe9f ("tags: Fix > DEFINE_PER_CPU expansions"), but this one probably wasn't noticed. Why not to add Fixes tag here as well? > > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> > --- > include/linux/notifier.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/include/linux/notifier.h b/include/linux/notifier.h > index f35c7bf76143..0096a05395e3 100644 > --- a/include/linux/notifier.h > +++ b/include/linux/notifier.h > @@ -122,8 +122,7 @@ extern void srcu_init_notifier_head(struct srcu_notifier_head *nh); > > #ifdef CONFIG_TREE_SRCU > #define _SRCU_NOTIFIER_HEAD(name, mod) \ > - static DEFINE_PER_CPU(struct srcu_data, \ > - name##_head_srcu_data); \ > + static DEFINE_PER_CPU(struct srcu_data, name##_head_srcu_data); \ > mod struct srcu_notifier_head name = \ > SRCU_NOTIFIER_INIT(name, name##_head_srcu_data) > > -- > 2.19.1 > -- With Best Regards, Andy Shevchenko
On Mon, Oct 29, 2018 at 10:11:36PM +0200, Sam Protsenko wrote: > Hi Greg, > > On Mon, Oct 29, 2018 at 10:09 PM, Sam Protsenko > <semen.protsenko@linaro.org> wrote: > > ctags indexing ("make tags" command) throws this warning: > > > > ctags: Warning: include/linux/notifier.h:125: > > null expansion of name pattern "\1" > > > > This is the result of DEFINE_PER_CPU() macro exapansion. Fix that by > > getting rid of line break. > > > > Similar fix was already done in commit 25528213fe9f ("tags: Fix > > DEFINE_PER_CPU expansions"), but this one probably wasn't noticed. > > > > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> > > --- > > This one was sent some time ago, but there wasn't any response. Can > you please review it and merge if applicable? As before, why ask me? thanks, greg k-h
On Mon, Oct 29, 2018 at 10:11 PM, Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > On Mon, Oct 29, 2018 at 10:09 PM Sam Protsenko > <semen.protsenko@linaro.org> wrote: >> >> ctags indexing ("make tags" command) throws this warning: >> >> ctags: Warning: include/linux/notifier.h:125: >> null expansion of name pattern "\1" >> >> This is the result of DEFINE_PER_CPU() macro exapansion. Fix that by >> getting rid of line break. >> >> Similar fix was already done in commit 25528213fe9f ("tags: Fix >> DEFINE_PER_CPU expansions"), but this one probably wasn't noticed. > > Why not to add Fixes tag here as well? > Will do, thanks, Andy! >> >> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> >> --- >> include/linux/notifier.h | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/include/linux/notifier.h b/include/linux/notifier.h >> index f35c7bf76143..0096a05395e3 100644 >> --- a/include/linux/notifier.h >> +++ b/include/linux/notifier.h >> @@ -122,8 +122,7 @@ extern void srcu_init_notifier_head(struct srcu_notifier_head *nh); >> >> #ifdef CONFIG_TREE_SRCU >> #define _SRCU_NOTIFIER_HEAD(name, mod) \ >> - static DEFINE_PER_CPU(struct srcu_data, \ >> - name##_head_srcu_data); \ >> + static DEFINE_PER_CPU(struct srcu_data, name##_head_srcu_data); \ >> mod struct srcu_notifier_head name = \ >> SRCU_NOTIFIER_INIT(name, name##_head_srcu_data) >> >> -- >> 2.19.1 >> > > > -- > With Best Regards, > Andy Shevchenko
diff --git a/include/linux/notifier.h b/include/linux/notifier.h index f35c7bf76143..0096a05395e3 100644 --- a/include/linux/notifier.h +++ b/include/linux/notifier.h @@ -122,8 +122,7 @@ extern void srcu_init_notifier_head(struct srcu_notifier_head *nh); #ifdef CONFIG_TREE_SRCU #define _SRCU_NOTIFIER_HEAD(name, mod) \ - static DEFINE_PER_CPU(struct srcu_data, \ - name##_head_srcu_data); \ + static DEFINE_PER_CPU(struct srcu_data, name##_head_srcu_data); \ mod struct srcu_notifier_head name = \ SRCU_NOTIFIER_INIT(name, name##_head_srcu_data)
ctags indexing ("make tags" command) throws this warning: ctags: Warning: include/linux/notifier.h:125: null expansion of name pattern "\1" This is the result of DEFINE_PER_CPU() macro exapansion. Fix that by getting rid of line break. Similar fix was already done in commit 25528213fe9f ("tags: Fix DEFINE_PER_CPU expansions"), but this one probably wasn't noticed. Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> --- include/linux/notifier.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.19.1