[Linaro-uefi] edk2-platforms.config: Add support for sgi575

Message ID 20181031111311.26601-1-nariman.poushin@linaro.org
State Superseded
Headers show
Series
  • [Linaro-uefi] edk2-platforms.config: Add support for sgi575
Related show

Commit Message

Nariman Poushin Oct. 31, 2018, 11:13 a.m.
Add support for System Guidance for Infrastructure (SGI) Fixed
Virtual Platform (FVP) SGI-575, a server reference model from
Arm.

Signed-off-by: Nariman Poushin <nariman.poushin@linaro.org>
---
 edk2-platforms.config | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Leif Lindholm Oct. 31, 2018, 4:40 p.m. | #1
So, here's this week's weakest patch feedback:

The LONGNAME is long enough to screw up the formatting of the summary
printout.
Example from building 'all':
---
                                                    ...
             EDK2 Hello World Example (AARCH64) RELEASE pass
ARM System Guidance for Infrastructure SGI575 (AARCH64) RELEASE pass
---

Could you either shorten the name or change the summary formatting?
(I know which I would pick :)

/
    Leif

On Wed, Oct 31, 2018 at 11:13:11AM +0000, Nariman Poushin wrote:
> Add support for System Guidance for Infrastructure (SGI) Fixed
> Virtual Platform (FVP) SGI-575, a server reference model from
> Arm.
> 
> Signed-off-by: Nariman Poushin <nariman.poushin@linaro.org>
> ---
>  edk2-platforms.config | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/edk2-platforms.config b/edk2-platforms.config
> index 3b3ab89..da5754e 100644
> --- a/edk2-platforms.config
> +++ b/edk2-platforms.config
> @@ -226,3 +226,8 @@ LONGNAME=EDK2 Hello World Example
>  DSC=MdeModulePkg/MdeModulePkg.dsc
>  INF=MdeModulePkg/Application/HelloWorld/HelloWorld.inf
>  ARCH=AARCH64
> +
> +[sgi575]
> +LONGNAME=ARM System Guidance for Infrastructure SGI575
> +DSC=Platform/ARM/SgiPkg/SgiPlatform.dsc
> +ARCH=AARCH64
> -- 
> 2.7.4
>

Patch

diff --git a/edk2-platforms.config b/edk2-platforms.config
index 3b3ab89..da5754e 100644
--- a/edk2-platforms.config
+++ b/edk2-platforms.config
@@ -226,3 +226,8 @@  LONGNAME=EDK2 Hello World Example
 DSC=MdeModulePkg/MdeModulePkg.dsc
 INF=MdeModulePkg/Application/HelloWorld/HelloWorld.inf
 ARCH=AARCH64
+
+[sgi575]
+LONGNAME=ARM System Guidance for Infrastructure SGI575
+DSC=Platform/ARM/SgiPkg/SgiPlatform.dsc
+ARCH=AARCH64