From patchwork Wed Oct 31 23:06:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Levin X-Patchwork-Id: 149896 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp99228ljp; Wed, 31 Oct 2018 16:08:20 -0700 (PDT) X-Google-Smtp-Source: AJdET5edYkt7a1TPz0+n1T3JGzmAeYA6fc7hV3yRKt+GtM74jKW84J3UT4uemhHWaYbJIlQUq6Ya X-Received: by 2002:a63:5b4a:: with SMTP id l10-v6mr2221148pgm.50.1541027299878; Wed, 31 Oct 2018 16:08:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1541027299; cv=none; d=google.com; s=arc-20160816; b=Fk6x1R2FPXy3zNGDVQTbWZEnVaq8a5YmFXh3i1mHdU95A3WG8pNmDIIN1T+x5UPXzI j6Wz5jc00yR7KSVoRvYWCAX1SMbTztr8VhUBF8FhKvra1aPHfRKT2YAz8DWSI1eP7Miy 7XWLCK/sJ7HPDl8DgAvsY6lTFJQnRW1QyLQDtnPeercJhSdx9QtY/ZMThfJEEjrmQoLu uW8vi9K13p+CTbwvekM1+3l1Ckyez3zmOPgh6LzweW+k+TMGcSbdMgpO82zGZusa5Pxm NiL4PtCSq0Foh2LgoQ9jOQ05JaTr7J/rKsq3YHZ3QIV++rkScmSa1FRq722oQiy9QvB+ Vlgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=K8lNpRCDVqYDWcFCTSpUtgiugAL4mR5ptZLvFac7Olk=; b=uf/1AVjl/36RIfojMmJK4i5wEDHaXePoSvgi8+FSi/1pjLmtGUuIWlj2UmcdKoA3Zf /1GEsWX3jLyLgVH1I7XWXYNLNK3s7/ejPh3jEqdXuhdO6NY1rSLlEyF7/nUi0JVBrM2M PQO4Kk0rGkExzkAlQkwTjTHNTNk+KlisOiNvv/9ZAQVSuCFnw/pWH2/k9CG5chxONbcr mXRc9Qq8kUrviBN4HmB36Yxo5VO+Srqs4zHrRMa8RLuGC5gPKKu1M2T/I8b2u1JKmPw0 LRPYKhXVXh7ud8qUxZh4EUgqMuWCboLUPUYCS8GMMHJNnwNwaPF3nnmk9+RJ6yq7Zcrf APdg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=rOBhmiyy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l16-v6si28670752pfb.69.2018.10.31.16.08.19; Wed, 31 Oct 2018 16:08:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=rOBhmiyy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729716AbeKAII2 (ORCPT + 32 others); Thu, 1 Nov 2018 04:08:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:57366 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728334AbeKAII1 (ORCPT ); Thu, 1 Nov 2018 04:08:27 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 72C13208E3; Wed, 31 Oct 2018 23:08:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1541027296; bh=/+PQqP9t4ZV5lAlBalgxA4SPTsElbHnLnIeYlm3kqNE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rOBhmiyyDfZvlIsTRfFmL1zc7uTCcR1vnYMfepZ49SdaHYWYWov64KHx/RW+4QKP8 CsF5J+rkUD2W3acjrC4sR/T5ypFb8l3XLyj3e0f02S+1HLkGHxU07H+MIg1jay8iGS gisu3r3Auf8yvw8EsRJf5fFGEKHz1HQw3INyDHUc= From: Sasha Levin To: stable@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Masahiro Yamada , Miquel Raynal , Sasha Levin Subject: [PATCH AUTOSEL 4.18 023/126] mtd: rawnand: denali: set SPARE_AREA_SKIP_BYTES register to 8 if unset Date: Wed, 31 Oct 2018 19:06:11 -0400 Message-Id: <20181031230754.29029-23-sashal@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181031230754.29029-1-sashal@kernel.org> References: <20181031230754.29029-1-sashal@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Masahiro Yamada [ Upstream commit 0d55c668b218a1db68b5044bce4de74e1bd0f0c8 ] NAND devices need additional data area (OOB) for error correction, but it is also used for Bad Block Marker (BBM). In many cases, the first byte in OOB is used for BBM, but the location actually depends on chip vendors. The NAND controller should preserve the precious BBM to keep track of bad blocks. In Denali IP, the SPARE_AREA_SKIP_BYTES register is used to specify the number of bytes to skip from the start of OOB. The ECC engine will automatically skip the specified number of bytes when it gets access to OOB area. The same value for SPARE_AREA_SKIP_BYTES should be used between firmware and the operating system if you intend to use the NAND device across the control hand-off. In fact, the current denali.c code expects firmware to have already set the SPARE_AREA_SKIP_BYTES register, then reads the value out. If no firmware (or bootloader) has initialized the controller, the register value is zero, which is the default after power-on-reset. In other words, the Linux driver cannot initialize the controller by itself. Some possible solutions are: [1] Add a DT property to specify the skipped bytes in OOB [2] Associate the preferred value with compatible [3] Hard-code the default value in the driver My first attempt was [1], but in the review process, [3] was suggested as a counter-implementation. (https://lore.kernel.org/patchwork/patch/983055/) The default value 8 was chosen to match to the boot ROM of the UniPhier platform. The preferred value may vary by platform. If so, please trade up to a different solution. Signed-off-by: Masahiro Yamada Reviewed-by: Boris Brezillon Signed-off-by: Miquel Raynal Signed-off-by: Sasha Levin --- drivers/mtd/nand/raw/denali.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) -- 2.17.1 diff --git a/drivers/mtd/nand/raw/denali.c b/drivers/mtd/nand/raw/denali.c index c502075e5721..ff955f085351 100644 --- a/drivers/mtd/nand/raw/denali.c +++ b/drivers/mtd/nand/raw/denali.c @@ -28,6 +28,7 @@ MODULE_LICENSE("GPL"); #define DENALI_NAND_NAME "denali-nand" +#define DENALI_DEFAULT_OOB_SKIP_BYTES 8 /* for Indexed Addressing */ #define DENALI_INDEXED_CTRL 0x00 @@ -1106,12 +1107,17 @@ static void denali_hw_init(struct denali_nand_info *denali) denali->revision = swab16(ioread32(denali->reg + REVISION)); /* - * tell driver how many bit controller will skip before - * writing ECC code in OOB, this register may be already - * set by firmware. So we read this value out. - * if this value is 0, just let it be. + * Set how many bytes should be skipped before writing data in OOB. + * If a non-zero value has already been set (by firmware or something), + * just use it. Otherwise, set the driver default. */ denali->oob_skip_bytes = ioread32(denali->reg + SPARE_AREA_SKIP_BYTES); + if (!denali->oob_skip_bytes) { + denali->oob_skip_bytes = DENALI_DEFAULT_OOB_SKIP_BYTES; + iowrite32(denali->oob_skip_bytes, + denali->reg + SPARE_AREA_SKIP_BYTES); + } + denali_detect_max_banks(denali); iowrite32(0x0F, denali->reg + RB_PIN_ENABLED); iowrite32(CHIP_EN_DONT_CARE__FLAG, denali->reg + CHIP_ENABLE_DONT_CARE);