[edk2,3/6] IntelFrameworkPkg: fix build for AARCH64/ARM

Message ID 20181101153642.11315-4-leif.lindholm@linaro.org
State Accepted
Commit 47d90076edbb035e42f4f02c26ef1a0e3b4e28a5
Headers show
Series
  • fix top-level package builds for AARCH64/ARM
Related show

Commit Message

Leif Lindholm Nov. 1, 2018, 3:36 p.m.
Contrary to what the name suggests, some modules in this package are used
on other architecture. ARM is already listed in SUPPORTED_ARCHITECTURES
in the .dsc, but AARCH64 was never added - so do that.

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>

---
 IntelFrameworkPkg/IntelFrameworkPkg.dsc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.11.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Kinney, Michael D Nov. 1, 2018, 5:23 p.m. | #1
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>


Mike


> -----Original Message-----

> From: Leif Lindholm [mailto:leif.lindholm@linaro.org]

> Sent: Thursday, November 1, 2018 8:37 AM

> To: edk2-devel@lists.01.org

> Cc: Kinney, Michael D <michael.d.kinney@intel.com>;

> Gao, Liming <liming.gao@intel.com>

> Subject: [PATCH 3/6] IntelFrameworkPkg: fix build for

> AARCH64/ARM

> 

> Contrary to what the name suggests, some modules in

> this package are used

> on other architecture. ARM is already listed in

> SUPPORTED_ARCHITECTURES

> in the .dsc, but AARCH64 was never added - so do that.

> 

> Cc: Michael D Kinney <michael.d.kinney@intel.com>

> Cc: Liming Gao <liming.gao@intel.com>

> Contributed-under: TianoCore Contribution Agreement 1.1

> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>

> ---

>  IntelFrameworkPkg/IntelFrameworkPkg.dsc | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/IntelFrameworkPkg/IntelFrameworkPkg.dsc

> b/IntelFrameworkPkg/IntelFrameworkPkg.dsc

> index bd5df8c5d9..f957af78fb 100644

> --- a/IntelFrameworkPkg/IntelFrameworkPkg.dsc

> +++ b/IntelFrameworkPkg/IntelFrameworkPkg.dsc

> @@ -26,7 +26,7 @@ [Defines]

>    PLATFORM_VERSION               = 0.96

>    DSC_SPECIFICATION              = 0x00010005

>    OUTPUT_DIRECTORY               =

> Build/IntelFramework

> -  SUPPORTED_ARCHITECTURES        = IA32|X64|EBC|ARM

> +  SUPPORTED_ARCHITECTURES        =

> IA32|X64|EBC|ARM|AARCH64

>    BUILD_TARGETS                  = DEBUG|RELEASE|NOOPT

>    SKUID_IDENTIFIER               = DEFAULT

> 

> --

> 2.11.0


_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patch

diff --git a/IntelFrameworkPkg/IntelFrameworkPkg.dsc b/IntelFrameworkPkg/IntelFrameworkPkg.dsc
index bd5df8c5d9..f957af78fb 100644
--- a/IntelFrameworkPkg/IntelFrameworkPkg.dsc
+++ b/IntelFrameworkPkg/IntelFrameworkPkg.dsc
@@ -26,7 +26,7 @@  [Defines]
   PLATFORM_VERSION               = 0.96
   DSC_SPECIFICATION              = 0x00010005
   OUTPUT_DIRECTORY               = Build/IntelFramework
-  SUPPORTED_ARCHITECTURES        = IA32|X64|EBC|ARM
+  SUPPORTED_ARCHITECTURES        = IA32|X64|EBC|ARM|AARCH64
   BUILD_TARGETS                  = DEBUG|RELEASE|NOOPT
   SKUID_IDENTIFIER               = DEFAULT