diff mbox

[v2] ARM: omap4: i2c reset regs postidle

Message ID 1305537524-24753-1-git-send-email-j.weitzel@phytec.de
State New
Headers show

Commit Message

Jan Weitzel May 16, 2011, 9:18 a.m. UTC 
Without OMAP_I2C_FLAG_RESET_REGS_POSTIDLE I got i2c controller
timeouts on each accsess after an NACK message.
Taking this flag fix it.

This patch is on top of the i2c feature implementation flags
patches

Signed-off-by: Jan Weitzel <j.weitzel@phytec.de>
Tested-by: Andy Green <andy.green@linaro.org>
Acked-by: Andy Green <andy.green@linaro.org>
---
v2: add Tested-by / Acked-by

 arch/arm/mach-omap2/omap_hwmod_44xx_data.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

Comments

Cousson, Benoit May 16, 2011, 5:16 p.m. UTC | #1 
Hi Jan,

On 5/16/2011 11:18 AM, Jan Weitzel wrote:
> Without OMAP_I2C_FLAG_RESET_REGS_POSTIDLE I got i2c controller
> timeouts on each accsess after an NACK message.
> Taking this flag fix it.
>
> This patch is on top of the i2c feature implementation flags
> patches

Could you please give us more information and potentially provide a link 
to the patches you are referring to?
It will help us assessing the need for such flag in the hwmod data.

Please note that the changelog will stay forever in the GIT tree, so you 
should avoid using "the patch" or making reference to something that is 
not an existing commit id or email archive.
You should fix as well the typo.

Thanks,
Benoit
diff mbox

Patch

diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
index 5f4a1b2..3d3b4f4 100644
--- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
@@ -2130,7 +2130,8 @@  static struct omap_hwmod_class omap44xx_i2c_hwmod_class = {
 };
 
 static struct omap_i2c_dev_attr i2c_dev_attr = {
-	.flags  = OMAP_I2C_FLAG_BUS_SHIFT_NONE,
+	.flags  = OMAP_I2C_FLAG_BUS_SHIFT_NONE |
+		  OMAP_I2C_FLAG_RESET_REGS_POSTIDLE,
 };
 
 /* i2c1 */