From patchwork Mon Nov 5 11:59:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 150183 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp2507779ljp; Mon, 5 Nov 2018 03:59:38 -0800 (PST) X-Google-Smtp-Source: AJdET5c8xkHEKEd4ySgzEXzBeO0Iis9Jbw4+wehrB8HkT4SnzV9wsoTfUbTsgbT49x+oAx18PFHw X-Received: by 2002:a1c:650b:: with SMTP id z11-v6mr6056724wmb.28.1541419178856; Mon, 05 Nov 2018 03:59:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541419178; cv=none; d=google.com; s=arc-20160816; b=c1ET7XsM8ICtzvi+QsxsM5/Z8xkq1BYnJ7wZWei5UCXwXBvfR7CQZTIIG1/PkaHlcm DW9SLDYDRMfMlNTrd7bPvRQh0nJ4HF8adGg1WUBxKeEck/0VgjHi3Zhbbert8p3Q7NaL rIvToJ0Y0YJzfWazpfR7EUwUFlkWC9sENcK67avgmivvUrewcttzEq5T6X/yJBbvirSy jfAYHhz0HwdsTHUNiRmkLkG+UyDFxNTTdZbSt9wBDhLf2qKRhaA8y7poHHD/OC9fFXwd aRwSivF94zK5gPBDU9baqX0c/Oby0i6LM4biwOuOAd9kzN4BbhpSNu4uxt/tBe1Rasjg tVSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to; bh=LTirkPfLHwah+pAHIGLNP/6MTJIApBsf1rQvjwsDz9w=; b=oMtS9k7p1yG+Urcz+Wo9j0yxKMH1hK51rJ+fMTWv64gwnn2jnNpuobBpxSwxMdvfhz 9Riudf/QKC1q41oBZkGZjoTiwLr41zKAnHDotpMxb3mZIUaXYmegdE2M8xfst/Jm+69a Yi8pKoh2y5PtByGTKnTmJ5QI3NJ/wstirnQC8XWvu4wsA5p/zF7fpMpPZdGcAIKRMhpC nCZI8UM0V7kEWFIBgJ7AbcjZLNiRpX12lLYLKCiAJgxLhMkVIvNa5MhWAEqQSXiJS7/e rBAX+EqsC5lIxHWTAcgIUprI6flNyUy5ae1BVkQzrUujiFT8q9Gyyb+eVLplA6r5sy4J S70Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=SD54oMiR; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id r185-v6si25316971wmf.166.2018.11.05.03.59.38; Mon, 05 Nov 2018 03:59:38 -0800 (PST) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=SD54oMiR; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id F062D2679E0; Mon, 5 Nov 2018 12:59:37 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id E68352679BE; Mon, 5 Nov 2018 12:59:35 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id DD733267A72 for ; Mon, 5 Nov 2018 12:59:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=L4VqUU3f2Lx/K6LF8/npowx+fGyvcclXaASimSnj8ng=; b=SD54oMiR+xzZ KHMXjluUhEp+u1Fog1ElwB2piUzXiim0IOwy4i3F/dhwWPFUrGR9b/JyVJKsosFiRXkB1Kr+2hJZh AyaNor95IoYGKT56oag90uDLW9F2oLBJgNdd+FB+0eV/ExKZBUhMwIVMMauHyOEQILCVo1ou7HjEs OOMrM=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1gJdXW-0008JM-Id; Mon, 05 Nov 2018 11:59:30 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id 494DC1124D98; Mon, 5 Nov 2018 11:59:30 +0000 (GMT) From: Mark Brown To: Colin Ian King In-Reply-To: <20181031193143.6994-1-colin.king@canonical.com> Message-Id: <20181105115930.494DC1124D98@debutante.sirena.org.uk> Date: Mon, 5 Nov 2018 11:59:30 +0000 (GMT) Cc: alsa-devel@alsa-project.org, Olivier Moysan , Alexandre Torgue , kernel-janitors@vger.kernel.org, Arnaud Pouliquen , Takashi Iwai , Liam Girdwood , Mark Brown , Maxime Coquelin , linux-kernel@vger.kernel.org Subject: [alsa-devel] Applied "ASoC: stm32: sai: fix less than zero comparison on unsigned int" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: stm32: sai: fix less than zero comparison on unsigned int has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 6b27e27729270a2478fdebea2db9c4f57bb4e8e6 Mon Sep 17 00:00:00 2001 From: Colin Ian King Date: Wed, 31 Oct 2018 19:31:43 +0000 Subject: [PATCH] ASoC: stm32: sai: fix less than zero comparison on unsigned int Currently, the comparison of div < 0 is always false because div is an unsigned int. Fix this by making div an int. Detected by CoverityScan, CID#1475309 ("Unsigned compared against 0") Fixes: 8307b2afd386 "(ASoC: stm32: sai: set sai as mclk clock provider") Signed-off-by: Colin Ian King Signed-off-by: Mark Brown --- sound/soc/stm/stm32_sai_sub.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.19.0.rc2 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/stm/stm32_sai_sub.c b/sound/soc/stm/stm32_sai_sub.c index ea05cc91aa05..506423d5861a 100644 --- a/sound/soc/stm/stm32_sai_sub.c +++ b/sound/soc/stm/stm32_sai_sub.c @@ -336,8 +336,7 @@ static int stm32_sai_mclk_set_rate(struct clk_hw *hw, unsigned long rate, { struct stm32_sai_mclk_data *mclk = to_mclk_data(hw); struct stm32_sai_sub_data *sai = mclk->sai_data; - unsigned int div; - int ret; + int div, ret; div = stm32_sai_get_clk_div(sai, parent_rate, rate); if (div < 0)