| Message ID | 1305580757-13175-4-git-send-email-john.stultz@linaro.org |
|---|---|
| State | Rejected |
| Headers | show |
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index d867081..3a713c2 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2868,6 +2868,10 @@ sub process { WARN("usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc\n" . $herecurr); } +# check for current->comm usage + if ($line =~ /\b(?:current|task|tsk|t)\s*->\s*comm\b/) { + WARN("comm access needs to be protected. Use get_task_comm, or printk's \%ptc formatting.\n" . $herecurr); + } # check for %L{u,d,i} in strings my $string; while ($line =~ /(?:^|")([X\t]*)(?:"|$)/g) {
Now that accessing current->comm needs to be protected, avoid new current->comm or other task->comm usage by adding a warning to checkpatch.pl. Fair warning: I know zero perl, so this was written in the style of "monkey see, monkey do". It does appear to work in my testing though. Thanks to Jiri Slaby and Michal Nazarewicz for help improving the regex! Close review and feedback would be appreciated. CC: Ted Ts'o <tytso@mit.edu> CC: Michal Nazarewicz <mina86@mina86.com> CC: Jiri Slaby <jirislaby@gmail.com> CC: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> CC: David Rientjes <rientjes@google.com> CC: Dave Hansen <dave@linux.vnet.ibm.com> CC: Andrew Morton <akpm@linux-foundation.org> CC: linux-mm@kvack.org Signed-off-by: John Stultz <john.stultz@linaro.org> --- scripts/checkpatch.pl | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)