[edk2,edk2-staging,01/19] IntelOpenSourceUndiPkg.dsc: add AARCH64 and ARM to supported architectures

Message ID 20181106175833.26964-2-ard.biesheuvel@linaro.org
State New
Headers show
Series
  • IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC
Related show

Commit Message

Ard Biesheuvel Nov. 6, 2018, 5:58 p.m.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

---
 IntelUndiPkg/IntelOpenSourceUndiPkg.dsc | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

-- 
2.19.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Ryszard Knop Jan. 29, 2019, 1:54 p.m. | #1
One thing of note here: We're primarily using MSVC for IA32/X64 builds,
and that's the only thing we "officially" support. I'll try to build
and test GCC binaries once in a while as well, but things might break
once now and then. Our team also doesn't have any ARM hardware to test
this on, so I'd appreciate any reports if it breaks :)

Reviewed-by: Ryszard Knop <ryszard.knop@linux.intel.com>


On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote:
> Contributed-under: TianoCore Contribution Agreement 1.1

> Signed-off-by: Ard Biesheuvel <ard.biesheuvel at linaro.org>

> ---

>  IntelUndiPkg/IntelOpenSourceUndiPkg.dsc | 13 ++++++++++++-

>  1 file changed, 12 insertions(+), 1 deletion(-)

> 

> diff --git a/IntelUndiPkg/IntelOpenSourceUndiPkg.dsc

> b/IntelUndiPkg/IntelOpenSourceUndiPkg.dsc

> index 21b1fb27984e..ca440bde2cb4 100644

> --- a/IntelUndiPkg/IntelOpenSourceUndiPkg.dsc

> +++ b/IntelUndiPkg/IntelOpenSourceUndiPkg.dsc

> @@ -29,7 +29,7 @@

>    PLATFORM_VERSION               = 0.1

>    DSC_SPECIFICATION              = 0x00010005

>    OUTPUT_DIRECTORY               = Build/IntelUndiPkg

> -  SUPPORTED_ARCHITECTURES        = IA32|IPF|X64

> +  SUPPORTED_ARCHITECTURES        = IA32|IPF|X64|ARM|AARCH64

>    BUILD_TARGETS                  = DEBUG|RELEASE|DEV

>    SKUID_IDENTIFIER               = DEFAULT

>  

> @@ -62,6 +62,17 @@

>    SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynch

> ronizationLib.inf

>    DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib

> /BaseDebugPrintErrorLevelLib.inf

>  

> +[LibraryClasses.ARM, LibraryClasses.AARCH64]

> +  #

> +  # It is not possible to prevent the ARM compiler from inserting

> calls to

> +  # intrinsic functions. This library provides the instrinsic

> functions such

> +  # a compiler may generate calls to.

> +  #

> +  NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.in

> f

> +

> +  # Add support for GCC stack protector

> +  NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf

> +

>  ####################################################################

> ############

>  #

>  # Pcd Section - list of all EDK II PCD Entries defined by this

> Platform


_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Ard Biesheuvel Jan. 29, 2019, 2:04 p.m. | #2
On Tue, 29 Jan 2019 at 14:54, Ryszard Knop <ryszard.knop@linux.intel.com> wrote:
>

> One thing of note here: We're primarily using MSVC for IA32/X64 builds,

> and that's the only thing we "officially" support. I'll try to build

> and test GCC binaries once in a while as well, but things might break

> once now and then. Our team also doesn't have any ARM hardware to test

> this on, so I'd appreciate any reports if it breaks :)

>

> Reviewed-by: Ryszard Knop <ryszard.knop@linux.intel.com>

>


Thanks!

Let me know once these changes have hit the upstream. I'll add GCC
builds for IA32, X64, ARM and AARCH64 to our CI setup.

> On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote:

> > Contributed-under: TianoCore Contribution Agreement 1.1

> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel at linaro.org>

> > ---

> >  IntelUndiPkg/IntelOpenSourceUndiPkg.dsc | 13 ++++++++++++-

> >  1 file changed, 12 insertions(+), 1 deletion(-)

> >

> > diff --git a/IntelUndiPkg/IntelOpenSourceUndiPkg.dsc

> > b/IntelUndiPkg/IntelOpenSourceUndiPkg.dsc

> > index 21b1fb27984e..ca440bde2cb4 100644

> > --- a/IntelUndiPkg/IntelOpenSourceUndiPkg.dsc

> > +++ b/IntelUndiPkg/IntelOpenSourceUndiPkg.dsc

> > @@ -29,7 +29,7 @@

> >    PLATFORM_VERSION               = 0.1

> >    DSC_SPECIFICATION              = 0x00010005

> >    OUTPUT_DIRECTORY               = Build/IntelUndiPkg

> > -  SUPPORTED_ARCHITECTURES        = IA32|IPF|X64

> > +  SUPPORTED_ARCHITECTURES        = IA32|IPF|X64|ARM|AARCH64

> >    BUILD_TARGETS                  = DEBUG|RELEASE|DEV

> >    SKUID_IDENTIFIER               = DEFAULT

> >

> > @@ -62,6 +62,17 @@

> >    SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynch

> > ronizationLib.inf

> >    DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib

> > /BaseDebugPrintErrorLevelLib.inf

> >

> > +[LibraryClasses.ARM, LibraryClasses.AARCH64]

> > +  #

> > +  # It is not possible to prevent the ARM compiler from inserting

> > calls to

> > +  # intrinsic functions. This library provides the instrinsic

> > functions such

> > +  # a compiler may generate calls to.

> > +  #

> > +  NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.in

> > f

> > +

> > +  # Add support for GCC stack protector

> > +  NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf

> > +

> >  ####################################################################

> > ############

> >  #

> >  # Pcd Section - list of all EDK II PCD Entries defined by this

> > Platform

>

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patch

diff --git a/IntelUndiPkg/IntelOpenSourceUndiPkg.dsc b/IntelUndiPkg/IntelOpenSourceUndiPkg.dsc
index 21b1fb27984e..ca440bde2cb4 100644
--- a/IntelUndiPkg/IntelOpenSourceUndiPkg.dsc
+++ b/IntelUndiPkg/IntelOpenSourceUndiPkg.dsc
@@ -29,7 +29,7 @@ 
   PLATFORM_VERSION               = 0.1
   DSC_SPECIFICATION              = 0x00010005
   OUTPUT_DIRECTORY               = Build/IntelUndiPkg
-  SUPPORTED_ARCHITECTURES        = IA32|IPF|X64
+  SUPPORTED_ARCHITECTURES        = IA32|IPF|X64|ARM|AARCH64
   BUILD_TARGETS                  = DEBUG|RELEASE|DEV
   SKUID_IDENTIFIER               = DEFAULT
 
@@ -62,6 +62,17 @@ 
   SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf
   DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf
 
+[LibraryClasses.ARM, LibraryClasses.AARCH64]
+  #
+  # It is not possible to prevent the ARM compiler from inserting calls to
+  # intrinsic functions. This library provides the instrinsic functions such
+  # a compiler may generate calls to.
+  #
+  NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
+
+  # Add support for GCC stack protector
+  NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
+
 ################################################################################
 #
 # Pcd Section - list of all EDK II PCD Entries defined by this Platform