From patchwork Tue Nov 6 17:58:22 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 150310 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp4192215ljp; Tue, 6 Nov 2018 09:59:18 -0800 (PST) X-Google-Smtp-Source: AJdET5cMOYRVgU35m58NG8SfsHHAYQkt7EAYL+g89ePjTDSFHlGDJ7L2CQxBc/PqQr5xCgdt/vGy X-Received: by 2002:a63:8549:: with SMTP id u70mr24610649pgd.401.1541527158290; Tue, 06 Nov 2018 09:59:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541527158; cv=none; d=google.com; s=arc-20160816; b=WzW9EX55zieqYTqmCUmpj3UuKB5LowFtxeAl3IQZ3YJyCt1fV3a/p2l6n2HJ0hoAvv kEyeBMOWYVyTefOBcC4bpk/41rRtyvfucXC+UEbiRzrg4cS2NHGO49DB8+G7LXVLdlyl 8xOYxHnbGP1z89DaD17QR5Pngm5+NyyFIx/+CG67ZiEbeQ4crrcBfQQhvqPUXc3E/A5c UiUBDAVvCVuFZ02YXcXlmRpBuc9p7WNTX4r7SKI21OsbuRbhP7dMLoK7LddwfUSNsZxx JWAhkapc6zu7Yai8LIhMy+cyKpLy7FUsK29RgFsZX7BzjWDPmWzS2+XV+XnZ3akQ89uk NPqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=Vz0PaysZIgNyUTAr+VeebnLP1ySqRAwa5r1+YQdLPUI=; b=rBnC6NzyeZy76fSNWHouIRxzUgWmNF2IBaT30py5McL4LmplK1c5nbAZyj58+aK5vH dtDvwXPY4/saRa8fAPiBIGWhuWItqKGcfFJyBuZS5QI56EZn4tuL5lplw5oqERNga6pU t3owaXkjktsRuFz5u2RS8YC0bZg8xEjhZpUhYBDMcTjHcZjokiEqftwMAXbIZ2IDjRqJ XUWXyxFGMFCD/Z5MMF+MLYFO0sN+hWsNgUw2fnpfxuVqwhEh+WvfT27Wb61GiTUJ9pmo 64/RgISSNiUgeWeA6Y3Kn58f+hCt86TyXqvrDIMFEXl7W0kx7MNHHHp2+8kFymoUM1lU 8Liw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=UavHifYP; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [198.145.21.10]) by mx.google.com with ESMTPS id 33-v6si17786906pls.173.2018.11.06.09.59.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 09:59:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) client-ip=198.145.21.10; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=UavHifYP; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id DE33521BADAB3; Tue, 6 Nov 2018 09:59:02 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::443; helo=mail-wr1-x443.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 516D921188C31 for ; Tue, 6 Nov 2018 09:59:01 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id j17-v6so9427947wrq.11 for ; Tue, 06 Nov 2018 09:59:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ImGXwIRUD5Exq0PxIb5UQ5CGAlV6iJYdbCC4RQV3BII=; b=UavHifYPJPE4ErEDofxIRh83UMGJ5a8eVVjHBoP/C03wZJgbr8Uh718meVmSrT2sOC IQrAfJ17elpCAbNhRjcAN+u+AIt0LxGKXfxfPeH4m7QEyT3TZK2/WcgIZNVL5Rrun0e5 dEteIG18T+Z8n5ffSdNAOTZDYiIBQbs9m6SAo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ImGXwIRUD5Exq0PxIb5UQ5CGAlV6iJYdbCC4RQV3BII=; b=sNi8LuFT1wHkcppbI60dhTBiBRGhBNpPBD92vehfabgqdxOrY1MUuPkf6MAUQWS/pU NbS5WXbcmzN8qVKIx+ELLggZfLKCVNdtQUrDTZrT3vHdenKeC7DjGV3nMt7fBRi1gaQV 0r3npUKeFfcrq30AXxP/34rsiHWLmP3qj8N3rv+q4A1DQa0dwsJZ7FfZWpeR5+pyDZ8O e8VSj9UO3hG7AR8RO5/5rEhAYPLbanscmBbgxRzswyxdS8yDlFOQwUYguuonZYCqGkxw i739Tlvk0rAajL/StbmtcRKv4GoPHRZOZVdBVdu6bTRMlZh5TYuEl798YSV0MxJD7ere kSuA== X-Gm-Message-State: AGRZ1gIeCsE7AIoKf12XJ0F2Xc68CFINMPSbovsNMv6hETxmTYa2fOrC UFgvclfFfeadU7o/G70GD4EWaH+A0zo= X-Received: by 2002:adf:8c09:: with SMTP id z9-v6mr24151256wra.82.1541527139646; Tue, 06 Nov 2018 09:58:59 -0800 (PST) Received: from localhost.localdomain (laubervilliers-657-1-83-120.w92-154.abo.wanadoo.fr. [92.154.90.120]) by smtp.gmail.com with ESMTPSA id 134-v6sm2971522wmp.6.2018.11.06.09.58.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 09:58:58 -0800 (PST) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Tue, 6 Nov 2018 18:58:22 +0100 Message-Id: <20181106175833.26964-9-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181106175833.26964-1-ard.biesheuvel@linaro.org> References: <20181106175833.26964-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Subject: [edk2] [PATCH edk2-staging 08/19] IntelUndiPkg/GigUndiDxe: add missing VOID** cast X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: michael.d.kinney@intel.com, eric.jin@intel.com Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" Unlike Visual Studio, GCC does not permit implicit conversion between a pointer-to-void-pointer and pointer to a typed pointer. So add the explicit casts where necessary. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelUndiPkg/GigUndiDxe/Hii.c | 8 ++++---- IntelUndiPkg/GigUndiDxe/Init.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) -- 2.19.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Ryszard Knop diff --git a/IntelUndiPkg/GigUndiDxe/Hii.c b/IntelUndiPkg/GigUndiDxe/Hii.c index 43c184cb03c8..a5d8ae207819 100644 --- a/IntelUndiPkg/GigUndiDxe/Hii.c +++ b/IntelUndiPkg/GigUndiDxe/Hii.c @@ -459,7 +459,7 @@ HiiOpenProtocol ( Status = gBS->LocateProtocol ( &gEfiHiiDatabaseProtocolGuid, NULL, - &UndiPrivateData->HiiDatabase + (VOID **)&UndiPrivateData->HiiDatabase ); if (EFI_ERROR (Status)) { DEBUGPRINT (CRITICAL, ("Error finding HII protocol: %r\n", Status)); @@ -472,7 +472,7 @@ HiiOpenProtocol ( Status = gBS->LocateProtocol ( &gEfiHiiStringProtocolGuid, NULL, - &UndiPrivateData->HiiString + (VOID **)&UndiPrivateData->HiiString ); if (EFI_ERROR (Status)) { DEBUGPRINT (CRITICAL, ("Error finding HII String protocol: %r\n", Status)); @@ -485,7 +485,7 @@ HiiOpenProtocol ( Status = gBS->LocateProtocol ( &gEfiFormBrowser2ProtocolGuid, NULL, - &UndiPrivateData->FormBrowser2 + (VOID **)&UndiPrivateData->FormBrowser2 ); if (EFI_ERROR (Status)) { DEBUGPRINT (CRITICAL, ("Error finding HII form browser protocol: %r\n", Status)); @@ -498,7 +498,7 @@ HiiOpenProtocol ( Status = gBS->LocateProtocol ( &gEfiHiiConfigRoutingProtocolGuid, NULL, - &UndiPrivateData->HiiConfigRouting + (VOID **)&UndiPrivateData->HiiConfigRouting ); if (EFI_ERROR (Status)) { DEBUGPRINT (CRITICAL, ("Error finding HII ConfigRouting protocol: %r\n", Status)); diff --git a/IntelUndiPkg/GigUndiDxe/Init.c b/IntelUndiPkg/GigUndiDxe/Init.c index f99734d72823..1de424c26fe2 100644 --- a/IntelUndiPkg/GigUndiDxe/Init.c +++ b/IntelUndiPkg/GigUndiDxe/Init.c @@ -177,7 +177,7 @@ GigAppendMac2DevPath ( Status = gBS->AllocatePool ( EfiBootServicesData, // EfiRuntimeServicesData, TotalPathLen, - &DevicePtr + (VOID **)&DevicePtr ); if (Status != EFI_SUCCESS) {