| Message ID | 20181112042116.5271-3-joel@jms.id.au |
|---|---|
| State | Accepted |
| Commit | 813af51f5d30a2da6a2523c08465f9726e51772e |
| Headers | show |
| Series | powerpc/boot: Fix cross compiling with clang | expand |
Joel Stanley <joel@jms.id.au> writes: > Clang needs to be told which target it is building for when cross > compiling. > > Link: https://github.com/ClangBuiltLinux/linux/issues/259 > Signed-off-by: Joel Stanley <joel@jms.id.au> > --- > arch/powerpc/boot/Makefile | 5 +++++ > 1 file changed, 5 insertions(+) Acked-by: Michael Ellerman <mpe@ellerman.id.au> cheers > diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile > index 39354365f54a..111f97b1ccec 100644 > --- a/arch/powerpc/boot/Makefile > +++ b/arch/powerpc/boot/Makefile > @@ -55,6 +55,11 @@ BOOTAFLAGS := -D__ASSEMBLY__ $(BOOTCFLAGS) -traditional -nostdinc > > BOOTARFLAGS := -cr$(KBUILD_ARFLAGS) > > +ifdef CONFIG_CC_IS_CLANG > +BOOTCFLAGS += $(CLANG_FLAGS) > +BOOTAFLAGS += $(CLANG_FLAGS) > +endif > + > ifdef CONFIG_DEBUG_INFO > BOOTCFLAGS += -g > endif > -- > 2.19.1
On Sun, Nov 11, 2018 at 8:21 PM Joel Stanley <joel@jms.id.au> wrote: > > Clang needs to be told which target it is building for when cross > compiling. Neat! This will help us for continuous integration. https://github.com/ClangBuiltLinux/continuous-integration > > Link: https://github.com/ClangBuiltLinux/linux/issues/259 > Signed-off-by: Joel Stanley <joel@jms.id.au> Assuming patch 1/2 gets fixed up (or is fine) and doesn't radically change: Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> > --- > arch/powerpc/boot/Makefile | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile > index 39354365f54a..111f97b1ccec 100644 > --- a/arch/powerpc/boot/Makefile > +++ b/arch/powerpc/boot/Makefile > @@ -55,6 +55,11 @@ BOOTAFLAGS := -D__ASSEMBLY__ $(BOOTCFLAGS) -traditional -nostdinc > > BOOTARFLAGS := -cr$(KBUILD_ARFLAGS) > > +ifdef CONFIG_CC_IS_CLANG > +BOOTCFLAGS += $(CLANG_FLAGS) > +BOOTAFLAGS += $(CLANG_FLAGS) > +endif > + > ifdef CONFIG_DEBUG_INFO > BOOTCFLAGS += -g > endif > -- > 2.19.1 > -- Thanks, ~Nick Desaulniers
On Tue, Nov 13, 2018 at 4:03 AM Nick Desaulniers <ndesaulniers@google.com> wrote: > > On Sun, Nov 11, 2018 at 8:21 PM Joel Stanley <joel@jms.id.au> wrote: > > > > Clang needs to be told which target it is building for when cross > > compiling. > > Neat! This will help us for continuous integration. > https://github.com/ClangBuiltLinux/continuous-integration > > > > > Link: https://github.com/ClangBuiltLinux/linux/issues/259 > > Signed-off-by: Joel Stanley <joel@jms.id.au> > > Assuming patch 1/2 gets fixed up (or is fine) and doesn't radically change: > Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> > Applied to linux-kbuild. Thanks! > > --- > > arch/powerpc/boot/Makefile | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile > > index 39354365f54a..111f97b1ccec 100644 > > --- a/arch/powerpc/boot/Makefile > > +++ b/arch/powerpc/boot/Makefile > > @@ -55,6 +55,11 @@ BOOTAFLAGS := -D__ASSEMBLY__ $(BOOTCFLAGS) -traditional -nostdinc > > > > BOOTARFLAGS := -cr$(KBUILD_ARFLAGS) > > > > +ifdef CONFIG_CC_IS_CLANG > > +BOOTCFLAGS += $(CLANG_FLAGS) > > +BOOTAFLAGS += $(CLANG_FLAGS) > > +endif > > + > > ifdef CONFIG_DEBUG_INFO > > BOOTCFLAGS += -g > > endif > > -- > > 2.19.1 > > > > > -- > Thanks, > ~Nick Desaulniers -- Best Regards Masahiro Yamada
diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile index 39354365f54a..111f97b1ccec 100644 --- a/arch/powerpc/boot/Makefile +++ b/arch/powerpc/boot/Makefile @@ -55,6 +55,11 @@ BOOTAFLAGS := -D__ASSEMBLY__ $(BOOTCFLAGS) -traditional -nostdinc BOOTARFLAGS := -cr$(KBUILD_ARFLAGS) +ifdef CONFIG_CC_IS_CLANG +BOOTCFLAGS += $(CLANG_FLAGS) +BOOTAFLAGS += $(CLANG_FLAGS) +endif + ifdef CONFIG_DEBUG_INFO BOOTCFLAGS += -g endif
Clang needs to be told which target it is building for when cross compiling. Link: https://github.com/ClangBuiltLinux/linux/issues/259 Signed-off-by: Joel Stanley <joel@jms.id.au> --- arch/powerpc/boot/Makefile | 5 +++++ 1 file changed, 5 insertions(+) -- 2.19.1