[v2] qemu-arm: Enable VirtIO distro target

Message ID 1542084684-24893-1-git-send-email-sumit.garg@linaro.org
State Accepted
Commit 5266db16eeba3318e2d0a6e27eb91c0b494d0de4
Headers show
Series
  • [v2] qemu-arm: Enable VirtIO distro target
Related show

Commit Message

Sumit Garg Nov. 13, 2018, 4:51 a.m.
With -device virtio-blk-device,drive=hd0, it could detect distro boot
target.

Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
---

Changes in v2:
Change boot order to SCSI; VIRTIO; DHCP as DHCP is quiet slow, so kept
as last boot option.

Depends on https://patchwork.ozlabs.org/patch/995524/ which adds VirtIO
distro boot command.

 include/configs/qemu-arm.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Alexander Graf Nov. 13, 2018, 9:02 a.m. | #1
On 13.11.18 05:51, Sumit Garg wrote:
> With -device virtio-blk-device,drive=hd0, it could detect distro boot
> target.
> 
> Signed-off-by: Sumit Garg <sumit.garg@linaro.org>

Reviewed-by: Alexander Graf <agraf@suse.de>

> ---
> 
> Changes in v2:
> Change boot order to SCSI; VIRTIO; DHCP as DHCP is quiet slow, so kept

quite :)


Alex

> as last boot option.
> 
> Depends on https://patchwork.ozlabs.org/patch/995524/ which adds VirtIO
> distro boot command.
> 
>  include/configs/qemu-arm.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/configs/qemu-arm.h b/include/configs/qemu-arm.h
> index fedc466..33dcce0 100644
> --- a/include/configs/qemu-arm.h
> +++ b/include/configs/qemu-arm.h
> @@ -25,6 +25,7 @@
>  
>  #define BOOT_TARGET_DEVICES(func) \
>  	func(SCSI, scsi, 0) \
> +	func(VIRTIO, virtio, 0) \
>  	func(DHCP, dhcp, na)
>  
>  #include <config_distro_bootcmd.h>
>
Sumit Garg Dec. 11, 2018, 12:26 p.m. | #2
Hi Tom,

On Tue, 13 Nov 2018 at 14:33, Alexander Graf <agraf@suse.de> wrote:
>
>
>
> On 13.11.18 05:51, Sumit Garg wrote:
> > With -device virtio-blk-device,drive=hd0, it could detect distro boot
> > target.
> >
> > Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
>
> Reviewed-by: Alexander Graf <agraf@suse.de>
>
> > ---
> >
> > Changes in v2:
> > Change boot order to SCSI; VIRTIO; DHCP as DHCP is quiet slow, so kept
>
> quite :)
>
>
> Alex
>
> > as last boot option.
> >
> > Depends on https://patchwork.ozlabs.org/patch/995524/ which adds VirtIO
> > distro boot command.
> >

With above dependency patch merged in upstream, I think it should be
ok to merge this one too.

-Sumit

> >  include/configs/qemu-arm.h | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/include/configs/qemu-arm.h b/include/configs/qemu-arm.h
> > index fedc466..33dcce0 100644
> > --- a/include/configs/qemu-arm.h
> > +++ b/include/configs/qemu-arm.h
> > @@ -25,6 +25,7 @@
> >
> >  #define BOOT_TARGET_DEVICES(func) \
> >       func(SCSI, scsi, 0) \
> > +     func(VIRTIO, virtio, 0) \
> >       func(DHCP, dhcp, na)
> >
> >  #include <config_distro_bootcmd.h>
> >
Tom Rini Dec. 13, 2018, 12:46 a.m. | #3
On Tue, Nov 13, 2018 at 10:21:24AM +0530, Sumit Garg wrote:

> With -device virtio-blk-device,drive=hd0, it could detect distro boot

> target.

> 

> Signed-off-by: Sumit Garg <sumit.garg@linaro.org>

> Reviewed-by: Alexander Graf <agraf@suse.de>


Applied to u-boot/master, thanks!

-- 
Tom

Patch

diff --git a/include/configs/qemu-arm.h b/include/configs/qemu-arm.h
index fedc466..33dcce0 100644
--- a/include/configs/qemu-arm.h
+++ b/include/configs/qemu-arm.h
@@ -25,6 +25,7 @@ 
 
 #define BOOT_TARGET_DEVICES(func) \
 	func(SCSI, scsi, 0) \
+	func(VIRTIO, virtio, 0) \
 	func(DHCP, dhcp, na)
 
 #include <config_distro_bootcmd.h>