From patchwork Tue Nov 13 05:49:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Levin X-Patchwork-Id: 150902 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp4005075ljp; Mon, 12 Nov 2018 21:50:41 -0800 (PST) X-Google-Smtp-Source: AJdET5fJKyJBlpYKP6lnI/Y8x9MhWnVipLwQ8p9hq86felRVNMpCego5406CPzVgf1R4OJp7zeW4 X-Received: by 2002:a62:cac4:: with SMTP id y65-v6mr3778971pfk.27.1542088241682; Mon, 12 Nov 2018 21:50:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542088241; cv=none; d=google.com; s=arc-20160816; b=VMutwbJxir3YJcRSMMAn0wP7aIikMmvFFjSpvWE4iAX9Z9/LyUXJhAYRuJuptPCgM3 w7wzrM49Y+sd5KX/ilkOG0Kg3fFL+0RKW16PcbKGga/V+vagqzbXZ+VxOpz6U3XEur3Q zgi9JefOsakjgSTW3WrNV+ADBu9yKDieOxaExPv0lF2EEw04TPlcjeiPSMbq79lJwOAE jRNhoWLf0gFX70l2JjiFvnsd9uQ9MdPlpBBhwufFRgyM9o72VGgYkq3HLtufhppp08OO 1lRcvJlx+QhlSlE0cUFpMWTCKQ6OhSxfpbdcc+W2QApbCMFQUrIsytNRVigj4K3mJ7bk VQ0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=mnESPIrI+Nme8yiUR4aZMlQ1FRmPd/MmZkLwqjaGrPQ=; b=XN34R5SOmHYkb2biU6JpZWmxYZoNX9IvbtKjS6crypaBdVo3JBKxDcGFEfduRr6vDX it+4TqI43PFhiEOx4pSdMSxaPFyCvHwOqcASdMUrdVTBMRGH9yUxG3SV0WKSxJYeuYcy N0cJN5/Gs1wwyIp15Uzqb7iXBQQjpefaj5t9/XNV/qXr6OD5Ha6VSKEafLqSgsERCAgZ 06q5vPrIa1FyGwI7DbfdFIgwbOHSMRxHC0QlD/42X/UCHxNs0902euyaYUu+Xe608PIU TS3AcPAghfRBKhMawUMXJjYGtEG4MQKqKBBfc//D/rTN3gZ9JrKVeOxEym+b2UXw1DLC 4acg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=LhcsHpxX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 62-v6si21410242pfu.2.2018.11.12.21.50.41; Mon, 12 Nov 2018 21:50:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=LhcsHpxX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731641AbeKMPrG (ORCPT + 32 others); Tue, 13 Nov 2018 10:47:06 -0500 Received: from mail.kernel.org ([198.145.29.99]:60844 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731477AbeKMPrE (ORCPT ); Tue, 13 Nov 2018 10:47:04 -0500 Received: from sasha-vm.mshome.net (unknown [64.114.255.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4916B2250F; Tue, 13 Nov 2018 05:50:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1542088236; bh=0TPpHlUsaHzJegStfDXj8ImOiNKPRTMI/2oEu/QolJU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LhcsHpxX8SGxf8wMKE0Yto9OFioi9HUpVor8zpNzj52FRFXpS4IFU5wHwD8+EnsIU gWKSKpsI2nyMki31IirzSuq4qvFpFoYz1PtW/U4GnOBfRRTWxpHR4T4ojx7fz9fcSf u05c5hOcYbr8dUU51oYsJAjbY0QfbRlqnQtrzTgk= From: Sasha Levin To: stable@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jerome Brunet , Sasha Levin , linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 33/44] clk: meson: clk-pll: drop CLK_GET_RATE_NOCACHE where unnecessary Date: Tue, 13 Nov 2018 00:49:39 -0500 Message-Id: <20181113054950.77898-33-sashal@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181113054950.77898-1-sashal@kernel.org> References: <20181113054950.77898-1-sashal@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jerome Brunet [ Upstream commit 2303a9ca693e585a558497ad737728fec97e2b8a ] CLK_GET_RATE_NOCACHE should only be necessary when the registers controlling the rate of clock may change outside of CCF. On Amlogic, it should only be the case for the hdmi pll which is directly controlled by the display driver (WIP to fix this). The other plls should not require this flag. Reviewed-by: Martin Blumenstingl Tested-by: Martin Blumenstingl Signed-off-by: Jerome Brunet Signed-off-by: Sasha Levin --- drivers/clk/meson/axg.c | 1 - drivers/clk/meson/gxbb.c | 12 ++++++++---- drivers/clk/meson/meson8b.c | 3 --- 3 files changed, 8 insertions(+), 8 deletions(-) -- 2.17.1 diff --git a/drivers/clk/meson/axg.c b/drivers/clk/meson/axg.c index a95152071087..f24d38c12e09 100644 --- a/drivers/clk/meson/axg.c +++ b/drivers/clk/meson/axg.c @@ -96,7 +96,6 @@ static struct clk_regmap axg_sys_pll = { .ops = &meson_clk_pll_ro_ops, .parent_names = (const char *[]){ "xtal" }, .num_parents = 1, - .flags = CLK_GET_RATE_NOCACHE, }, }; diff --git a/drivers/clk/meson/gxbb.c b/drivers/clk/meson/gxbb.c index 86d3ae58e84c..58e4b66bfc55 100644 --- a/drivers/clk/meson/gxbb.c +++ b/drivers/clk/meson/gxbb.c @@ -213,7 +213,6 @@ static struct clk_regmap gxbb_fixed_pll = { .ops = &meson_clk_pll_ro_ops, .parent_names = (const char *[]){ "xtal" }, .num_parents = 1, - .flags = CLK_GET_RATE_NOCACHE, }, }; @@ -276,6 +275,10 @@ static struct clk_regmap gxbb_hdmi_pll = { .ops = &meson_clk_pll_ro_ops, .parent_names = (const char *[]){ "hdmi_pll_pre_mult" }, .num_parents = 1, + /* + * Display directly handle hdmi pll registers ATM, we need + * NOCACHE to keep our view of the clock as accurate as possible + */ .flags = CLK_GET_RATE_NOCACHE, }, }; @@ -334,6 +337,10 @@ static struct clk_regmap gxl_hdmi_pll = { .ops = &meson_clk_pll_ro_ops, .parent_names = (const char *[]){ "xtal" }, .num_parents = 1, + /* + * Display directly handle hdmi pll registers ATM, we need + * NOCACHE to keep our view of the clock as accurate as possible + */ .flags = CLK_GET_RATE_NOCACHE, }, }; @@ -371,7 +378,6 @@ static struct clk_regmap gxbb_sys_pll = { .ops = &meson_clk_pll_ro_ops, .parent_names = (const char *[]){ "xtal" }, .num_parents = 1, - .flags = CLK_GET_RATE_NOCACHE, }, }; @@ -418,7 +424,6 @@ static struct clk_regmap gxbb_gp0_pll = { .ops = &meson_clk_pll_ops, .parent_names = (const char *[]){ "xtal" }, .num_parents = 1, - .flags = CLK_GET_RATE_NOCACHE, }, }; @@ -472,7 +477,6 @@ static struct clk_regmap gxl_gp0_pll = { .ops = &meson_clk_pll_ops, .parent_names = (const char *[]){ "xtal" }, .num_parents = 1, - .flags = CLK_GET_RATE_NOCACHE, }, }; diff --git a/drivers/clk/meson/meson8b.c b/drivers/clk/meson/meson8b.c index 7447d96a265f..74697e145dde 100644 --- a/drivers/clk/meson/meson8b.c +++ b/drivers/clk/meson/meson8b.c @@ -132,7 +132,6 @@ static struct clk_regmap meson8b_fixed_pll = { .ops = &meson_clk_pll_ro_ops, .parent_names = (const char *[]){ "xtal" }, .num_parents = 1, - .flags = CLK_GET_RATE_NOCACHE, }, }; @@ -169,7 +168,6 @@ static struct clk_regmap meson8b_vid_pll = { .ops = &meson_clk_pll_ro_ops, .parent_names = (const char *[]){ "xtal" }, .num_parents = 1, - .flags = CLK_GET_RATE_NOCACHE, }, }; @@ -207,7 +205,6 @@ static struct clk_regmap meson8b_sys_pll = { .ops = &meson_clk_pll_ro_ops, .parent_names = (const char *[]){ "xtal" }, .num_parents = 1, - .flags = CLK_GET_RATE_NOCACHE, }, };