[v4,3/4] ARM: dts: stm32: Add hwspinlock node for stm32mp157 SoC

Message ID 20181114090027.7580-4-benjamin.gaignard@linaro.org
State Superseded
Headers show
Series
  • Add support of STM32 hwspinlock
Related show

Commit Message

Benjamin Gaignard Nov. 14, 2018, 9 a.m.
From: Benjamin Gaignard <benjamin.gaignard@st.com>


Declare hwspinlock device for stm32mp157 SoC

Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>

Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>

---
 arch/arm/boot/dts/stm32mp157c.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)

-- 
2.15.0

Comments

kernel test robot Nov. 16, 2018, 3:24 p.m. | #1
Hi Benjamin,

I love your patch! Yet something to improve:

[auto build test ERROR on stm32/stm32-next]
[cannot apply to v4.20-rc2 next-20181116]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Benjamin-Gaignard/Add-support-of-STM32-hwspinlock/20181115-204402
base:   https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git stm32-next
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=arm 

All errors (new ones prefixed by >>):

   arch/arm/boot/dts/stm32mp157c-ed1.dtb: ERROR (duplicate_node_names): /soc/hwspinlock@4c000000: Duplicate node name
>> ERROR: Input tree has errors, aborting (use -f to force output)

--
   arch/arm/boot/dts/stm32mp157c-ev1.dtb: ERROR (duplicate_node_names): /soc/hwspinlock@4c000000: Duplicate node name
>> ERROR: Input tree has errors, aborting (use -f to force output)


---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
Benjamin Gaignard Dec. 6, 2018, 9:59 a.m. | #2
Le mer. 14 nov. 2018 à 10:00, Benjamin Gaignard
<benjamin.gaignard@linaro.org> a écrit :
>

> From: Benjamin Gaignard <benjamin.gaignard@st.com>

>

> Declare hwspinlock device for stm32mp157 SoC


I abandon this patch and I will send a one that fixes the issues.

>

> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>

> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>

> ---

>  arch/arm/boot/dts/stm32mp157c.dtsi | 9 +++++++++

>  1 file changed, 9 insertions(+)

>

> diff --git a/arch/arm/boot/dts/stm32mp157c.dtsi b/arch/arm/boot/dts/stm32mp157c.dtsi

> index 185541a5b69f..98f824d8b0f0 100644

> --- a/arch/arm/boot/dts/stm32mp157c.dtsi

> +++ b/arch/arm/boot/dts/stm32mp157c.dtsi

> @@ -803,6 +803,15 @@

>                         status = "disabled";

>                 };

>

> +               hsem: hwspinlock@4c000000 {

> +                       compatible = "st,stm32-hwspinlock";

> +                       #hwlock-cells = <1>;

> +                       reg = <0x4c000000 0x400>;

> +                       clocks = <&rcc HSEM>;

> +                       clock-names = "hwsem";

> +                       status = "disabled";

> +               };

> +

>                 rcc: rcc@50000000 {

>                         compatible = "st,stm32mp1-rcc", "syscon";

>                         reg = <0x50000000 0x1000>;

> --

> 2.15.0

>



-- 
Benjamin Gaignard

Graphic Study Group

Linaro.org │ Open source software for ARM SoCs

Follow Linaro: Facebook | Twitter | Blog

Patch

diff --git a/arch/arm/boot/dts/stm32mp157c.dtsi b/arch/arm/boot/dts/stm32mp157c.dtsi
index 185541a5b69f..98f824d8b0f0 100644
--- a/arch/arm/boot/dts/stm32mp157c.dtsi
+++ b/arch/arm/boot/dts/stm32mp157c.dtsi
@@ -803,6 +803,15 @@ 
 			status = "disabled";
 		};
 
+		hsem: hwspinlock@4c000000 {
+			compatible = "st,stm32-hwspinlock";
+			#hwlock-cells = <1>;
+			reg = <0x4c000000 0x400>;
+			clocks = <&rcc HSEM>;
+			clock-names = "hwsem";
+			status = "disabled";
+		};
+
 		rcc: rcc@50000000 {
 			compatible = "st,stm32mp1-rcc", "syscon";
 			reg = <0x50000000 0x1000>;