[edk2,edk2-staging,18/20] IntelUndiPkg/XGigUndiDxe: set MDEPKG_NDEBUG only for RELEASE builds

Message ID 20181115023353.20159-19-ard.biesheuvel@linaro.org
State New
Headers show
Series
  • IntelUndiPkg/XGigUndiDxe: fix GCC / ARM build issues
Related show

Commit Message

Ard Biesheuvel Nov. 15, 2018, 2:33 a.m.
Only define the CPP macro MDEPKG_NDEBUG for the RELEASE target so
that debug features are functional otherwise.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

---
 IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.17.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Ryszard Knop Jan. 30, 2019, 5:15 p.m. | #1
Reviewed-by: Ryszard Knop <ryszard.knop@linux.intel.com>


On Wed, 2018-11-14 at 18:33 -0800, ard.biesheuvela wrote:
> Only define the CPP macro MDEPKG_NDEBUG for the RELEASE target so

> that debug features are functional otherwise.

> 

> Contributed-under: TianoCore Contribution Agreement 1.1

> Signed-off-by: Ard Biesheuvel <ard.biesheuvel at linaro.org>

> ---

>  IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf | 3 ++-

>  1 file changed, 2 insertions(+), 1 deletion(-)

> 

> diff --git a/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf

> b/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf

> index b5747565fbea..e3201fb9881f 100644

> --- a/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf

> +++ b/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf

> @@ -44,7 +44,8 @@ UNLOAD_IMAGE         = UnloadXGigUndiDriver

>  

>  [BuildOptions.common]

>  

> -MSFT:*_*_*_CC_FLAGS = /FAcs /D MDEPKG_NDEBUG /D UNDI_10G /wd4244

> /wd4206 /wd4189

> +MSFT:*_*_*_CC_FLAGS = /FAcs /D UNDI_10G /wd4244 /wd4206 /wd4189

> +MSFT:RELEASE_*_*_CC_FLAGS = /D MDEPKG_NDEBUG

>  GCC:*_*_*_CC_FLAGS = -DUNDI_10G

>  GCC:RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG

>  


_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patch

diff --git a/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf b/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf
index b5747565fbea..e3201fb9881f 100644
--- a/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf
+++ b/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf
@@ -44,7 +44,8 @@  UNLOAD_IMAGE         = UnloadXGigUndiDriver
 
 [BuildOptions.common]
 
-MSFT:*_*_*_CC_FLAGS = /FAcs /D MDEPKG_NDEBUG /D UNDI_10G /wd4244 /wd4206 /wd4189
+MSFT:*_*_*_CC_FLAGS = /FAcs /D UNDI_10G /wd4244 /wd4206 /wd4189
+MSFT:RELEASE_*_*_CC_FLAGS = /D MDEPKG_NDEBUG
 GCC:*_*_*_CC_FLAGS = -DUNDI_10G
 GCC:RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG