[edk2,edk2-platforms,v2,13/15] Silicon/Hisilicon/D05: Drop _CID for fwts issue

Message ID 20181116065702.30559-14-ming.huang@linaro.org
State New
Headers show
Series
  • Fix D06 SBSA/SBBR issue and improve
Related show

Commit Message

Ming Huang Nov. 16, 2018, 6:57 a.m.
As Linux kernel as we only match with HID, We can remove MBIGEN and
PL011 CID in ACPI ASL code.

The fwts issue:
method: \_SB_.COM0._CID returned a string 'PL011' but it was not a
valid PNP ID or a valid ACPI ID.
method: \_SB_.MB30._CID returned a string 'MBIGEN' but it was not a
valid PNP ID or a valid ACPI ID.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang <ming.huang@linaro.org>

---
 Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/Com.asl     |  1 -
 Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Mbig.asl | 13 -------------
 2 files changed, 14 deletions(-)

-- 
2.9.5

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patch

diff --git a/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/Com.asl b/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/Com.asl
index f0169ce75f2d..2cc44fcb2e25 100644
--- a/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/Com.asl
+++ b/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/Com.asl
@@ -18,7 +18,6 @@  Scope(_SB)
 {
   Device(COM0) {
     Name(_HID, "ARMH0011")
-    Name(_CID, "PL011")
     Name(_UID, Zero)
     Name(_CRS, ResourceTemplate() {
       Memory32Fixed(ReadWrite, 0x602B0000, 0x1000)
diff --git a/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Mbig.asl b/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Mbig.asl
index cdf3e57613f2..60d07a1a921e 100644
--- a/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Mbig.asl
+++ b/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Mbig.asl
@@ -18,7 +18,6 @@  Scope(_SB)
   // Mbi-gen peri b intc
   Device(MBI0) {
     Name(_HID, "HISI0152")
-    Name(_CID, "MBIGen")
     Name(_CRS, ResourceTemplate() {
       Memory32Fixed(ReadWrite, 0x60080000, 0x10000)
     })
@@ -38,7 +37,6 @@  Scope(_SB)
 
   Device(MBI1) {
     Name(_HID, "HISI0152")
-    Name(_CID, "MBIGen")
     Name(_CRS, ResourceTemplate() {
       Memory32Fixed(ReadWrite, 0xc0080000, 0x10000)
     })
@@ -93,7 +91,6 @@  Scope(_SB)
   // Mbi-gen sas0
   Device(MBI2) {
     Name(_HID, "HISI0152")
-    Name(_CID, "MBIGen")
     Name(_CRS, ResourceTemplate() {
       Memory32Fixed(ReadWrite, 0xc0080000, 0x10000)
     })
@@ -146,7 +143,6 @@  Scope(_SB)
 
   Device(MBI3) {          // Mbi-gen sas1 intc
     Name(_HID, "HISI0152")
-    Name(_CID, "MBIGen")
     Name(_CRS, ResourceTemplate() {
       Memory32Fixed(ReadWrite, 0xa0080000, 0x10000)
     })
@@ -198,7 +194,6 @@  Scope(_SB)
   }
   Device(MBI4) {          // Mbi-gen sas2 intc
     Name(_HID, "HISI0152")
-    Name(_CID, "MBIGen")
     Name(_CRS, ResourceTemplate() {
       Memory32Fixed(ReadWrite, 0xa0080000, 0x10000)
     })
@@ -251,7 +246,6 @@  Scope(_SB)
 
   Device(MBI5) {
     Name(_HID, "HISI0152")
-    Name(_CID, "MBIGen")
     Name(_CRS, ResourceTemplate() {
       Memory32Fixed(ReadWrite, 0xa0080000, 0x10000)
     })
@@ -271,7 +265,6 @@  Scope(_SB)
 
   Device(MBI6) {
     Name(_HID, "HISI0152")
-    Name(_CID, "MBIGen")
     Name(_CRS, ResourceTemplate() {
       Memory32Fixed(ReadWrite, 0xd0080000, 0x10000)
     })
@@ -291,7 +284,6 @@  Scope(_SB)
 
   Device(MBI7) {
     Name(_HID, "HISI0152")
-    Name(_CID, "MBIGen")
     Name(_CRS, ResourceTemplate() {
       Memory32Fixed(ReadWrite, 0xd0080000, 0x10000)
     })
@@ -311,7 +303,6 @@  Scope(_SB)
 
   Device(MBI8) {
     Name(_HID, "HISI0152")
-    Name(_CID, "MBIGen")
     Name(_CRS, ResourceTemplate() {
       QwordMemory (
         ResourceProducer,
@@ -377,7 +368,6 @@  Scope(_SB)
 /*
   Device(MBI4) {          // Mbi-gen dsa1 dbg0 intc
     Name(_HID, "HISI0152")
-    Name(_CID, "MBIGen")
     Name(_CRS, ResourceTemplate() {
       Memory32Fixed(ReadWrite, 0xc0080000, 0x10000)
     })
@@ -392,7 +382,6 @@  Scope(_SB)
 
   Device(MBI5) {          // Mbi-gen dsa2 dbg1 intc
     Name(_HID, "HISI0152")
-    Name(_CID, "MBIGen")
     Name(_CRS, ResourceTemplate() {
       Memory32Fixed(ReadWrite, 0xc0080000, 0x10000)
     })
@@ -407,7 +396,6 @@  Scope(_SB)
 
   Device(MBI6) {          // Mbi-gen dsa sas0 intc
     Name(_HID, "HISI0152")
-    Name(_CID, "MBIGen")
     Name(_CRS, ResourceTemplate() {
       Memory32Fixed(ReadWrite, 0xc0080000, 0x10000)
     })
@@ -422,7 +410,6 @@  Scope(_SB)
 */
   Device(MBI9) {          // Mbi-gen roce intc
     Name(_HID, "HISI0152")
-    Name(_CID, "MBIGen")
     Name(_CRS, ResourceTemplate() {
       Memory32Fixed(ReadWrite, 0xc0080000, 0x10000)
     })