From patchwork Fri Nov 16 10:04:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 151320 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp228986ljp; Fri, 16 Nov 2018 02:05:21 -0800 (PST) X-Google-Smtp-Source: AJdET5dK2nB9vd1BRWLlq3yLlfDulLt9Cy3Qbh+wtjnUX7geLMxX3efAioin22qo09RAskkmKJj9 X-Received: by 2002:a63:e055:: with SMTP id n21mr9428355pgj.397.1542362721262; Fri, 16 Nov 2018 02:05:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542362721; cv=none; d=google.com; s=arc-20160816; b=uByDNJvO3XEhjeCWFZhP90CQLTNKDwMF69l4aGntIMGWnFmAKeIdh6y6AAMVoBlv5Z MQzyrJNqPUb+qxN3laTfrsQNE2L/NWXg5BT6YeO/lf4E4vByNu2pYcUMXLD96BrpuMii J6Q8L+XN1koxEyd43o5Fns/Kv7ImRSZQiYz2VEJ+NzlYaCBArMi8uWtYF5+UEiNb9Z4f PS7nhPYF2IDK0YFboN/+EogIHY2INyxitYig5mesYFx8aL8Nlxyd8Ip/pqqhO06su4Sn 6n1xuxSTNigs6Lx8WePzH4Dp/5Au3vE9E64aF1koOUJSOGA4bsjvokMA7E/TbYlJNn7h U6Mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=HuDFUrU28J59C1sp5glUdfijZEsUqR6FAQUgWuELHt4=; b=yu9xo3VBCRrxuv9RIlyFXHtcHwIVhz5i4o4Yvw6wFlIhIQ7AXP62hzzu8RxhWlCsDQ hGGG1eZpI4EkzDNJneTz8BwuDlFkfaVyibIZ0wY7KOVnzYLb8gnByi+iorStc2IP+B62 WUMIcTbBbf5QCTGrCoiPP7aXI3sPrilSxfBGQ3ZVCyi8u1t3oU9suEAQvqCfMOaCGnxG ubIKxuSfLkpZ2IxwKMSLwb02Ke3TQN2tpCUCzchaf1a8Y2Fd3Bco1pjw1xTHY7YywjMN /CEuKdctQDkOwhrBzHt2/JkCWMfXFc5qRqgov2wH1pbG0AAXzJiRwM7bMq4960m2uTAu zI8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HqdsL4I1; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n7-v6si30266122plp.43.2018.11.16.02.05.21; Fri, 16 Nov 2018 02:05:21 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HqdsL4I1; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389553AbeKPUQ5 (ORCPT + 6 others); Fri, 16 Nov 2018 15:16:57 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:44371 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389548AbeKPUQ5 (ORCPT ); Fri, 16 Nov 2018 15:16:57 -0500 Received: by mail-pf1-f196.google.com with SMTP id b81-v6so10682865pfe.11 for ; Fri, 16 Nov 2018 02:05:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HuDFUrU28J59C1sp5glUdfijZEsUqR6FAQUgWuELHt4=; b=HqdsL4I1tJ9nEYhjZeVAExIPh2XFK7J0bCcMgpeAYiWvOIi27WouWHqsYtCaJ6z1hc wqGYfgkJxX3PX1+58Oxj5bzXZw9PFuBmVpMxJ7dM1H9AOyc/KI9HoqAQM5e9bc3xWZOz TodNwflfBk/2lqobqd23l3p6RBUKVucHrA3ho= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HuDFUrU28J59C1sp5glUdfijZEsUqR6FAQUgWuELHt4=; b=IKKpwBj5xf6LJIisOFDkPwP9iDNTcRaHKTjXAXoC11ME/VvUn/ITM3hzNWwb9GsDml 2IwUdFBM7Qpn2lDKyrdAD+cb/yYpRu5Tx0mwxqE4dgY3fn7proyN9HOhr3ks5YyTvt+r khG0eIvtp9vIsptnV5V2GtlbmHmuPy88G08ThzMYmPmkZwOGWDWnCvDBUhxqV1VZlQzf uFEdSHUxse36lFWTImtkChjRe7oraW7xU/RVywz5tMLTLiR5oqgdjdmtmFE3Ljov9Q1v w4tPoM60L5hSJfnCsqmx8hbz4SkrysF6Cx/JRi2sS083nINaU4+FylreH0lkOffcedlj 6I+g== X-Gm-Message-State: AGRZ1gJPjRlJtMuTK4ooM1QhQNwzFTweFuhrcXscMTcglAotMsOZqJp4 4NBNBdaz6yfW+Ja3KtMx7f4dsQ== X-Received: by 2002:a63:82c6:: with SMTP id w189mr9454796pgd.344.1542362719182; Fri, 16 Nov 2018 02:05:19 -0800 (PST) Received: from localhost ([122.172.88.116]) by smtp.gmail.com with ESMTPSA id t26-v6sm48373412pfa.158.2018.11.16.02.05.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Nov 2018 02:05:18 -0800 (PST) From: Viresh Kumar To: Mark Rutland , Rob Herring , arm@kernel.org, Andy Gross , David Brown Cc: Viresh Kumar , devicetree@vger.kernel.org, Vincent Guittot , Daniel Lezcano , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 07/10] ARM64: dts: msm8916: Add all CPUs in cooling maps Date: Fri, 16 Nov 2018 15:34:30 +0530 Message-Id: <01bb903b2febf4b006f28fad33308cc8084ccbaf.1542362530.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.19.1.568.g152ad8e3369a In-Reply-To: References: MIME-Version: 1.0 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Each CPU can (and does) participate in cooling down the system but the DT only captures a handful of them, normally CPU0, in the cooling maps. Things work by chance currently as under normal circumstances its the first CPU of each cluster which is used by the operating systems to probe the cooling devices. But as soon as this CPU ordering changes and any other CPU is used to bring up the cooling device, we will start seeing failures. Also the DT is rather incomplete when we list only one CPU in the cooling maps, as the hardware doesn't have any such limitations. Update cooling maps to include all devices affected by individual trip points. Signed-off-by: Viresh Kumar --- arch/arm64/boot/dts/qcom/msm8916.dtsi | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) -- 2.19.1.568.g152ad8e3369a diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi index d302d8d639a1..482e275f0a03 100644 --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi @@ -202,7 +202,10 @@ cooling-maps { map0 { trip = <&cpu_alert0>; - cooling-device = <&CPU0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; + cooling-device = <&CPU0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&CPU1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&CPU2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&CPU3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; }; }; }; @@ -229,7 +232,10 @@ cooling-maps { map0 { trip = <&cpu_alert1>; - cooling-device = <&CPU0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; + cooling-device = <&CPU0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&CPU1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&CPU2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&CPU3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; }; }; };