[1/6] power: supply: charger-manager: Remove unused index counting

Message ID 4ea9eaf85d780afb190cb45da2df8ff5fd86d449.1542362262.git.baolin.wang@linaro.org
State New
Headers show
Series
  • [1/6] power: supply: charger-manager: Remove unused index counting
Related show

Commit Message

Baolin Wang Nov. 16, 2018, 11:01 a.m.
Remove unused index counting.

Signed-off-by: Baolin Wang <baolin.wang@linaro.org>

---
 drivers/power/supply/charger-manager.c |    4 ----
 1 file changed, 4 deletions(-)

-- 
1.7.9.5

Comments

Sebastian Reichel Dec. 5, 2018, 8:35 p.m. | #1
Hi,

On Fri, Nov 16, 2018 at 07:01:08PM +0800, Baolin Wang wrote:
> Remove unused index counting.

> 

> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>

> ---


Thanks, queued.

-- Sebastian

>  drivers/power/supply/charger-manager.c |    4 ----

>  1 file changed, 4 deletions(-)

> 

> diff --git a/drivers/power/supply/charger-manager.c b/drivers/power/supply/charger-manager.c

> index faa1a67..a1b420a 100644

> --- a/drivers/power/supply/charger-manager.c

> +++ b/drivers/power/supply/charger-manager.c

> @@ -1687,10 +1687,6 @@ static int charger_manager_probe(struct platform_device *pdev)

>  		return -EINVAL;

>  	}

>  

> -	/* Counting index only */

> -	while (desc->psy_charger_stat[i])

> -		i++;

> -

>  	/* Check if charger's supplies are present at probe */

>  	for (i = 0; desc->psy_charger_stat[i]; i++) {

>  		struct power_supply *psy;

> -- 

> 1.7.9.5

>
Sebastian Reichel Dec. 5, 2018, 8:36 p.m. | #2
Hi,

On Fri, Nov 16, 2018 at 07:01:09PM +0800, Baolin Wang wrote:
> Fix some misspelled words.

> 

> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>

> ---


Thanks, queued.

-- Sebastian

>  drivers/power/supply/charger-manager.c |    6 +++---

>  1 file changed, 3 insertions(+), 3 deletions(-)

> 

> diff --git a/drivers/power/supply/charger-manager.c b/drivers/power/supply/charger-manager.c

> index a1b420a..bd6c450 100644

> --- a/drivers/power/supply/charger-manager.c

> +++ b/drivers/power/supply/charger-manager.c

> @@ -363,7 +363,7 @@ static int try_charger_enable(struct charger_manager *cm, bool enable)

>  	int err = 0, i;

>  	struct charger_desc *desc = cm->desc;

>  

> -	/* Ignore if it's redundent command */

> +	/* Ignore if it's redundant command */

>  	if (enable == cm->charger_enabled)

>  		return 0;

>  

> @@ -1799,7 +1799,7 @@ static int charger_manager_probe(struct platform_device *pdev)

>  

>  	/*

>  	 * Charger-manager is capable of waking up the systme from sleep

> -	 * when event is happend through cm_notify_event()

> +	 * when event is happened through cm_notify_event()

>  	 */

>  	device_init_wakeup(&pdev->dev, true);

>  	device_set_wakeup_capable(&pdev->dev, false);

> @@ -2019,7 +2019,7 @@ static void __exit charger_manager_cleanup(void)

>   * cm_notify_event - charger driver notify Charger Manager of charger event

>   * @psy: pointer to instance of charger's power_supply

>   * @type: type of charger event

> - * @msg: optional message passed to uevent_notify fuction

> + * @msg: optional message passed to uevent_notify function

>   */

>  void cm_notify_event(struct power_supply *psy, enum cm_event_types type,

>  		     char *msg)

> -- 

> 1.7.9.5

>

Patch

diff --git a/drivers/power/supply/charger-manager.c b/drivers/power/supply/charger-manager.c
index faa1a67..a1b420a 100644
--- a/drivers/power/supply/charger-manager.c
+++ b/drivers/power/supply/charger-manager.c
@@ -1687,10 +1687,6 @@  static int charger_manager_probe(struct platform_device *pdev)
 		return -EINVAL;
 	}
 
-	/* Counting index only */
-	while (desc->psy_charger_stat[i])
-		i++;
-
 	/* Check if charger's supplies are present at probe */
 	for (i = 0; desc->psy_charger_stat[i]; i++) {
 		struct power_supply *psy;