[RFC,1/3] log: add TQS log type

Message ID 20181122033055.3431-2-honnappa.nagarahalli@arm.com
State New
Headers show
Series
  • tqs: add thread quiescent state library
Related show

Commit Message

Honnappa Nagarahalli Nov. 22, 2018, 3:30 a.m.
Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>

Reviewed-by: Steve Capper <steve.capper@arm.com>

Reviewed-by: Gavin Hu <gavin.hu@arm.com>

---
 lib/librte_eal/common/include/rte_log.h | 1 +
 1 file changed, 1 insertion(+)

-- 
2.17.1

Comments

Stephen Hemminger Nov. 27, 2018, 10:24 p.m. | #1
On Wed, 21 Nov 2018 21:30:53 -0600
Honnappa Nagarahalli <honnappa.nagarahalli@arm.com> wrote:

> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>

> Reviewed-by: Steve Capper <steve.capper@arm.com>

> Reviewed-by: Gavin Hu <gavin.hu@arm.com>

> ---

>  lib/librte_eal/common/include/rte_log.h | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/lib/librte_eal/common/include/rte_log.h b/lib/librte_eal/common/include/rte_log.h

> index 2f789cb90..b4e91a4a5 100644

> --- a/lib/librte_eal/common/include/rte_log.h

> +++ b/lib/librte_eal/common/include/rte_log.h

> @@ -61,6 +61,7 @@ extern struct rte_logs rte_logs;

>  #define RTE_LOGTYPE_EFD       18 /**< Log related to EFD. */

>  #define RTE_LOGTYPE_EVENTDEV  19 /**< Log related to eventdev. */

>  #define RTE_LOGTYPE_GSO       20 /**< Log related to GSO. */

> +#define RTE_LOGTYPE_TQS       21 /**< Log related to Thread Quiescent State. */

>  

>  /* these log types can be used in an application */

>  #define RTE_LOGTYPE_USER1     24 /**< User-defined log type 1. */


Sorry, I don't think this is the right way now.

All new logging should be using dynamic log types.
We should work on getting rid of others (EFD, EVENTDEV, GSO).
Honnappa Nagarahalli Nov. 28, 2018, 5:58 a.m. | #2
> 

> On Wed, 21 Nov 2018 21:30:53 -0600

> Honnappa Nagarahalli <honnappa.nagarahalli@arm.com> wrote:

> 

> > Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>

> > Reviewed-by: Steve Capper <steve.capper@arm.com>

> > Reviewed-by: Gavin Hu <gavin.hu@arm.com>

> > ---

> >  lib/librte_eal/common/include/rte_log.h | 1 +

> >  1 file changed, 1 insertion(+)

> >

> > diff --git a/lib/librte_eal/common/include/rte_log.h

> b/lib/librte_eal/common/include/rte_log.h

> > index 2f789cb90..b4e91a4a5 100644

> > --- a/lib/librte_eal/common/include/rte_log.h

> > +++ b/lib/librte_eal/common/include/rte_log.h

> > @@ -61,6 +61,7 @@ extern struct rte_logs rte_logs;

> >  #define RTE_LOGTYPE_EFD       18 /**< Log related to EFD. */

> >  #define RTE_LOGTYPE_EVENTDEV  19 /**< Log related to eventdev. */

> >  #define RTE_LOGTYPE_GSO       20 /**< Log related to GSO. */

> > +#define RTE_LOGTYPE_TQS       21 /**< Log related to Thread Quiescent State.

> */

> >

> >  /* these log types can be used in an application */

> >  #define RTE_LOGTYPE_USER1     24 /**< User-defined log type 1. */

> 

> Sorry, I don't think this is the right way now.

Ok. I see some examples for the libraries already. I will change it in next version.

> 

> All new logging should be using dynamic log types.

> We should work on getting rid of others (EFD, EVENTDEV, GSO).

Patch

diff --git a/lib/librte_eal/common/include/rte_log.h b/lib/librte_eal/common/include/rte_log.h
index 2f789cb90..b4e91a4a5 100644
--- a/lib/librte_eal/common/include/rte_log.h
+++ b/lib/librte_eal/common/include/rte_log.h
@@ -61,6 +61,7 @@  extern struct rte_logs rte_logs;
 #define RTE_LOGTYPE_EFD       18 /**< Log related to EFD. */
 #define RTE_LOGTYPE_EVENTDEV  19 /**< Log related to eventdev. */
 #define RTE_LOGTYPE_GSO       20 /**< Log related to GSO. */
+#define RTE_LOGTYPE_TQS       21 /**< Log related to Thread Quiescent State. */
 
 /* these log types can be used in an application */
 #define RTE_LOGTYPE_USER1     24 /**< User-defined log type 1. */