[edk2] Platform/Comcast: drop bogus BdsLib.h include

Message ID 20181123185321.2787-1-ard.biesheuvel@linaro.org
State New
Headers show
Series
  • [edk2] Platform/Comcast: drop bogus BdsLib.h include
Related show

Commit Message

Ard Biesheuvel Nov. 23, 2018, 6:53 p.m.
RdkBootManagerLib/RdkBootManagerLib.h includes BdsLib.h from ArmPkg
but does not actually depend on it. So drop the #include.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

---
 Platform/Comcast/Library/RdkBootManagerLib/RdkBootManagerLib.h | 1 -
 1 file changed, 1 deletion(-)

-- 
2.19.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Leif Lindholm Nov. 26, 2018, 3:11 p.m. | #1
On Fri, Nov 23, 2018 at 07:53:21PM +0100, Ard Biesheuvel wrote:
> RdkBootManagerLib/RdkBootManagerLib.h includes BdsLib.h from ArmPkg

> but does not actually depend on it. So drop the #include.

> 

> Contributed-under: TianoCore Contribution Agreement 1.1

> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>


Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>


> ---

>  Platform/Comcast/Library/RdkBootManagerLib/RdkBootManagerLib.h | 1 -

>  1 file changed, 1 deletion(-)

> 

> diff --git a/Platform/Comcast/Library/RdkBootManagerLib/RdkBootManagerLib.h b/Platform/Comcast/Library/RdkBootManagerLib/RdkBootManagerLib.h

> index 9d6e7dd1b677..6a18e95c1ced 100644

> --- a/Platform/Comcast/Library/RdkBootManagerLib/RdkBootManagerLib.h

> +++ b/Platform/Comcast/Library/RdkBootManagerLib/RdkBootManagerLib.h

> @@ -13,7 +13,6 @@

>  #ifndef __RDK_BOOT_MANAGER_LIB_H__

>  #define __RDK_BOOT_MANAGER_LIB_H__

>  

> -#include <Library/BdsLib.h>

>  #include <Library/UefiLib.h>

>  #include <Library/BaseLib.h>

>  #include <Library/DebugLib.h>

> -- 

> 2.19.1

> 

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patch

diff --git a/Platform/Comcast/Library/RdkBootManagerLib/RdkBootManagerLib.h b/Platform/Comcast/Library/RdkBootManagerLib/RdkBootManagerLib.h
index 9d6e7dd1b677..6a18e95c1ced 100644
--- a/Platform/Comcast/Library/RdkBootManagerLib/RdkBootManagerLib.h
+++ b/Platform/Comcast/Library/RdkBootManagerLib/RdkBootManagerLib.h
@@ -13,7 +13,6 @@ 
 #ifndef __RDK_BOOT_MANAGER_LIB_H__
 #define __RDK_BOOT_MANAGER_LIB_H__
 
-#include <Library/BdsLib.h>
 #include <Library/UefiLib.h>
 #include <Library/BaseLib.h>
 #include <Library/DebugLib.h>