From patchwork Wed Nov 28 05:38:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 152191 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp692475ljp; Tue, 27 Nov 2018 21:48:23 -0800 (PST) X-Google-Smtp-Source: AJdET5fyMueCdkWoGZm6M3S13jPktQWgX8CYRIZDeqIFklAVx82omXHdkr/Ksf2vkuwaw6UW+WhC X-Received: by 2002:a81:9ad5:: with SMTP id r204mr36636599ywg.215.1543384103691; Tue, 27 Nov 2018 21:48:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543384103; cv=none; d=google.com; s=arc-20160816; b=Ih7a7RQubva+5FvDyyObZNfWZ/EyKV+daQ3QLBnteo2hihU7rErdphDXkGApKH7jaN eedJ5mdPbOVZn4NotEzyJEc/EysPrkQ5Om3n0XXQWFeaUXLvDmU1zNPxTzuodn8Yr7/n Y6Ua7fc23yGTJA5Qy5fdk1Ts/TbLhJSJwJYwiK5xOUmmrQU8VKajRcA6hdYHQbOoNhPY y1IXC3zU4s1sC7SwuGrjfn6CzchHEZQjkE8C6pkIwRPcsosBtJAEDptaHC9HQYWRg7nN nwM0C90wyb67AoNV9nleVaAaQndidn5wbotngrTT/spGa2+jtqqspAa0QvzxhQu5KM0O h9+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=l5Q1tbJR9WcMsBqUTZQX9ofdmMJFwTlSDLTXSU4uz0U=; b=AETf0MpZO26PgzeBxib9R2+ZTl8V71a1+1mmzFX7fMaDaexkxz8FC6gWyrnK8Wx+Zd 0CTz3/IlHV575SnpODB8KzfcZ0x1PmOVjkirgAnMt8RtU9t0f/s2R94xKGyErCh/6bs+ COjsXepIc3jdtvJaOUBKr1fmOVzzYp21QaYh7ImE9afINmQ/mrQGhZpUj5XGYvVH0//Q s0k/xEQD6ZtORtupfGGT65tQu+rvx+W03/Buo0Ls+4hqeERz6PsD36vUta9Le+8d9nmF aNKj0EDnwwMqPbJ+CZFFwHNNcTjIyOjdZXdZlYhsrYyJ1AqAzSTsb1b8Jqd1rHAl7uoV pN7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=gGrebFdU; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id 185si2838269ywa.37.2018.11.27.21.48.23 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 27 Nov 2018 21:48:23 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=gGrebFdU; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:46077 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRshz-0005PA-0v for patch@linaro.org; Wed, 28 Nov 2018 00:48:23 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47985) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRsYl-000415-RZ for qemu-devel@nongnu.org; Wed, 28 Nov 2018 00:38:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRsYi-0004N5-T8 for qemu-devel@nongnu.org; Wed, 28 Nov 2018 00:38:51 -0500 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]:34803) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gRsYi-0004MH-N2 for qemu-devel@nongnu.org; Wed, 28 Nov 2018 00:38:48 -0500 Received: by mail-pl1-x643.google.com with SMTP id f12-v6so16824726plo.1 for ; Tue, 27 Nov 2018 21:38:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=l5Q1tbJR9WcMsBqUTZQX9ofdmMJFwTlSDLTXSU4uz0U=; b=gGrebFdUGIeqKB+0INeGeoxsV5xwHFuYasUKX3bg1caBu+KA51O8ki8wUonqKMyeFS 6uD5zq8VGCIFunAarKAlM7/JfNhPE/n3n3huFR6XH1weu2+/eMxQmB8guJxm2t9LLQKS yMq8U05rzo29gxV73zQ83R5XWyuidj1vmeZz8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=l5Q1tbJR9WcMsBqUTZQX9ofdmMJFwTlSDLTXSU4uz0U=; b=d3+ivxTVWBo0qWhKiLs+0jDP+Uw88pHQEx6LYeQ0Ddqtk1HmhNtS+wkvqWeAOYmhaw LYOpfv+p1zE262qCF6TL38UAzirzR+CSV70xzX1CsAIpWDFZ1DDflWP0ibTi5MeJ/4GP cHwhqrMBf34BWVfMJA0X+n8S0Z4G4H1KFx3nTs6cU6ChROOUgXESneyRCF5TKE2tZa2/ UA0vqjEaPgnniBhK/BsFx3OhzBLy6x355swBdmPRHdGDcdvI4+ydIoG4l1aOWx3MOZPG RMQ0XCpxg0060iMS3sh6lb//vRgupLESfe7z+WPhmwmuN5C+5lEgr+eUoOEZw6Y9sVJJ PWzg== X-Gm-Message-State: AA+aEWZprC8SJ0bpVFcHKM/Qw3IWokfVLB9DVkqp2eW7bMftvEeQAcIt xvjYYudqda7lokE4HDh2eSIREqQlle4= X-Received: by 2002:a17:902:f082:: with SMTP id go2mr35602521plb.115.1543383527408; Tue, 27 Nov 2018 21:38:47 -0800 (PST) Received: from cloudburst.twiddle.net (97-113-170-180.tukw.qwest.net. [97.113.170.180]) by smtp.gmail.com with ESMTPSA id 19sm8569336pfs.108.2018.11.27.21.38.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 27 Nov 2018 21:38:46 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Tue, 27 Nov 2018 21:38:31 -0800 Message-Id: <20181128053834.10861-10-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20181128053834.10861-1-richard.henderson@linaro.org> References: <20181128053834.10861-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::643 Subject: [Qemu-devel] [PATCH 09/12] tcg: Rename and adjust liveness_pass_1 helpers X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: cota@braap.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" No need for a "tcg_" prefix for a static function; we already have another "la_" prefix for indicating liveness analysis. Pass in nb_globals and nb_temps, as we will already have them in registers for other loops within the parent function. Signed-off-by: Richard Henderson --- tcg/tcg.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) -- 2.17.2 diff --git a/tcg/tcg.c b/tcg/tcg.c index 82f9a66d31..27814df882 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -2389,10 +2389,8 @@ static void reachable_code_pass(TCGContext *s) /* liveness analysis: end of function: all temps are dead, and globals should be in memory. */ -static void tcg_la_func_end(TCGContext *s) +static void la_func_end(TCGContext *s, int ng, int nt) { - int ng = s->nb_globals; - int nt = s->nb_temps; int i; for (i = 0; i < ng; ++i) { @@ -2405,10 +2403,8 @@ static void tcg_la_func_end(TCGContext *s) /* liveness analysis: end of basic block: all temps are dead, globals and local temps should be in memory. */ -static void tcg_la_bb_end(TCGContext *s) +static void la_bb_end(TCGContext *s, int ng, int nt) { - int ng = s->nb_globals; - int nt = s->nb_temps; int i; for (i = 0; i < ng; ++i) { @@ -2427,9 +2423,10 @@ static void tcg_la_bb_end(TCGContext *s) static void liveness_pass_1(TCGContext *s) { int nb_globals = s->nb_globals; + int nb_temps = s->nb_temps; TCGOp *op, *op_prev; - tcg_la_func_end(s); + la_func_end(s, nb_globals, nb_temps); QTAILQ_FOREACH_REVERSE_SAFE(op, &s->ops, TCGOpHead, link, op_prev) { int i, nb_iargs, nb_oargs; @@ -2624,7 +2621,7 @@ static void liveness_pass_1(TCGContext *s) /* if end of basic block, update */ if (def->flags & TCG_OPF_BB_END) { - tcg_la_bb_end(s); + la_bb_end(s, nb_globals, nb_temps); } else if (def->flags & TCG_OPF_SIDE_EFFECTS) { /* globals should be synced to memory */ for (i = 0; i < nb_globals; i++) {