[4/4] efi_loader: bootmgr: make BootNext non-volatile

Message ID 20181128060059.5508-5-takahiro.akashi@linaro.org
State New
Headers show
Series
  • efi_loader: non-volatile variables support
Related show

Commit Message

AKASHI Takahiro Nov. 28, 2018, 6 a.m.
See UEFI specification v2.7a, section 3.3 for details attributes.

Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
---
 lib/efi_loader/efi_bootmgr.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Heinrich Schuchardt Dec. 11, 2018, 7:07 p.m. | #1
On 11/28/18 7:00 AM, AKASHI Takahiro wrote:
> See UEFI specification v2.7a, section 3.3 for details attributes.

This patch is not applicable to U-Boot master not to efi-next. There is
no preceding patch in
https://patchwork.ozlabs.org/project/uboot/list/?submitter=61166

I have no clue what this patch is based on.

Best regards

Heinrich

> 
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> ---
>  lib/efi_loader/efi_bootmgr.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/efi_loader/efi_bootmgr.c b/lib/efi_loader/efi_bootmgr.c
> index db391147fb2d..128d1e887cb4 100644
> --- a/lib/efi_loader/efi_bootmgr.c
> +++ b/lib/efi_loader/efi_bootmgr.c
> @@ -210,7 +210,8 @@ void *efi_bootmgr_load(int boot_id,
>  	if (!bootnext)
>  		goto run_list;
>  
> -	attributes = EFI_VARIABLE_BOOTSERVICE_ACCESS |
> +	attributes = EFI_VARIABLE_NON_VOLATILE |
> +		     EFI_VARIABLE_BOOTSERVICE_ACCESS |
>  		     EFI_VARIABLE_RUNTIME_ACCESS;
>  	size = 0;
>  	ret = rs->set_variable(L"BootNext",
>

Patch

diff --git a/lib/efi_loader/efi_bootmgr.c b/lib/efi_loader/efi_bootmgr.c
index db391147fb2d..128d1e887cb4 100644
--- a/lib/efi_loader/efi_bootmgr.c
+++ b/lib/efi_loader/efi_bootmgr.c
@@ -210,7 +210,8 @@  void *efi_bootmgr_load(int boot_id,
 	if (!bootnext)
 		goto run_list;
 
-	attributes = EFI_VARIABLE_BOOTSERVICE_ACCESS |
+	attributes = EFI_VARIABLE_NON_VOLATILE |
+		     EFI_VARIABLE_BOOTSERVICE_ACCESS |
 		     EFI_VARIABLE_RUNTIME_ACCESS;
 	size = 0;
 	ret = rs->set_variable(L"BootNext",