[edk2,v3,02/16] EmbeddedPkg/PrePiHobLib: drop CreateHobList() from library

Message ID 20181128143357.991-3-ard.biesheuvel@linaro.org
State New
Headers show
Series
  • Pkg: lift 40-bit IPA space limit
Related show

Commit Message

Ard Biesheuvel Nov. 28, 2018, 2:33 p.m.
Drop the declaration and the implementation of CreateHoblist(),
which is not used anywhere.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

---
 EmbeddedPkg/Include/Library/PrePiLib.h | 18 ---------
 EmbeddedPkg/Library/PrePiHobLib/Hob.c  | 41 --------------------
 2 files changed, 59 deletions(-)

-- 
2.19.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Laszlo Ersek Nov. 28, 2018, 5:58 p.m. | #1
On 11/28/18 15:33, Ard Biesheuvel wrote:
> Drop the declaration and the implementation of CreateHoblist(),

> which is not used anywhere.

> 

> Contributed-under: TianoCore Contribution Agreement 1.1

> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---

>  EmbeddedPkg/Include/Library/PrePiLib.h | 18 ---------

>  EmbeddedPkg/Library/PrePiHobLib/Hob.c  | 41 --------------------

>  2 files changed, 59 deletions(-)

> 

> diff --git a/EmbeddedPkg/Include/Library/PrePiLib.h b/EmbeddedPkg/Include/Library/PrePiLib.h

> index cf70fca3b619..a857308ecec2 100644

> --- a/EmbeddedPkg/Include/Library/PrePiLib.h

> +++ b/EmbeddedPkg/Include/Library/PrePiLib.h

> @@ -274,24 +274,6 @@ HobConstructor (

>    IN VOID   *EfiFreeMemoryTop

>    );

>  

> -/**

> -  Retrieves the magic value from the PE/COFF header.

> -

> -  @param  Hdr             The buffer in which to return the PE32, PE32+, or TE header.

> -

> -  @return EFI_IMAGE_NT_OPTIONAL_HDR32_MAGIC - Image is PE32

> -  @return EFI_IMAGE_NT_OPTIONAL_HDR64_MAGIC - Image is PE32+

> -

> -**/

> -VOID

> -CreateHobList (

> -  IN VOID   *MemoryBegin,

> -  IN UINTN  MemoryLength,

> -  IN VOID   *HobBase,

> -  IN VOID   *StackBase

> -  );

> -

> -

>  /**

>    This service enables PEIMs to create various types of HOBs.

>  

> diff --git a/EmbeddedPkg/Library/PrePiHobLib/Hob.c b/EmbeddedPkg/Library/PrePiHobLib/Hob.c

> index aff8ea05797b..ba16899a9184 100644

> --- a/EmbeddedPkg/Library/PrePiHobLib/Hob.c

> +++ b/EmbeddedPkg/Library/PrePiHobLib/Hob.c

> @@ -175,47 +175,6 @@ BuildResourceDescriptorHob (

>    Hob->ResourceLength    = NumberOfBytes;

>  }

>  

> -/**

> -

> -

> -**/

> -VOID

> -CreateHobList (

> -  IN VOID   *MemoryBegin,

> -  IN UINTN  MemoryLength,

> -  IN VOID   *HobBase,

> -  IN VOID   *StackBase

> -  )

> -{

> -  EFI_HOB_HANDOFF_INFO_TABLE  *Hob;

> -  EFI_RESOURCE_ATTRIBUTE_TYPE Attributes;

> -

> -  Hob = HobConstructor (MemoryBegin,MemoryLength,HobBase,StackBase);

> -  SetHobList (Hob);

> -

> -  BuildCpuHob (PcdGet8 (PcdPrePiCpuMemorySize), PcdGet8 (PcdPrePiCpuIoSize));

> -

> -  Attributes =(

> -    EFI_RESOURCE_ATTRIBUTE_PRESENT |

> -    EFI_RESOURCE_ATTRIBUTE_INITIALIZED |

> -    EFI_RESOURCE_ATTRIBUTE_TESTED |

> -    EFI_RESOURCE_ATTRIBUTE_UNCACHEABLE |

> -    EFI_RESOURCE_ATTRIBUTE_WRITE_COMBINEABLE |

> -    EFI_RESOURCE_ATTRIBUTE_WRITE_THROUGH_CACHEABLE |

> -    EFI_RESOURCE_ATTRIBUTE_WRITE_BACK_CACHEABLE

> -  );

> -

> -  BuildResourceDescriptorHob (EFI_RESOURCE_SYSTEM_MEMORY, Attributes, (UINTN)MemoryBegin, MemoryLength);

> -

> -  BuildStackHob ((EFI_PHYSICAL_ADDRESS)(UINTN)StackBase, ((UINTN)MemoryBegin + MemoryLength) - (UINTN)StackBase);

> -

> -  if (FeaturePcdGet (PcdPrePiProduceMemoryTypeInformationHob)) {

> -    // Optional feature that helps prevent EFI memory map fragmentation.

> -    BuildMemoryTypeInformationHob ();

> -  }

> -}

> -

> -

>  VOID

>  EFIAPI

>  BuildFvHobs (

> 


Reviewed-by: Laszlo Ersek <lersek@redhat.com>

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Leif Lindholm Nov. 29, 2018, 3:40 p.m. | #2
On Wed, Nov 28, 2018 at 03:33:43PM +0100, Ard Biesheuvel wrote:
> Drop the declaration and the implementation of CreateHoblist(),

> which is not used anywhere.

> 

> Contributed-under: TianoCore Contribution Agreement 1.1

> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>


Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>


> ---

>  EmbeddedPkg/Include/Library/PrePiLib.h | 18 ---------

>  EmbeddedPkg/Library/PrePiHobLib/Hob.c  | 41 --------------------

>  2 files changed, 59 deletions(-)

> 

> diff --git a/EmbeddedPkg/Include/Library/PrePiLib.h b/EmbeddedPkg/Include/Library/PrePiLib.h

> index cf70fca3b619..a857308ecec2 100644

> --- a/EmbeddedPkg/Include/Library/PrePiLib.h

> +++ b/EmbeddedPkg/Include/Library/PrePiLib.h

> @@ -274,24 +274,6 @@ HobConstructor (

>    IN VOID   *EfiFreeMemoryTop

>    );

>  

> -/**

> -  Retrieves the magic value from the PE/COFF header.

> -

> -  @param  Hdr             The buffer in which to return the PE32, PE32+, or TE header.

> -

> -  @return EFI_IMAGE_NT_OPTIONAL_HDR32_MAGIC - Image is PE32

> -  @return EFI_IMAGE_NT_OPTIONAL_HDR64_MAGIC - Image is PE32+

> -

> -**/

> -VOID

> -CreateHobList (

> -  IN VOID   *MemoryBegin,

> -  IN UINTN  MemoryLength,

> -  IN VOID   *HobBase,

> -  IN VOID   *StackBase

> -  );

> -

> -

>  /**

>    This service enables PEIMs to create various types of HOBs.

>  

> diff --git a/EmbeddedPkg/Library/PrePiHobLib/Hob.c b/EmbeddedPkg/Library/PrePiHobLib/Hob.c

> index aff8ea05797b..ba16899a9184 100644

> --- a/EmbeddedPkg/Library/PrePiHobLib/Hob.c

> +++ b/EmbeddedPkg/Library/PrePiHobLib/Hob.c

> @@ -175,47 +175,6 @@ BuildResourceDescriptorHob (

>    Hob->ResourceLength    = NumberOfBytes;

>  }

>  

> -/**

> -

> -

> -**/

> -VOID

> -CreateHobList (

> -  IN VOID   *MemoryBegin,

> -  IN UINTN  MemoryLength,

> -  IN VOID   *HobBase,

> -  IN VOID   *StackBase

> -  )

> -{

> -  EFI_HOB_HANDOFF_INFO_TABLE  *Hob;

> -  EFI_RESOURCE_ATTRIBUTE_TYPE Attributes;

> -

> -  Hob = HobConstructor (MemoryBegin,MemoryLength,HobBase,StackBase);

> -  SetHobList (Hob);

> -

> -  BuildCpuHob (PcdGet8 (PcdPrePiCpuMemorySize), PcdGet8 (PcdPrePiCpuIoSize));

> -

> -  Attributes =(

> -    EFI_RESOURCE_ATTRIBUTE_PRESENT |

> -    EFI_RESOURCE_ATTRIBUTE_INITIALIZED |

> -    EFI_RESOURCE_ATTRIBUTE_TESTED |

> -    EFI_RESOURCE_ATTRIBUTE_UNCACHEABLE |

> -    EFI_RESOURCE_ATTRIBUTE_WRITE_COMBINEABLE |

> -    EFI_RESOURCE_ATTRIBUTE_WRITE_THROUGH_CACHEABLE |

> -    EFI_RESOURCE_ATTRIBUTE_WRITE_BACK_CACHEABLE

> -  );

> -

> -  BuildResourceDescriptorHob (EFI_RESOURCE_SYSTEM_MEMORY, Attributes, (UINTN)MemoryBegin, MemoryLength);

> -

> -  BuildStackHob ((EFI_PHYSICAL_ADDRESS)(UINTN)StackBase, ((UINTN)MemoryBegin + MemoryLength) - (UINTN)StackBase);

> -

> -  if (FeaturePcdGet (PcdPrePiProduceMemoryTypeInformationHob)) {

> -    // Optional feature that helps prevent EFI memory map fragmentation.

> -    BuildMemoryTypeInformationHob ();

> -  }

> -}

> -

> -

>  VOID

>  EFIAPI

>  BuildFvHobs (

> -- 

> 2.19.1

> 

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patch

diff --git a/EmbeddedPkg/Include/Library/PrePiLib.h b/EmbeddedPkg/Include/Library/PrePiLib.h
index cf70fca3b619..a857308ecec2 100644
--- a/EmbeddedPkg/Include/Library/PrePiLib.h
+++ b/EmbeddedPkg/Include/Library/PrePiLib.h
@@ -274,24 +274,6 @@  HobConstructor (
   IN VOID   *EfiFreeMemoryTop
   );
 
-/**
-  Retrieves the magic value from the PE/COFF header.
-
-  @param  Hdr             The buffer in which to return the PE32, PE32+, or TE header.
-
-  @return EFI_IMAGE_NT_OPTIONAL_HDR32_MAGIC - Image is PE32
-  @return EFI_IMAGE_NT_OPTIONAL_HDR64_MAGIC - Image is PE32+
-
-**/
-VOID
-CreateHobList (
-  IN VOID   *MemoryBegin,
-  IN UINTN  MemoryLength,
-  IN VOID   *HobBase,
-  IN VOID   *StackBase
-  );
-
-
 /**
   This service enables PEIMs to create various types of HOBs.
 
diff --git a/EmbeddedPkg/Library/PrePiHobLib/Hob.c b/EmbeddedPkg/Library/PrePiHobLib/Hob.c
index aff8ea05797b..ba16899a9184 100644
--- a/EmbeddedPkg/Library/PrePiHobLib/Hob.c
+++ b/EmbeddedPkg/Library/PrePiHobLib/Hob.c
@@ -175,47 +175,6 @@  BuildResourceDescriptorHob (
   Hob->ResourceLength    = NumberOfBytes;
 }
 
-/**
-
-
-**/
-VOID
-CreateHobList (
-  IN VOID   *MemoryBegin,
-  IN UINTN  MemoryLength,
-  IN VOID   *HobBase,
-  IN VOID   *StackBase
-  )
-{
-  EFI_HOB_HANDOFF_INFO_TABLE  *Hob;
-  EFI_RESOURCE_ATTRIBUTE_TYPE Attributes;
-
-  Hob = HobConstructor (MemoryBegin,MemoryLength,HobBase,StackBase);
-  SetHobList (Hob);
-
-  BuildCpuHob (PcdGet8 (PcdPrePiCpuMemorySize), PcdGet8 (PcdPrePiCpuIoSize));
-
-  Attributes =(
-    EFI_RESOURCE_ATTRIBUTE_PRESENT |
-    EFI_RESOURCE_ATTRIBUTE_INITIALIZED |
-    EFI_RESOURCE_ATTRIBUTE_TESTED |
-    EFI_RESOURCE_ATTRIBUTE_UNCACHEABLE |
-    EFI_RESOURCE_ATTRIBUTE_WRITE_COMBINEABLE |
-    EFI_RESOURCE_ATTRIBUTE_WRITE_THROUGH_CACHEABLE |
-    EFI_RESOURCE_ATTRIBUTE_WRITE_BACK_CACHEABLE
-  );
-
-  BuildResourceDescriptorHob (EFI_RESOURCE_SYSTEM_MEMORY, Attributes, (UINTN)MemoryBegin, MemoryLength);
-
-  BuildStackHob ((EFI_PHYSICAL_ADDRESS)(UINTN)StackBase, ((UINTN)MemoryBegin + MemoryLength) - (UINTN)StackBase);
-
-  if (FeaturePcdGet (PcdPrePiProduceMemoryTypeInformationHob)) {
-    // Optional feature that helps prevent EFI memory map fragmentation.
-    BuildMemoryTypeInformationHob ();
-  }
-}
-
-
 VOID
 EFIAPI
 BuildFvHobs (