diff mbox series

[edk2,v3,15/16] ArmVirtPkg: drop PcdPrePiCpuMemorySize assignments from all platforms

Message ID 20181128143357.991-16-ard.biesheuvel@linaro.org
State Accepted
Commit 55342094fb861591a3883d718d94af097e787b1d
Headers show
Series Pkg: lift 40-bit IPA space limit | expand

Commit Message

Ard Biesheuvel Nov. 28, 2018, 2:33 p.m. UTC
PcdPrePiCpuMemorySize is no longer used so drop the PCD overrides
from all platform descriptions in ArmVirtPkg.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

---
 ArmVirtPkg/ArmVirt.dsc.inc       | 3 ---
 ArmVirtPkg/ArmVirtQemu.dsc       | 4 ----
 ArmVirtPkg/ArmVirtQemuKernel.dsc | 4 ----
 3 files changed, 11 deletions(-)

-- 
2.19.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Laszlo Ersek Nov. 28, 2018, 7:56 p.m. UTC | #1
On 11/28/18 15:33, Ard Biesheuvel wrote:
> PcdPrePiCpuMemorySize is no longer used so drop the PCD overrides

> from all platform descriptions in ArmVirtPkg.

> 

> Contributed-under: TianoCore Contribution Agreement 1.1

> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---

>  ArmVirtPkg/ArmVirt.dsc.inc       | 3 ---

>  ArmVirtPkg/ArmVirtQemu.dsc       | 4 ----

>  ArmVirtPkg/ArmVirtQemuKernel.dsc | 4 ----

>  3 files changed, 11 deletions(-)

> 

> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc

> index 70a0ac4d786c..fbdb5c982604 100644

> --- a/ArmVirtPkg/ArmVirt.dsc.inc

> +++ b/ArmVirtPkg/ArmVirt.dsc.inc

> @@ -388,9 +388,6 @@ [PcdsFixedAtBuild.common]

>    #

>    gEfiMdeModulePkgTokenSpaceGuid.PcdSetNxForStack|TRUE

>  

> -[PcdsFixedAtBuild.ARM]

> -  gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize|40

> -

>  [Components.common]

>    #

>    # Ramdisk support

> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc

> index 885c6b14b844..a107b6bb5104 100644

> --- a/ArmVirtPkg/ArmVirtQemu.dsc

> +++ b/ArmVirtPkg/ArmVirtQemu.dsc

> @@ -143,10 +143,6 @@ [PcdsFixedAtBuild.common]

>    gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize|16

>  

>  [PcdsFixedAtBuild.AARCH64]

> -  # KVM limits it IPA space to 40 bits (1 TB), so there is no need to

> -  # support anything bigger, even if the host hardware does

> -  gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize|40

> -

>    # Clearing BIT0 in this PCD prevents installing a 32-bit SMBIOS entry point,

>    # if the entry point version is >= 3.0. AARCH64 OSes cannot assume the

>    # presence of the 32-bit entry point anyway (because many AARCH64 systems

> diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc

> index 434d6861a56f..d8fbf14e8f4e 100644

> --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc

> +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc

> @@ -157,10 +157,6 @@ [PcdsFixedAtBuild.AARCH64]

>    #

>    gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize|16

>  

> -  # KVM limits it IPA space to 40 bits (1 TB), so there is no need to

> -  # support anything bigger, even if the host hardware does

> -  gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize|40

> -

>  [PcdsDynamicDefault.common]

>    gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|3

>  

> 


Reviewed-by: Laszlo Ersek <lersek@redhat.com>

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
diff mbox series

Patch

diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
index 70a0ac4d786c..fbdb5c982604 100644
--- a/ArmVirtPkg/ArmVirt.dsc.inc
+++ b/ArmVirtPkg/ArmVirt.dsc.inc
@@ -388,9 +388,6 @@  [PcdsFixedAtBuild.common]
   #
   gEfiMdeModulePkgTokenSpaceGuid.PcdSetNxForStack|TRUE
 
-[PcdsFixedAtBuild.ARM]
-  gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize|40
-
 [Components.common]
   #
   # Ramdisk support
diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc
index 885c6b14b844..a107b6bb5104 100644
--- a/ArmVirtPkg/ArmVirtQemu.dsc
+++ b/ArmVirtPkg/ArmVirtQemu.dsc
@@ -143,10 +143,6 @@  [PcdsFixedAtBuild.common]
   gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize|16
 
 [PcdsFixedAtBuild.AARCH64]
-  # KVM limits it IPA space to 40 bits (1 TB), so there is no need to
-  # support anything bigger, even if the host hardware does
-  gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize|40
-
   # Clearing BIT0 in this PCD prevents installing a 32-bit SMBIOS entry point,
   # if the entry point version is >= 3.0. AARCH64 OSes cannot assume the
   # presence of the 32-bit entry point anyway (because many AARCH64 systems
diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc
index 434d6861a56f..d8fbf14e8f4e 100644
--- a/ArmVirtPkg/ArmVirtQemuKernel.dsc
+++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc
@@ -157,10 +157,6 @@  [PcdsFixedAtBuild.AARCH64]
   #
   gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize|16
 
-  # KVM limits it IPA space to 40 bits (1 TB), so there is no need to
-  # support anything bigger, even if the host hardware does
-  gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize|40
-
 [PcdsDynamicDefault.common]
   gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|3