[2/3] dt-bindings: clk: meson: add main controller clock input

Message ID 20181129164524.18670-3-jbrunet@baylibre.com
State New
Headers show
Series
  • [1/3] dt-bindings: clk: meson: add ao controller clock inputs
Related show

Commit Message

Jerome Brunet Nov. 29, 2018, 4:45 p.m.
Add the clock input of the main clock controller

Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>

---
 Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt | 3 +++
 1 file changed, 3 insertions(+)

-- 
2.19.1

Comments

Stephen Boyd Nov. 29, 2018, 11:43 p.m. | #1
Quoting Jerome Brunet (2018-11-29 08:45:23)
> Add the clock input of the main clock controller

> 

> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>

> ---

>  Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt | 3 +++

>  1 file changed, 3 insertions(+)

> 

> diff --git a/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt b/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt

> index e950599566a9..79454869f96d 100644

> --- a/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt

> +++ b/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt

> @@ -9,6 +9,8 @@ Required Properties:

>                 "amlogic,gxbb-clkc" for GXBB SoC,

>                 "amlogic,gxl-clkc" for GXL and GXM SoC,

>                 "amlogic,axg-clkc" for AXG SoC.

> +- clocks: phandle to the input clock of the controller, presumably the

> +         platform xtal.


Any reason to not have clock-names? I'd prefer to have them because then
we can easily hook up providers with their parents based on strings. I
suppose we'll have to support both modes of strings and numbers for
connections, but that may be more for legacy reasons that could be
avoided here if a clock-names property existed.

>  

>  - #clock-cells: should be 1.

>
Jerome Brunet Nov. 30, 2018, 8:21 a.m. | #2
On Thu, 2018-11-29 at 15:43 -0800, Stephen Boyd wrote:
> Quoting Jerome Brunet (2018-11-29 08:45:23)

> > Add the clock input of the main clock controller

> > 

> > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>

> > ---

> >  Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt | 3 +++

> >  1 file changed, 3 insertions(+)

> > 

> > diff --git a/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt 

> > b/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt

> > index e950599566a9..79454869f96d 100644

> > --- a/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt

> > +++ b/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt

> > @@ -9,6 +9,8 @@ Required Properties:

> >                 "amlogic,gxbb-clkc" for GXBB SoC,

> >                 "amlogic,gxl-clkc" for GXL and GXM SoC,

> >                 "amlogic,axg-clkc" for AXG SoC.

> > +- clocks: phandle to the input clock of the controller, presumably the

> > +         platform xtal.

> 

> Any reason to not have clock-names? 


Not really, I did not bother because there was only one input clock.
I can easily fix this

> I'd prefer to have them because then

> we can easily hook up providers with their parents based on strings. I

> suppose we'll have to support both modes of strings and numbers for

> connections, but that may be more for legacy reasons that could be

> avoided here if a clock-names property existed.

> 

> >  

> >  - #clock-cells: should be 1.

> >

Patch

diff --git a/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt b/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt
index e950599566a9..79454869f96d 100644
--- a/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt
+++ b/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt
@@ -9,6 +9,8 @@  Required Properties:
 		"amlogic,gxbb-clkc" for GXBB SoC,
 		"amlogic,gxl-clkc" for GXL and GXM SoC,
 		"amlogic,axg-clkc" for AXG SoC.
+- clocks: phandle to the input clock of the controller, presumably the
+	  platform xtal.
 
 - #clock-cells: should be 1.
 
@@ -31,6 +33,7 @@  sysctrl: system-controller@0 {
 	clkc: clock-controller {
 		#clock-cells = <1>;
 		compatible = "amlogic,gxbb-clkc";
+		clocks = <&xtal>
 	};
 };