| Message ID | 1362491397-14562-2-git-send-email-gautam.vivek@samsung.com |
|---|---|
| State | Accepted |
| Commit | 7d1795840889b4f21fbfb4196119d0c923706a54 |
| Headers | show |
On Tue, Mar 5, 2013 at 5:49 AM, Vivek Gautam <gautam.vivek@samsung.com> wrote: > Enclosing process_nodes() and spi_get_config() inside > CONFIG_OF_CONTROL, since they are compiled only for DT systems. > > This fixes following warning: > exynos_spi.c:391:12: warning: 'process_nodes' defined but not used [-Wunused-function] > > Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com> Acked-by: Simon Glass <sjg@chromium.org> > --- > drivers/spi/exynos_spi.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/spi/exynos_spi.c b/drivers/spi/exynos_spi.c > index be60ada..2260d59 100644 > --- a/drivers/spi/exynos_spi.c > +++ b/drivers/spi/exynos_spi.c > @@ -360,6 +360,7 @@ static inline struct exynos_spi *get_spi_base(int dev_index) > * @param bus SPI bus structure to fill with information > * @return 0 if ok, or -FDT_ERR_NOTFOUND if something was missing > */ > +#ifdef CONFIG_OF_CONTROL > static int spi_get_config(const void *blob, int node, struct spi_bus *bus) > { > bus->node = node; > @@ -415,6 +416,7 @@ static int process_nodes(const void *blob, int node_list[], int count) > > return 0; > } > +#endif > > /* Sadly there is no error return from this function */ > void spi_init(void) > -- > 1.7.6.5 >
On 05/03/13 22:49, Vivek Gautam wrote: > Enclosing process_nodes() and spi_get_config() inside > CONFIG_OF_CONTROL, since they are compiled only for DT systems. > > This fixes following warning: > exynos_spi.c:391:12: warning: 'process_nodes' defined but not used [-Wunused-function] > > Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com> > --- > drivers/spi/exynos_spi.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/spi/exynos_spi.c b/drivers/spi/exynos_spi.c > index be60ada..2260d59 100644 > --- a/drivers/spi/exynos_spi.c > +++ b/drivers/spi/exynos_spi.c > @@ -360,6 +360,7 @@ static inline struct exynos_spi *get_spi_base(int dev_index) > * @param bus SPI bus structure to fill with information > * @return 0 if ok, or -FDT_ERR_NOTFOUND if something was missing > */ > +#ifdef CONFIG_OF_CONTROL > static int spi_get_config(const void *blob, int node, struct spi_bus *bus) > { > bus->node = node; > @@ -415,6 +416,7 @@ static int process_nodes(const void *blob, int node_list[], int count) > > return 0; > } > +#endif > > /* Sadly there is no error return from this function */ > void spi_init(void) > applied to u-boot-samsung. Thanks, Minkyu Kang.
diff --git a/drivers/spi/exynos_spi.c b/drivers/spi/exynos_spi.c index be60ada..2260d59 100644 --- a/drivers/spi/exynos_spi.c +++ b/drivers/spi/exynos_spi.c @@ -360,6 +360,7 @@ static inline struct exynos_spi *get_spi_base(int dev_index) * @param bus SPI bus structure to fill with information * @return 0 if ok, or -FDT_ERR_NOTFOUND if something was missing */ +#ifdef CONFIG_OF_CONTROL static int spi_get_config(const void *blob, int node, struct spi_bus *bus) { bus->node = node; @@ -415,6 +416,7 @@ static int process_nodes(const void *blob, int node_list[], int count) return 0; } +#endif /* Sadly there is no error return from this function */ void spi_init(void)
Enclosing process_nodes() and spi_get_config() inside CONFIG_OF_CONTROL, since they are compiled only for DT systems. This fixes following warning: exynos_spi.c:391:12: warning: 'process_nodes' defined but not used [-Wunused-function] Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com> --- drivers/spi/exynos_spi.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)