diff mbox series

[v3,03/16] tcg/aarch64: Remove reloc_pc26_atomic

Message ID 20181130215221.20554-4-richard.henderson@linaro.org
State Superseded
Headers show
Series tcg: Assorted cleanups | expand

Commit Message

Richard Henderson Nov. 30, 2018, 9:52 p.m. UTC
It is unused since b68686bd4bfeb70040b4099df993dfa0b4f37b03.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

---
 tcg/aarch64/tcg-target.inc.c | 12 ------------
 1 file changed, 12 deletions(-)

-- 
2.17.2

Comments

Alex Bennée Dec. 3, 2018, 8:44 a.m. UTC | #1
Richard Henderson <richard.henderson@linaro.org> writes:

> It is unused since b68686bd4bfeb70040b4099df993dfa0b4f37b03.

>

> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


Reviewed-by: Alex Bennée <alex.bennee@linaro.org>


> ---

>  tcg/aarch64/tcg-target.inc.c | 12 ------------

>  1 file changed, 12 deletions(-)

>

> diff --git a/tcg/aarch64/tcg-target.inc.c b/tcg/aarch64/tcg-target.inc.c

> index 083592a4d7..a41b633960 100644

> --- a/tcg/aarch64/tcg-target.inc.c

> +++ b/tcg/aarch64/tcg-target.inc.c

> @@ -87,18 +87,6 @@ static inline void reloc_pc26(tcg_insn_unit *code_ptr, tcg_insn_unit *target)

>      *code_ptr = deposit32(*code_ptr, 0, 26, offset);

>  }

>

> -static inline void reloc_pc26_atomic(tcg_insn_unit *code_ptr,

> -                                     tcg_insn_unit *target)

> -{

> -    ptrdiff_t offset = target - code_ptr;

> -    tcg_insn_unit insn;

> -    tcg_debug_assert(offset == sextract64(offset, 0, 26));

> -    /* read instruction, mask away previous PC_REL26 parameter contents,

> -       set the proper offset, then write back the instruction. */

> -    insn = atomic_read(code_ptr);

> -    atomic_set(code_ptr, deposit32(insn, 0, 26, offset));

> -}

> -

>  static inline void reloc_pc19(tcg_insn_unit *code_ptr, tcg_insn_unit *target)

>  {

>      ptrdiff_t offset = target - code_ptr;



--
Alex Bennée
diff mbox series

Patch

diff --git a/tcg/aarch64/tcg-target.inc.c b/tcg/aarch64/tcg-target.inc.c
index 083592a4d7..a41b633960 100644
--- a/tcg/aarch64/tcg-target.inc.c
+++ b/tcg/aarch64/tcg-target.inc.c
@@ -87,18 +87,6 @@  static inline void reloc_pc26(tcg_insn_unit *code_ptr, tcg_insn_unit *target)
     *code_ptr = deposit32(*code_ptr, 0, 26, offset);
 }
 
-static inline void reloc_pc26_atomic(tcg_insn_unit *code_ptr,
-                                     tcg_insn_unit *target)
-{
-    ptrdiff_t offset = target - code_ptr;
-    tcg_insn_unit insn;
-    tcg_debug_assert(offset == sextract64(offset, 0, 26));
-    /* read instruction, mask away previous PC_REL26 parameter contents,
-       set the proper offset, then write back the instruction. */
-    insn = atomic_read(code_ptr);
-    atomic_set(code_ptr, deposit32(insn, 0, 26, offset));
-}
-
 static inline void reloc_pc19(tcg_insn_unit *code_ptr, tcg_insn_unit *target)
 {
     ptrdiff_t offset = target - code_ptr;