diff mbox series

[v3,05/16] tcg/arm: Remove reloc_pc24_atomic

Message ID 20181130215221.20554-6-richard.henderson@linaro.org
State Superseded
Headers show
Series tcg: Assorted cleanups | expand

Commit Message

Richard Henderson Nov. 30, 2018, 9:52 p.m. UTC
It is unused since 3fb53fb4d12f2e7833bd1659e6013237b130ef20.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

---
 tcg/arm/tcg-target.inc.c | 8 --------
 1 file changed, 8 deletions(-)

-- 
2.17.2

Comments

Alex Bennée Dec. 3, 2018, 3:49 p.m. UTC | #1
Richard Henderson <richard.henderson@linaro.org> writes:

> It is unused since 3fb53fb4d12f2e7833bd1659e6013237b130ef20.

>

> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


Reviewed-by: Alex Bennée <alex.bennee@linaro.org>


> ---

>  tcg/arm/tcg-target.inc.c | 8 --------

>  1 file changed, 8 deletions(-)

>

> diff --git a/tcg/arm/tcg-target.inc.c b/tcg/arm/tcg-target.inc.c

> index e1fbf465cb..1142eb13ad 100644

> --- a/tcg/arm/tcg-target.inc.c

> +++ b/tcg/arm/tcg-target.inc.c

> @@ -193,14 +193,6 @@ static inline void reloc_pc24(tcg_insn_unit *code_ptr, tcg_insn_unit *target)

>      *code_ptr = (*code_ptr & ~0xffffff) | (offset & 0xffffff);

>  }

>

> -static inline void reloc_pc24_atomic(tcg_insn_unit *code_ptr, tcg_insn_unit *target)

> -{

> -    ptrdiff_t offset = (tcg_ptr_byte_diff(target, code_ptr) - 8) >> 2;

> -    tcg_insn_unit insn = atomic_read(code_ptr);

> -    tcg_debug_assert(offset == sextract32(offset, 0, 24));

> -    atomic_set(code_ptr, deposit32(insn, 0, 24, offset));

> -}

> -

>  static void patch_reloc(tcg_insn_unit *code_ptr, int type,

>                          intptr_t value, intptr_t addend)

>  {



--
Alex Bennée
diff mbox series

Patch

diff --git a/tcg/arm/tcg-target.inc.c b/tcg/arm/tcg-target.inc.c
index e1fbf465cb..1142eb13ad 100644
--- a/tcg/arm/tcg-target.inc.c
+++ b/tcg/arm/tcg-target.inc.c
@@ -193,14 +193,6 @@  static inline void reloc_pc24(tcg_insn_unit *code_ptr, tcg_insn_unit *target)
     *code_ptr = (*code_ptr & ~0xffffff) | (offset & 0xffffff);
 }
 
-static inline void reloc_pc24_atomic(tcg_insn_unit *code_ptr, tcg_insn_unit *target)
-{
-    ptrdiff_t offset = (tcg_ptr_byte_diff(target, code_ptr) - 8) >> 2;
-    tcg_insn_unit insn = atomic_read(code_ptr);
-    tcg_debug_assert(offset == sextract32(offset, 0, 24));
-    atomic_set(code_ptr, deposit32(insn, 0, 24, offset));
-}
-
 static void patch_reloc(tcg_insn_unit *code_ptr, int type,
                         intptr_t value, intptr_t addend)
 {