[edk2,edk2-platforms,5/6] Platform: add acpiview to Seattle/Styx platforms

Message ID 20181205185020.21441-6-ard.biesheuvel@linaro.org
State New
Headers show
Series
  • Styx: fixes for IASL abuse and more
Related show

Commit Message

Ard Biesheuvel Dec. 5, 2018, 6:50 p.m.
Enable the 'acpiview' UEFI shell command so we can inspect the ACPI
tables at boot time.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

---
 Platform/AMD/OverdriveBoard/OverdriveBoard.dsc              | 1 +
 Platform/LeMaker/CelloBoard/CelloBoard.dsc                  | 1 +
 Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 1 +
 3 files changed, 3 insertions(+)

-- 
2.19.2

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Carsey, Jaben Dec. 5, 2018, 9:39 p.m. | #1
You didn't CC anyone, but that is the right syntax for adding the shell command.

Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>


> -----Original Message-----

> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of

> Ard Biesheuvel

> Sent: Wednesday, December 05, 2018 10:50 AM

> To: edk2-devel@lists.01.org

> Cc: alan@softiron.co.uk

> Subject: [edk2] [PATCH edk2-platforms 5/6] Platform: add acpiview to

> Seattle/Styx platforms

> Importance: High

> 

> Enable the 'acpiview' UEFI shell command so we can inspect the ACPI

> tables at boot time.

> 

> Contributed-under: TianoCore Contribution Agreement 1.1

> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---

>  Platform/AMD/OverdriveBoard/OverdriveBoard.dsc              | 1 +

>  Platform/LeMaker/CelloBoard/CelloBoard.dsc                  | 1 +

>  Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 1 +

>  3 files changed, 3 insertions(+)

> 

> diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc

> b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc

> index 7c66af6128c5..ed67c986b7db 100644

> --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc

> +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc

> @@ -731,6 +731,7 @@ DEFINE DO_CAPSULE   = FALSE

> 

> NULL|ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Com

> mandsLib.inf

> 

> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1Com

> mandsLib.inf

> 

> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1

> CommandsLib.inf

> +

> NULL|ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCo

> mmandLib.inf

> 

> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL

> ib.inf

>        PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf

> 

> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfg

> CommandLib.inf

> diff --git a/Platform/LeMaker/CelloBoard/CelloBoard.dsc

> b/Platform/LeMaker/CelloBoard/CelloBoard.dsc

> index 7c22bbbfa90f..057bf0eb67de 100644

> --- a/Platform/LeMaker/CelloBoard/CelloBoard.dsc

> +++ b/Platform/LeMaker/CelloBoard/CelloBoard.dsc

> @@ -663,6 +663,7 @@ DEFINE DO_FLASHER   = FALSE

> 

> NULL|ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Com

> mandsLib.inf

> 

> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1Com

> mandsLib.inf

> 

> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1

> CommandsLib.inf

> +

> NULL|ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCo

> mmandLib.inf

> 

> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL

> ib.inf

>        PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf

> 

> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfg

> CommandLib.inf

> diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc

> b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc

> index 793bd5359a23..985ba2253a90 100644

> --- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc

> +++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc

> @@ -658,6 +658,7 @@ DEFINE DO_FLASHER   = FALSE

> 

> NULL|ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Com

> mandsLib.inf

> 

> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1Com

> mandsLib.inf

> 

> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1

> CommandsLib.inf

> +

> NULL|ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCo

> mmandLib.inf

> 

> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL

> ib.inf

>        PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf

> 

> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfg

> CommandLib.inf

> --

> 2.19.2

> 

> _______________________________________________

> edk2-devel mailing list

> edk2-devel@lists.01.org

> https://lists.01.org/mailman/listinfo/edk2-devel

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patch

diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
index 7c66af6128c5..ed67c986b7db 100644
--- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
+++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
@@ -731,6 +731,7 @@  DEFINE DO_CAPSULE   = FALSE
       NULL|ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf
       NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf
       NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
+      NULL|ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf
       HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
       PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
       BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
diff --git a/Platform/LeMaker/CelloBoard/CelloBoard.dsc b/Platform/LeMaker/CelloBoard/CelloBoard.dsc
index 7c22bbbfa90f..057bf0eb67de 100644
--- a/Platform/LeMaker/CelloBoard/CelloBoard.dsc
+++ b/Platform/LeMaker/CelloBoard/CelloBoard.dsc
@@ -663,6 +663,7 @@  DEFINE DO_FLASHER   = FALSE
       NULL|ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf
       NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf
       NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
+      NULL|ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf
       HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
       PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
       BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
index 793bd5359a23..985ba2253a90 100644
--- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
+++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
@@ -658,6 +658,7 @@  DEFINE DO_FLASHER   = FALSE
       NULL|ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf
       NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf
       NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
+      NULL|ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf
       HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
       PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
       BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf