From patchwork Wed Dec 5 19:50:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Herring X-Patchwork-Id: 152950 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp9695419ljp; Wed, 5 Dec 2018 11:51:26 -0800 (PST) X-Google-Smtp-Source: AFSGD/XznJ2SN9JRJ42j+6rA/y5Y/QmcQcMELx8qAjvivmFbvn3LpVo6VuSFu//sNbn17K4hheXx X-Received: by 2002:a17:902:7e4f:: with SMTP id a15mr24953619pln.149.1544039486767; Wed, 05 Dec 2018 11:51:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544039486; cv=none; d=google.com; s=arc-20160816; b=rBV+pO2y1NH3Xt2njZ04PqYrjQ/xsusEZy7BQQvBfubzNiTq34iwWjecDjDrUfVend a2lkTLI5RlUOEFV0Q8KAzfa8C5H8eNJ0XNTvVFsePtVaiezs7CwP9I74bsvE3TvDTtXB p3VZn6SJ36tCNmTy3hpdK+rYn8IJ2MwHbXSC7/DeCZCFQ0tWZTQn72o5vloR244SkTNd bABIiVUFhrXOTKtnB802L7ttrPpiPakLlI1vLjKZ2oMLRv5lsD4f0ByMpSe3KjMqbI+r BVR7sAdEVzlwhpNgaZa0hi9pxrQofoDq+P+xAiImeAg4tSEArzgcao2VqRIlJ8JAK4+5 VOdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=ezxjPp7MfWhvPHy3RISZoIqdQMGSMQgUfaCdOkJ9oEY=; b=A91njCs28CUC+ogpMmpW0ACsWlSfmof4ScE2MNfxoGOqktc/T+bxI4eN7lgIxSlmrm VoFxBtsez3DfFYFodhWNFkWfMDWcrPkT2etH3oAxMTwM3pPhnPndloWpRdwzw/SWLaVj NVIOkQECnspWGGXNYClAWQK7eAS+SMUC7dwQNCwveNpoJ7ytVR2nDlUcCSUdW2jtd/WH N68QW9XAtn8LYAvxRautNkwQZoHgZHjA0zQQ0TCfLA5xg0r+uwmwUvnFs/kw+SA+VB7Q BaP/BWpQPlI15JLcihzTxOKKn6pLRDPQZ1nIoCTHklKkDXFqOuXaoI1DF0NNgkUgAfGh nTXw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 205si20618707pfa.199.2018.12.05.11.51.26; Wed, 05 Dec 2018 11:51:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728848AbeLETvY (ORCPT + 31 others); Wed, 5 Dec 2018 14:51:24 -0500 Received: from mail-oi1-f196.google.com ([209.85.167.196]:39584 "EHLO mail-oi1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728510AbeLETvS (ORCPT ); Wed, 5 Dec 2018 14:51:18 -0500 Received: by mail-oi1-f196.google.com with SMTP id i6so18621746oia.6; Wed, 05 Dec 2018 11:51:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ezxjPp7MfWhvPHy3RISZoIqdQMGSMQgUfaCdOkJ9oEY=; b=NLZaytCuid+xH6rYjz1f3otbog65zXRO3QUFeA0k2P899FXUNExQozsCuLpVPFLN5v 7sFKqpOOltkbakLCib0MoutsUpDBJMJ3PYRORJHQv8zcnL8Jr3o0yensMQ5Zl623SNWy uBCiXJTWoUmNdGlnwywbydP0V89wFsZYlPByXSyJfpk3f9O4tIstHW0SR14fKsYQRO2k aWmqA6h0Fy9CoV2T7THzbNbMfZZ/PIl741WvHsKQrbU65BZHnQu1GpCnhvLNO866qQlu el+UV+xGx8FI5GNy30yuREaMbv5i/Zy9K3W8JnI6JZn2nD6L7fWSHrTAM2cWsjDzaTtv Ge+Q== X-Gm-Message-State: AA+aEWbF5/wtASCLSHHfV8o+lxkeB6dnmZvkcCjs8pNRW8bbDZ8TbCIZ HZl0uHv6DHxh9WOlvsZpXVinum8= X-Received: by 2002:aca:641:: with SMTP id 62mr9871445oig.63.1544039477537; Wed, 05 Dec 2018 11:51:17 -0800 (PST) Received: from xps15.herring.priv (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.googlemail.com with ESMTPSA id k13sm25759879otj.19.2018.12.05.11.51.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Dec 2018 11:51:16 -0800 (PST) From: Rob Herring To: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org Subject: [PATCH] scsi: Use of_node_name_eq for node name comparisons Date: Wed, 5 Dec 2018 13:50:39 -0600 Message-Id: <20181205195050.4759-23-robh@kernel.org> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Convert string compares of DT node names to use of_node_name_eq helper instead. This removes direct access to the node name pointer. Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org Signed-off-by: Rob Herring --- drivers/scsi/sun_esp.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) -- 2.19.1 diff --git a/drivers/scsi/sun_esp.c b/drivers/scsi/sun_esp.c index a11efbcb7f8b..c71bd01fef94 100644 --- a/drivers/scsi/sun_esp.c +++ b/drivers/scsi/sun_esp.c @@ -529,11 +529,10 @@ static int esp_sbus_probe(struct platform_device *op) int hme = 0; int ret; - if (dp->parent && - (!strcmp(dp->parent->name, "espdma") || - !strcmp(dp->parent->name, "dma"))) + if (of_node_name_eq(dp->parent, "espdma") || + of_node_name_eq(dp->parent, "dma")) dma_node = dp->parent; - else if (!strcmp(dp->name, "SUNW,fas")) { + else if (of_node_name_eq(dp, "SUNW,fas")) { dma_node = op->dev.of_node; hme = 1; }