pinctrl: Use of_node_name_eq for node name comparisons

Message ID 20181205195050.4759-20-robh@kernel.org
State Accepted
Commit eaeee373c97c638769c1e3546b32f46d30df1dbe
Headers show
Series
  • pinctrl: Use of_node_name_eq for node name comparisons
Related show

Commit Message

Rob Herring Dec. 5, 2018, 7:50 p.m.
Convert string compares of DT node names to use of_node_name_eq helper
instead. This removes direct access to the node name pointer.

Cc: Tomasz Figa <tomasz.figa@gmail.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>

---
 drivers/pinctrl/samsung/pinctrl-samsung.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.19.1

Comments

Tomasz Figa Dec. 6, 2018, 5:25 a.m. | #1
2018年12月5日(水) 11:51 Rob Herring <robh@kernel.org>:
>

> Convert string compares of DT node names to use of_node_name_eq helper

> instead. This removes direct access to the node name pointer.

>

> Cc: Tomasz Figa <tomasz.figa@gmail.com>

> Cc: Krzysztof Kozlowski <krzk@kernel.org>

> Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>

> Cc: Linus Walleij <linus.walleij@linaro.org>

> Cc: linux-arm-kernel@lists.infradead.org

> Cc: linux-samsung-soc@vger.kernel.org

> Cc: linux-gpio@vger.kernel.org

> Signed-off-by: Rob Herring <robh@kernel.org>

> ---

>  drivers/pinctrl/samsung/pinctrl-samsung.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

>

> diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c

> index ee6ee2338606..de0477bb469d 100644

> --- a/drivers/pinctrl/samsung/pinctrl-samsung.c

> +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c

> @@ -1071,7 +1071,7 @@ samsung_pinctrl_get_soc_data(struct samsung_pinctrl_drv_data *d,

>                         continue;

>                 bank = d->pin_banks;

>                 for (i = 0; i < d->nr_banks; ++i, ++bank) {

> -                       if (!strcmp(bank->name, np->name)) {

> +                       if (of_node_name_eq(np, bank->name)) {

>                                 bank->of_node = np;

>                                 break;

>                         }

> --

> 2.19.1

>


Reviewed-by: Tomasz Figa <tomasz.figa@gmail.com>


Best regards,
Tomasz
Krzysztof Kozlowski Dec. 6, 2018, 7:07 a.m. | #2
On Wed, 5 Dec 2018 at 20:51, Rob Herring <robh@kernel.org> wrote:
>

> Convert string compares of DT node names to use of_node_name_eq helper

> instead. This removes direct access to the node name pointer.

>

> Cc: Tomasz Figa <tomasz.figa@gmail.com>

> Cc: Krzysztof Kozlowski <krzk@kernel.org>

> Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>

> Cc: Linus Walleij <linus.walleij@linaro.org>

> Cc: linux-arm-kernel@lists.infradead.org

> Cc: linux-samsung-soc@vger.kernel.org

> Cc: linux-gpio@vger.kernel.org

> Signed-off-by: Rob Herring <robh@kernel.org>

> ---

>  drivers/pinctrl/samsung/pinctrl-samsung.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)


Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>


Linus,
I do not have anything queued in pinctrl samsung for next release, so
maybe you could apply this directly?

Best regards,
Krzysztof

Patch

diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c
index ee6ee2338606..de0477bb469d 100644
--- a/drivers/pinctrl/samsung/pinctrl-samsung.c
+++ b/drivers/pinctrl/samsung/pinctrl-samsung.c
@@ -1071,7 +1071,7 @@  samsung_pinctrl_get_soc_data(struct samsung_pinctrl_drv_data *d,
 			continue;
 		bank = d->pin_banks;
 		for (i = 0; i < d->nr_banks; ++i, ++bank) {
-			if (!strcmp(bank->name, np->name)) {
+			if (of_node_name_eq(np, bank->name)) {
 				bank->of_node = np;
 				break;
 			}