From patchwork Mon Dec 10 20:45:36 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 153344 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp3993557ljp; Mon, 10 Dec 2018 12:46:04 -0800 (PST) X-Google-Smtp-Source: AFSGD/WlOyFuHUu2a2WYthUthkLzP/LpKWzPZ8EscX3NsxpsL2A9ED1ahby7sAvxXDTey4VmecHu X-Received: by 2002:a63:495b:: with SMTP id y27mr12113200pgk.32.1544474764046; Mon, 10 Dec 2018 12:46:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544474764; cv=none; d=google.com; s=arc-20160816; b=fAtkstrDpyhiTJDoB89iQltFV8yZ6x1qn/JBoGeQgIEZDw3oBcZ2Lr3R0KOYujEdXM RF7zxlNKHkJ06PHGlnK6528UZ2ZzO0VAJEBaaIH/FrfOyAh7KzTOvKpjHLdnPgLhF1f3 RFCJY5IE8VtKLcRSFVjh4Rl+kJcrlSe3+vYNxmIAe3vrDe02ChWPRyn1LXwXXSpsbtnr 02MDyy0nseJdXSpFn/j7llQ36DXPbFz3ogwYEnTbictneAZdizfz8uJ988N3QpdNmt3d oCZ4TTSOSSKRVrqW85kDF1hSsEMUDmgNCdNUKrvYt9FXUV2CTaQe8XJvoKIYK/PXyH7G 3jbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=iL00lSfd/2qP72ln/jY50BbRme+P6egp8OeGchOb5fI=; b=lkZMjIk8sIV5Qa7tbPhPDA4weopoy/rs2kTA1Dh343cQyQWcYcvzW3fZM8ZkftDRvt vpEeP9uIVTGagHTFSA8vdEZL6bGjBmBNFOgqAeAHOJsoAfI2+Rh3UrB2Guzjk3jXTbtK yGw1gKwv0CMbyBaf6Ywtzm4C6wmhULdKDxzpOs5+SADPvIL389bWMMp6WK2uwbbpBLih /2eryALq4wdE6w4qoqqOnBvTHSVT0R/MBxHmzCnT6vR4H8mGT3Cx7AFKnKz3hHkp9UbB U1OhtdVW7JtIs8BalxtI99t6XU/cx2Sy5kkDuNcBBWMTNItFw7uR+0ZnugAwnsVtmcuB irJg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-mmc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-mmc-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c8si11503939pfe.243.2018.12.10.12.46.03; Mon, 10 Dec 2018 12:46:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-mmc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-mmc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-mmc-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726912AbeLJUqD (ORCPT + 5 others); Mon, 10 Dec 2018 15:46:03 -0500 Received: from mout.kundenserver.de ([212.227.126.134]:60849 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726720AbeLJUqD (ORCPT ); Mon, 10 Dec 2018 15:46:03 -0500 Received: from wuerfel.lan ([109.192.41.194]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.129]) with ESMTPA (Nemesis) id 1N4yqC-1hUmoZ2uKy-010uIx; Mon, 10 Dec 2018 21:45:47 +0100 From: Arnd Bergmann To: Adrian Hunter , Ulf Hansson Cc: Arnd Bergmann , Vijay Viswanath , Evan Green , Sayali Lokhande , Veerabhadrarao Badiganti , "weiyongjun (A)" , Loic Poulain , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] mmc: sdhci-msm: avoid unused function warning Date: Mon, 10 Dec 2018 21:45:36 +0100 Message-Id: <20181210204546.2384299-1-arnd@arndb.de> X-Mailer: git-send-email 2.20.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:zEJx0bDd6tl+VoEOfulBPFWryW46KUhq3qSGXgTOahAORc4HTlf YLDsReyLbx+mR/9gIMY9qjVGc00Sr+sNWGVjNfBuSDmafvfJ1YFTjtvlBNlIOh/ulCTKwA3 ow+7Mj8ufRLG/BjY6UnUwgzKVUADgI3OiGZWWGFoAYIUb0qT3PHpxXGELN8CliDHSPghEGF OwsBMw2mk1ADQWr9ZTaJQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:NqfvuMT9nos=:0j0QZvm8nWNgw80sNJn5Jc vvGI7FcycBG+pH1P+Z9N/ij4PVAWFUirvy/bRPGhBstQBRbf2iGCRJ0SUxlpkFXjQZeg0q00n ndPA8lK3UmHFDj0eBTOBUTAwYPCDR7ELwOJisKm2zt12T1e61OLPs3Qz6AgA5cBGh5gEkPwdP Dolf/zkRChAqEAZYmw+3T8tMIFPhUfqJrCcCdjnTK9K32EgjwdItUaGDu9dUTBxFJtcVFVXA2 fVuMSADh5YCKYjvanibpCLCdPB9xGy32/TvprhdyChF3u7XVzQ+dBgGvMx8vNHMDs9icYWDU/ nKRZ9igYLHMqwzdkGMAd9iFHymEg31sq9xeH3HkTQuEeOZKqh+QAi4oU8z4qJz9rDjejL7wiO 1OEgxqV3Qvwos9egtWeZTiOXbLRGwYlK+hvmF9EuMqt9cWPeq+g52NPe40y7N216M6JAvSv2+ 7iNNmYds88SvS/4Mxxe57q3BIev8oGKIkoiuu/ePyMq7dO7wNY12k2DWs3mVybQe+fpbHUD86 DmH3RiVwmXRsoMPFz/LzUqyZd/vdgnGdzL6AhbT+UjAzHXIf5ds4Ev+TGRs6RhJsc8H/zX+Da 5PXwL7JGu/z5uLJlyPh7pa2vlqnWHosrlxyn+akT3vxI413BSUjkgOLWsv89PWb9D1oJOHLYS 3Qn03gfMWKof4npNZI58yUGxAdlm+uwuKGOjQLfVfTI0hBVieyr1But4okThF7BaI9eTYIVoC TLeDE4REQBFw6AeYBKSy+5P0eK4lgWLLfRYiZg== Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The newly added sdhci_msm_restore_sdr_dll_config() function is only called if CONFIG_PM is enabled: drivers/mmc/host/sdhci-msm.c:1050:12: error: 'sdhci_msm_restore_sdr_dll_config' defined but not used [-Werror=unused-function] Better remove the incorrect #ifdef altogether and just use __maybe_unused, which is harder to get wrong. Fixes: ec3349733550 ("mmc: sdhci-msm: Re-initialize DLL if MCLK is gated dynamically") Signed-off-by: Arnd Bergmann --- drivers/mmc/host/sdhci-msm.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) -- 2.20.0 Acked-by: Adrian Hunter diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c index 5497a71abe07..d6c9ebd8d263 100644 --- a/drivers/mmc/host/sdhci-msm.c +++ b/drivers/mmc/host/sdhci-msm.c @@ -1997,8 +1997,7 @@ static int sdhci_msm_remove(struct platform_device *pdev) return 0; } -#ifdef CONFIG_PM -static int sdhci_msm_runtime_suspend(struct device *dev) +static __maybe_unused int sdhci_msm_runtime_suspend(struct device *dev) { struct sdhci_host *host = dev_get_drvdata(dev); struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); @@ -2010,7 +2009,7 @@ static int sdhci_msm_runtime_suspend(struct device *dev) return 0; } -static int sdhci_msm_runtime_resume(struct device *dev) +static __maybe_unused int sdhci_msm_runtime_resume(struct device *dev) { struct sdhci_host *host = dev_get_drvdata(dev); struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); @@ -2030,7 +2029,6 @@ static int sdhci_msm_runtime_resume(struct device *dev) return 0; } -#endif static const struct dev_pm_ops sdhci_msm_pm_ops = { SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,