diff mbox series

[4/4] ARM: pxa: avoid section mismatch warning

Message ID 20181210215856.2238253-4-arnd@arndb.de
State New
Headers show
Series None | expand

Commit Message

Arnd Bergmann Dec. 10, 2018, 9:58 p.m. UTC
WARNING: vmlinux.o(.text+0x19f90): Section mismatch in reference from the function littleton_init_lcd() to the function .init.text:pxa_set_fb_info()
The function littleton_init_lcd() references
the function __init pxa_set_fb_info().
This is often because littleton_init_lcd lacks a __init
annotation or the annotation of pxa_set_fb_info is wrong.

WARNING: vmlinux.o(.text+0xf824): Section mismatch in reference from the function zeus_register_ohci() to the function .init.text:pxa_set_ohci_info()
The function zeus_register_ohci() references
the function __init pxa_set_ohci_info().
This is often because zeus_register_ohci lacks a __init
annotation or the annotation of pxa_set_ohci_info is wrong.

WARNING: vmlinux.o(.text+0xf95c): Section mismatch in reference from the function cm_x300_init_u2d() to the function .init.text:pxa3xx_set_u2d_info()
The function cm_x300_init_u2d() references
the function __init pxa3xx_set_u2d_info().
This is often because cm_x300_init_u2d lacks a __init
annotation or the annotation of pxa3xx_set_u2d_info is wrong.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 arch/arm/mach-pxa/cm-x300.c   | 2 +-
 arch/arm/mach-pxa/littleton.c | 2 +-
 arch/arm/mach-pxa/zeus.c      | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

-- 
2.20.0

Comments

Ulf Hansson Dec. 11, 2018, 9:39 a.m. UTC | #1
On Mon, 10 Dec 2018 at 23:00, Arnd Bergmann <arnd@arndb.de> wrote:
>

> WARNING: vmlinux.o(.text+0x19f90): Section mismatch in reference from the function littleton_init_lcd() to the function .init.text:pxa_set_fb_info()

> The function littleton_init_lcd() references

> the function __init pxa_set_fb_info().

> This is often because littleton_init_lcd lacks a __init

> annotation or the annotation of pxa_set_fb_info is wrong.

>

> WARNING: vmlinux.o(.text+0xf824): Section mismatch in reference from the function zeus_register_ohci() to the function .init.text:pxa_set_ohci_info()

> The function zeus_register_ohci() references

> the function __init pxa_set_ohci_info().

> This is often because zeus_register_ohci lacks a __init

> annotation or the annotation of pxa_set_ohci_info is wrong.

>

> WARNING: vmlinux.o(.text+0xf95c): Section mismatch in reference from the function cm_x300_init_u2d() to the function .init.text:pxa3xx_set_u2d_info()

> The function cm_x300_init_u2d() references

> the function __init pxa3xx_set_u2d_info().

> This is often because cm_x300_init_u2d lacks a __init

> annotation or the annotation of pxa3xx_set_u2d_info is wrong.

>

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>


I have queued a bunch of pxa changes via my mmc tree for gpio
descriptor conversions, by Linus Walleij.

Are those causing this problem? Should I queue this one via mmc tree as well?

Kind regards
Uffe

> ---

>  arch/arm/mach-pxa/cm-x300.c   | 2 +-

>  arch/arm/mach-pxa/littleton.c | 2 +-

>  arch/arm/mach-pxa/zeus.c      | 2 +-

>  3 files changed, 3 insertions(+), 3 deletions(-)

>

> diff --git a/arch/arm/mach-pxa/cm-x300.c b/arch/arm/mach-pxa/cm-x300.c

> index 109fab292f94..b76b566280fa 100644

> --- a/arch/arm/mach-pxa/cm-x300.c

> +++ b/arch/arm/mach-pxa/cm-x300.c

> @@ -564,7 +564,7 @@ static struct pxa3xx_u2d_platform_data cm_x300_u2d_platform_data = {

>         .exit           = cm_x300_u2d_exit,

>  };

>

> -static void cm_x300_init_u2d(void)

> +static void __init cm_x300_init_u2d(void)

>  {

>         pxa3xx_set_u2d_info(&cm_x300_u2d_platform_data);

>  }

> diff --git a/arch/arm/mach-pxa/littleton.c b/arch/arm/mach-pxa/littleton.c

> index 8e0b60a33026..39db4898dc4a 100644

> --- a/arch/arm/mach-pxa/littleton.c

> +++ b/arch/arm/mach-pxa/littleton.c

> @@ -182,7 +182,7 @@ static struct pxafb_mach_info littleton_lcd_info = {

>         .lcd_conn               = LCD_COLOR_TFT_16BPP,

>  };

>

> -static void littleton_init_lcd(void)

> +static void __init littleton_init_lcd(void)

>  {

>         pxa_set_fb_info(NULL, &littleton_lcd_info);

>  }

> diff --git a/arch/arm/mach-pxa/zeus.c b/arch/arm/mach-pxa/zeus.c

> index 897ef59fbe0c..c411f79d4cb5 100644

> --- a/arch/arm/mach-pxa/zeus.c

> +++ b/arch/arm/mach-pxa/zeus.c

> @@ -576,7 +576,7 @@ static struct pxaohci_platform_data zeus_ohci_platform_data = {

>         .flags          = ENABLE_PORT_ALL | POWER_SENSE_LOW,

>  };

>

> -static void zeus_register_ohci(void)

> +static void __init zeus_register_ohci(void)

>  {

>         /* Port 2 is shared between host and client interface. */

>         UP2OCR = UP2OCR_HXOE | UP2OCR_HXS | UP2OCR_DMPDE | UP2OCR_DPPDE;

> --

> 2.20.0

>
Arnd Bergmann Dec. 11, 2018, 10:10 a.m. UTC | #2
On Tue, Dec 11, 2018 at 10:40 AM Ulf Hansson <ulf.hansson@linaro.org> wrote:
>

> On Mon, 10 Dec 2018 at 23:00, Arnd Bergmann <arnd@arndb.de> wrote:

> >

> > WARNING: vmlinux.o(.text+0x19f90): Section mismatch in reference from the function littleton_init_lcd() to the function .init.text:pxa_set_fb_info()

> > The function littleton_init_lcd() references

> > the function __init pxa_set_fb_info().

> > This is often because littleton_init_lcd lacks a __init

> > annotation or the annotation of pxa_set_fb_info is wrong.

> >

> > WARNING: vmlinux.o(.text+0xf824): Section mismatch in reference from the function zeus_register_ohci() to the function .init.text:pxa_set_ohci_info()

> > The function zeus_register_ohci() references

> > the function __init pxa_set_ohci_info().

> > This is often because zeus_register_ohci lacks a __init

> > annotation or the annotation of pxa_set_ohci_info is wrong.

> >

> > WARNING: vmlinux.o(.text+0xf95c): Section mismatch in reference from the function cm_x300_init_u2d() to the function .init.text:pxa3xx_set_u2d_info()

> > The function cm_x300_init_u2d() references

> > the function __init pxa3xx_set_u2d_info().

> > This is often because cm_x300_init_u2d lacks a __init

> > annotation or the annotation of pxa3xx_set_u2d_info is wrong.

> >

> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>

>

> I have queued a bunch of pxa changes via my mmc tree for gpio

> descriptor conversions, by Linus Walleij.

>

> Are those causing this problem? Should I queue this one via mmc tree as well?


Sorry for the lack of description in the changelog. I'm fairly sure that these
are old bugs that only appeared now if you build with CONFIG_NO_AUTO_INLINE,
we should take these through arm-soc, and I should probably add an explanation.

      Arnd
Linus Walleij Dec. 11, 2018, 10:44 a.m. UTC | #3
On Tue, Dec 11, 2018 at 10:40 AM Ulf Hansson <ulf.hansson@linaro.org> wrote:
> On Mon, 10 Dec 2018 at 23:00, Arnd Bergmann <arnd@arndb.de> wrote:

> >

> > WARNING: vmlinux.o(.text+0x19f90): Section mismatch in reference from the function littleton_init_lcd() to the function .init.text:pxa_set_fb_info()

> > The function littleton_init_lcd() references

> > the function __init pxa_set_fb_info().

> > This is often because littleton_init_lcd lacks a __init

> > annotation or the annotation of pxa_set_fb_info is wrong.

> >

> > WARNING: vmlinux.o(.text+0xf824): Section mismatch in reference from the function zeus_register_ohci() to the function .init.text:pxa_set_ohci_info()

> > The function zeus_register_ohci() references

> > the function __init pxa_set_ohci_info().

> > This is often because zeus_register_ohci lacks a __init

> > annotation or the annotation of pxa_set_ohci_info is wrong.

> >

> > WARNING: vmlinux.o(.text+0xf95c): Section mismatch in reference from the function cm_x300_init_u2d() to the function .init.text:pxa3xx_set_u2d_info()

> > The function cm_x300_init_u2d() references

> > the function __init pxa3xx_set_u2d_info().

> > This is often because cm_x300_init_u2d lacks a __init

> > annotation or the annotation of pxa3xx_set_u2d_info is wrong.

> >

> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>

>

> I have queued a bunch of pxa changes via my mmc tree for gpio

> descriptor conversions, by Linus Walleij.

>

> Are those causing this problem? Should I queue this one via mmc tree as well?


Nopes just correlation without causation...

I also made a bunch of patches to PXA through the regulator tree,
those are not related either.

It *seems* they touch so different code lines that it shouldn't
be a problem to merge orthogonally in ARM SoC.

Yours,
Linus Walleij
Olof Johansson Dec. 12, 2018, 9:56 p.m. UTC | #4
On Mon, Dec 10, 2018 at 10:58:39PM +0100, Arnd Bergmann wrote:
> WARNING: vmlinux.o(.text+0x19f90): Section mismatch in reference from the function littleton_init_lcd() to the function .init.text:pxa_set_fb_info()

> The function littleton_init_lcd() references

> the function __init pxa_set_fb_info().

> This is often because littleton_init_lcd lacks a __init

> annotation or the annotation of pxa_set_fb_info is wrong.

> 

> WARNING: vmlinux.o(.text+0xf824): Section mismatch in reference from the function zeus_register_ohci() to the function .init.text:pxa_set_ohci_info()

> The function zeus_register_ohci() references

> the function __init pxa_set_ohci_info().

> This is often because zeus_register_ohci lacks a __init

> annotation or the annotation of pxa_set_ohci_info is wrong.

> 

> WARNING: vmlinux.o(.text+0xf95c): Section mismatch in reference from the function cm_x300_init_u2d() to the function .init.text:pxa3xx_set_u2d_info()

> The function cm_x300_init_u2d() references

> the function __init pxa3xx_set_u2d_info().

> This is often because cm_x300_init_u2d lacks a __init

> annotation or the annotation of pxa3xx_set_u2d_info is wrong.

> 

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>


Applied to next/soc.


-Olof
diff mbox series

Patch

diff --git a/arch/arm/mach-pxa/cm-x300.c b/arch/arm/mach-pxa/cm-x300.c
index 109fab292f94..b76b566280fa 100644
--- a/arch/arm/mach-pxa/cm-x300.c
+++ b/arch/arm/mach-pxa/cm-x300.c
@@ -564,7 +564,7 @@  static struct pxa3xx_u2d_platform_data cm_x300_u2d_platform_data = {
 	.exit		= cm_x300_u2d_exit,
 };
 
-static void cm_x300_init_u2d(void)
+static void __init cm_x300_init_u2d(void)
 {
 	pxa3xx_set_u2d_info(&cm_x300_u2d_platform_data);
 }
diff --git a/arch/arm/mach-pxa/littleton.c b/arch/arm/mach-pxa/littleton.c
index 8e0b60a33026..39db4898dc4a 100644
--- a/arch/arm/mach-pxa/littleton.c
+++ b/arch/arm/mach-pxa/littleton.c
@@ -182,7 +182,7 @@  static struct pxafb_mach_info littleton_lcd_info = {
 	.lcd_conn		= LCD_COLOR_TFT_16BPP,
 };
 
-static void littleton_init_lcd(void)
+static void __init littleton_init_lcd(void)
 {
 	pxa_set_fb_info(NULL, &littleton_lcd_info);
 }
diff --git a/arch/arm/mach-pxa/zeus.c b/arch/arm/mach-pxa/zeus.c
index 897ef59fbe0c..c411f79d4cb5 100644
--- a/arch/arm/mach-pxa/zeus.c
+++ b/arch/arm/mach-pxa/zeus.c
@@ -576,7 +576,7 @@  static struct pxaohci_platform_data zeus_ohci_platform_data = {
 	.flags		= ENABLE_PORT_ALL | POWER_SENSE_LOW,
 };
 
-static void zeus_register_ohci(void)
+static void __init zeus_register_ohci(void)
 {
 	/* Port 2 is shared between host and client interface. */
 	UP2OCR = UP2OCR_HXOE | UP2OCR_HXS | UP2OCR_DMPDE | UP2OCR_DPPDE;